All of lore.kernel.org
 help / color / mirror / Atom feed
From: hare@suse.de (Hannes Reinecke)
Subject: NVMe wwid revisited
Date: Thu, 18 Feb 2016 14:04:28 +0100	[thread overview]
Message-ID: <56C5C15C.8030903@suse.de> (raw)

Hi Keith,

I've had a look at the current NVMe implementation for SCSI VPD page
0x83, in order to implement a generic 'wwid' field.

And I've even looked at the NVM-Express-SCSI-Translation Reference
version 1.1. What a mess :-(

First of all, there's an error in the spec:

Section 6.1.4.3 T10 Vendor ID Based Descriptor has:

DESIGNATOR TYPE
Shall be set to 8h indicating SCSI name string format and assignment
authority.

T10 VENDOR IDENTIFICATION
Refer to 3.12

VENDOR SPECIFIC IDENTIFIER
Shall be set the concatenation of the translation of PRODUCT
IDENTIFICATION field from standard INQUIRY data as specified in
3.9, and the IEEE Extended Unique Identifier (EUI64) field of the
Identify Namespace Data Structure

This does _not_ match with T-10 usage; T-10 Vendor ID based
identification is _NOT_ a scsi name string.
And the scsi name string has to start with either 'eui.', 'naa.' or
'iqn.'. Plus the SCSI name string has to be in UTF-8, not ASCII.

So I guess they actually meant for the designator type to be of T-10
Vendor Identification (ie designator type 1).

Can you address this with the NVMe committee?
Or do you have someone which I can poke?

Which, of course, raises the question: What _is_ the correct
identification?
Implement it according to the translation spec, leaving out the 'T10
Vendor Identification' field?
Or implement it with the correct designator type?

(Which is interesting in itself; one simply _cannot_ implement a
valid translation according to the spec. How curious ...)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)

             reply	other threads:[~2016-02-18 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 13:04 Hannes Reinecke [this message]
2016-02-18 13:28 ` NVMe wwid revisited Christoph Hellwig
2016-02-18 15:10   ` Keith Busch
2016-02-18 15:39     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C5C15C.8030903@suse.de \
    --to=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.