From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
"Stephen Hemminger" <stephen@networkplumber.org>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
"Tom Herbert" <tom@herbertland.com>
Subject: Re: [Bridge] [PATCH] net: fix bridge multicast packet checksum validation
Date: Thu, 18 Feb 2016 14:36:44 +0100 [thread overview]
Message-ID: <20160218133644.GL3010@otheros> (raw)
In-Reply-To: <20160218125134.GA20283@sesse.net>
On Thu, Feb 18, 2016 at 01:51:34PM +0100, Steinar H. Gunderson wrote:
> On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote:
> > Steinar, can you check whether this fixes the bridge issues you reported on
> > bugzilla #99081? Not quite sure whether it is the same as yours as you
> > do not seem to have any such call traces.
>
> It doesn't immediately sound like the same problem; why would promisc change
> anything if the problem is the checksumming?
The mdb you provided in the bugzilla ticket misses reports, so it
was unable to parse reports. Which could point to a checksumming
problem.
Enabling promisc probably did not fix the parsing for you, but instead
promisc forces to forward packets upstream on your interface independent
of the mdb. I would assume that even with promisc, your output
from "bridge mdb show" looks rather empty. Can you check?
>
> I don't have any reboots scheduled for this machine right now, but I'll see
> what I can do wrt. testing.
Thanks :).
WARNING: multiple messages have this Message-ID (diff)
From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
"Stephen Hemminger" <stephen@networkplumber.org>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
"Tom Herbert" <tom@herbertland.com>
Subject: Re: [PATCH] net: fix bridge multicast packet checksum validation
Date: Thu, 18 Feb 2016 14:36:44 +0100 [thread overview]
Message-ID: <20160218133644.GL3010@otheros> (raw)
In-Reply-To: <20160218125134.GA20283@sesse.net>
On Thu, Feb 18, 2016 at 01:51:34PM +0100, Steinar H. Gunderson wrote:
> On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote:
> > Steinar, can you check whether this fixes the bridge issues you reported on
> > bugzilla #99081? Not quite sure whether it is the same as yours as you
> > do not seem to have any such call traces.
>
> It doesn't immediately sound like the same problem; why would promisc change
> anything if the problem is the checksumming?
The mdb you provided in the bugzilla ticket misses reports, so it
was unable to parse reports. Which could point to a checksumming
problem.
Enabling promisc probably did not fix the parsing for you, but instead
promisc forces to forward packets upstream on your interface independent
of the mdb. I would assume that even with promisc, your output
from "bridge mdb show" looks rather empty. Can you check?
>
> I don't have any reboots scheduled for this machine right now, but I'll see
> what I can do wrt. testing.
Thanks :).
next prev parent reply other threads:[~2016-02-18 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 2:07 [Bridge] [PATCH] net: fix bridge multicast packet checksum validation Linus Lüssing
2016-02-15 2:07 ` Linus Lüssing
2016-02-15 2:07 ` Linus Lüssing
2016-02-18 12:51 ` [Bridge] " Steinar H. Gunderson
2016-02-18 12:51 ` Steinar H. Gunderson
2016-02-18 13:36 ` Linus Lüssing [this message]
2016-02-18 13:36 ` Linus Lüssing
2016-02-18 20:35 ` [Bridge] " David Miller
2016-02-18 20:35 ` David Miller
2016-02-19 1:38 ` [Bridge] " Stephen Hemminger
2016-02-19 1:38 ` Stephen Hemminger
2016-02-19 1:38 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218133644.GL3010@otheros \
--to=linus.luessing@c0d3.blue \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=stephen@networkplumber.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.