* [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
@ 2016-02-18 13:32 ` Thierry Reding
0 siblings, 0 replies; 14+ messages in thread
From: Thierry Reding @ 2016-02-18 13:32 UTC (permalink / raw)
To: linux-arm-kernel
From: Thierry Reding <treding@nvidia.com>
This driver uses PCI glue that is only available on 32-bit ARM. This
used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
32-bit, but that's changed now, with ARCH_MVEBU also being available
on 64-bit ARM.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/pci/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index 75a605426538..d1cdd9c992ac 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -14,6 +14,7 @@ config PCI_DRA7XX
config PCI_MVEBU
bool "Marvell EBU PCIe controller"
depends on ARCH_MVEBU || ARCH_DOVE
+ depends on ARM
depends on OF
config PCIE_DW
--
2.7.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
2016-02-18 13:32 ` Thierry Reding
@ 2016-02-18 14:06 ` Arnd Bergmann
-1 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2016-02-18 14:06 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Thierry Reding, Bjorn Helgaas, Andrew Lunn, Jason Cooper,
linux-pci, linux-kernel, linux-next, Gregory Clement,
Sebastian Hesselbarth
On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Looks fine as a temporary workaround, but I think what we really want to
do here is to remove the dependency, as the new ARM64 platforms are going
to need this driver anyway.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
@ 2016-02-18 14:06 ` Arnd Bergmann
0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2016-02-18 14:06 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Looks fine as a temporary workaround, but I think what we really want to
do here is to remove the dependency, as the new ARM64 platforms are going
to need this driver anyway.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
2016-02-18 14:06 ` Arnd Bergmann
@ 2016-02-18 14:24 ` Thierry Reding
-1 siblings, 0 replies; 14+ messages in thread
From: Thierry Reding @ 2016-02-18 14:24 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Bjorn Helgaas, Andrew Lunn, Jason Cooper,
linux-pci, linux-kernel, linux-next, Gregory Clement,
Sebastian Hesselbarth
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
On Thu, Feb 18, 2016 at 03:06:23PM +0100, Arnd Bergmann wrote:
> On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > This driver uses PCI glue that is only available on 32-bit ARM. This
> > used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> > 32-bit, but that's changed now, with ARCH_MVEBU also being available
> > on 64-bit ARM.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> Looks fine as a temporary workaround, but I think what we really want to
> do here is to remove the dependency, as the new ARM64 platforms are going
> to need this driver anyway.
Agreed. I've been meaning to do just that for Tegra as well, but the
conversion is somewhat more involved and this is currently breaking the
linux-next builds, so a quick fix, even if temporary, is warranted in my
opinion.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
@ 2016-02-18 14:24 ` Thierry Reding
0 siblings, 0 replies; 14+ messages in thread
From: Thierry Reding @ 2016-02-18 14:24 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 18, 2016 at 03:06:23PM +0100, Arnd Bergmann wrote:
> On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > This driver uses PCI glue that is only available on 32-bit ARM. This
> > used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> > 32-bit, but that's changed now, with ARCH_MVEBU also being available
> > on 64-bit ARM.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> Looks fine as a temporary workaround, but I think what we really want to
> do here is to remove the dependency, as the new ARM64 platforms are going
> to need this driver anyway.
Agreed. I've been meaning to do just that for Tegra as well, but the
conversion is somewhat more involved and this is currently breaking the
linux-next builds, so a quick fix, even if temporary, is warranted in my
opinion.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160218/a03a27ec/attachment-0001.sig>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
2016-02-18 14:06 ` Arnd Bergmann
@ 2016-02-18 14:34 ` Gregory CLEMENT
-1 siblings, 0 replies; 14+ messages in thread
From: Gregory CLEMENT @ 2016-02-18 14:34 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Thierry Reding, Bjorn Helgaas, Andrew Lunn,
Jason Cooper, linux-pci, linux-kernel, linux-next,
Sebastian Hesselbarth, Thomas Petazzoni
Hi Arnd,
On jeu., févr. 18 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> This driver uses PCI glue that is only available on 32-bit ARM. This
>> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
>> 32-bit, but that's changed now, with ARCH_MVEBU also being available
>> on 64-bit ARM.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> Looks fine as a temporary workaround, but I think what we really want to
> do here is to remove the dependency, as the new ARM64 platforms are going
> to need this driver anyway.
Actually the mvebu ARM64 platform we know about (Armada 3700, 7K and
8K), won't use the same controller. A7K/A8K will use a synopsis IP and
Armada 3700 a new Marvell IP.
So for me depending on ARM32 is enough.
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
@ 2016-02-18 14:34 ` Gregory CLEMENT
0 siblings, 0 replies; 14+ messages in thread
From: Gregory CLEMENT @ 2016-02-18 14:34 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
On jeu., f?vr. 18 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> This driver uses PCI glue that is only available on 32-bit ARM. This
>> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
>> 32-bit, but that's changed now, with ARCH_MVEBU also being available
>> on 64-bit ARM.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> Looks fine as a temporary workaround, but I think what we really want to
> do here is to remove the dependency, as the new ARM64 platforms are going
> to need this driver anyway.
Actually the mvebu ARM64 platform we know about (Armada 3700, 7K and
8K), won't use the same controller. A7K/A8K will use a synopsis IP and
Armada 3700 a new Marvell IP.
So for me depending on ARM32 is enough.
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
2016-02-18 14:34 ` Gregory CLEMENT
@ 2016-02-18 14:41 ` Arnd Bergmann
-1 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2016-02-18 14:41 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: linux-arm-kernel, Thierry Reding, Bjorn Helgaas, Andrew Lunn,
Jason Cooper, linux-pci, linux-kernel, linux-next,
Sebastian Hesselbarth, Thomas Petazzoni
On Thursday 18 February 2016 15:34:30 Gregory CLEMENT wrote:
> On jeu., févr. 18 2016, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> >> From: Thierry Reding <treding@nvidia.com>
> >>
> >> This driver uses PCI glue that is only available on 32-bit ARM. This
> >> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> >> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> >> on 64-bit ARM.
> >>
> >> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >
> > Looks fine as a temporary workaround, but I think what we really want to
> > do here is to remove the dependency, as the new ARM64 platforms are going
> > to need this driver anyway.
>
> Actually the mvebu ARM64 platform we know about (Armada 3700, 7K and
> 8K), won't use the same controller. A7K/A8K will use a synopsis IP and
> Armada 3700 a new Marvell IP.
>
> So for me depending on ARM32 is enough.
Ah, that makes things much easier indeed.
Does this mean no more MBUS on the 64-bit platforms too?
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
@ 2016-02-18 14:41 ` Arnd Bergmann
0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2016-02-18 14:41 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 18 February 2016 15:34:30 Gregory CLEMENT wrote:
> On jeu., f?vr. 18 2016, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> >> From: Thierry Reding <treding@nvidia.com>
> >>
> >> This driver uses PCI glue that is only available on 32-bit ARM. This
> >> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> >> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> >> on 64-bit ARM.
> >>
> >> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >
> > Looks fine as a temporary workaround, but I think what we really want to
> > do here is to remove the dependency, as the new ARM64 platforms are going
> > to need this driver anyway.
>
> Actually the mvebu ARM64 platform we know about (Armada 3700, 7K and
> 8K), won't use the same controller. A7K/A8K will use a synopsis IP and
> Armada 3700 a new Marvell IP.
>
> So for me depending on ARM32 is enough.
Ah, that makes things much easier indeed.
Does this mean no more MBUS on the 64-bit platforms too?
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
2016-02-18 13:32 ` Thierry Reding
@ 2016-02-18 14:29 ` Thomas Petazzoni
-1 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2016-02-18 14:29 UTC (permalink / raw)
To: Thierry Reding
Cc: Bjorn Helgaas, Andrew Lunn, Jason Cooper, linux-pci, linux-kernel,
linux-next, Gregory Clement, linux-arm-kernel,
Sebastian Hesselbarth
Hello,
On Thu, 18 Feb 2016 14:32:10 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/pci/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
@ 2016-02-18 14:29 ` Thomas Petazzoni
0 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2016-02-18 14:29 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Thu, 18 Feb 2016 14:32:10 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/pci/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
2016-02-18 13:32 ` Thierry Reding
@ 2016-02-26 19:31 ` Bjorn Helgaas
-1 siblings, 0 replies; 14+ messages in thread
From: Bjorn Helgaas @ 2016-02-26 19:31 UTC (permalink / raw)
To: Thierry Reding
Cc: Bjorn Helgaas, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, linux-pci, linux-arm-kernel, linux-kernel,
linux-next
On Thu, Feb 18, 2016 at 02:32:10PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
I applied this with Thomas' ack to my for-linus branch for v4.5, thanks
Thierry!
> ---
> drivers/pci/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 75a605426538..d1cdd9c992ac 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -14,6 +14,7 @@ config PCI_DRA7XX
> config PCI_MVEBU
> bool "Marvell EBU PCIe controller"
> depends on ARCH_MVEBU || ARCH_DOVE
> + depends on ARM
> depends on OF
>
> config PCIE_DW
> --
> 2.7.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] PCI: mvebu: Restrict build to 32-bit ARM
@ 2016-02-26 19:31 ` Bjorn Helgaas
0 siblings, 0 replies; 14+ messages in thread
From: Bjorn Helgaas @ 2016-02-26 19:31 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 18, 2016 at 02:32:10PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
I applied this with Thomas' ack to my for-linus branch for v4.5, thanks
Thierry!
> ---
> drivers/pci/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 75a605426538..d1cdd9c992ac 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -14,6 +14,7 @@ config PCI_DRA7XX
> config PCI_MVEBU
> bool "Marvell EBU PCIe controller"
> depends on ARCH_MVEBU || ARCH_DOVE
> + depends on ARM
> depends on OF
>
> config PCIE_DW
> --
> 2.7.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread