From: Ralf Baechle <ralf@linux-mips.org>
To: Insu Yun <wuninsu@gmail.com>
Cc: David Miller <davem@davemloft.net>,
linux-hams@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Taesoo Kim <taesoo@gatech.edu>,
Yeongjin Jang <yeongjin.jang@gatech.edu>,
"Yun, Insu" <insu@gatech.edu>, Changwoo Min <changwoo@gatech.edu>
Subject: Re: [PATCH] rose: correct integer overflow check
Date: Fri, 19 Feb 2016 00:21:36 +0100 [thread overview]
Message-ID: <20160218232136.GB11796@linux-mips.org> (raw)
In-Reply-To: <CAGoFzNd3egg-36bg3DRU=2b5weyuf-CLTcgfWUQmY7kjdBwuNg@mail.gmail.com>
On Thu, Feb 18, 2016 at 04:03:16PM -0500, Insu Yun wrote:
>
> Because of the types on the right hand side of the comparison
> the expressions are all promoted to unsigned.
>
> Did you look at the compiler's assembler output? I did when
> reviewing your patch.
>
>
> I checked the assembler output right now.
> You are right.
> I realized that right hand side becomes unsigned due to sizeof.
> I think this patch is wrong.
> Thanks.
On a different level, the current whole approach of ROSE to just generate
a fixed number of devices at initialization time of ROSE is if not wrong
then at least very archaic. The default number is 10 devices and probably
of those 9 are unused on a typical setup - that is, if the module has
been loaded intentionally at all.
As a solution I've implemented a patch to support creating of ROSE
devices through netlink plus the necessary changes to iproute2 to go
along with that.
Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Insu Yun <wuninsu@gmail.com>
Cc: David Miller <davem@davemloft.net>,
linux-hams@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Taesoo Kim <taesoo@gatech.edu>,
Yeongjin Jang <yeongjin.jang@gatech.edu>,
"Yun, Insu" <insu@gatech.edu>, Changwoo Min <changwoo@gatech.edu>
Subject: Re: [PATCH] rose: correct integer overflow check
Date: Fri, 19 Feb 2016 00:21:36 +0100 [thread overview]
Message-ID: <20160218232136.GB11796@linux-mips.org> (raw)
In-Reply-To: <CAGoFzNd3egg-36bg3DRU=2b5weyuf-CLTcgfWUQmY7kjdBwuNg@mail.gmail.com>
On Thu, Feb 18, 2016 at 04:03:16PM -0500, Insu Yun wrote:
>
> Because of the types on the right hand side of the comparison
> the expressions are all promoted to unsigned.
>
> Did you look at the compiler's assembler output? I did when
> reviewing your patch.
>
>
> I checked the assembler output right now.
> You are right.
> I realized that right hand side becomes unsigned due to sizeof.
> I think this patch is wrong.
> Thanks.
On a different level, the current whole approach of ROSE to just generate
a fixed number of devices at initialization time of ROSE is if not wrong
then at least very archaic. The default number is 10 devices and probably
of those 9 are unused on a typical setup - that is, if the module has
been loaded intentionally at all.
As a solution I've implemented a patch to support creating of ROSE
devices through netlink plus the necessary changes to iproute2 to go
along with that.
Ralf
next prev parent reply other threads:[~2016-02-18 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 20:25 [PATCH] rose: correct integer overflow check Insu Yun
2016-02-18 20:33 ` David Miller
[not found] ` <CAGoFzNd3egg-36bg3DRU=2b5weyuf-CLTcgfWUQmY7kjdBwuNg@mail.gmail.com>
2016-02-18 23:21 ` Ralf Baechle [this message]
2016-02-18 23:21 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218232136.GB11796@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=changwoo@gatech.edu \
--cc=davem@davemloft.net \
--cc=insu@gatech.edu \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=taesoo@gatech.edu \
--cc=wuninsu@gmail.com \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.