From: Stephen Boyd <sboyd@codeaurora.org>
To: Joachim Eastwood <manabian@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] clk: add lpc18xx creg clk driver
Date: Thu, 18 Feb 2016 18:36:45 -0800 [thread overview]
Message-ID: <20160219023645.GP4847@codeaurora.org> (raw)
In-Reply-To: <CAGhQ9VxPt7FmE4JN_-rBJMNpLpGoKVKocVFPWc3siV29Pk0_mQ@mail.gmail.com>
On 02/17, Joachim Eastwood wrote:
>
> For creg-clk it would probably work.
>
> cgu would need to register most of clocks early since it needs to
> support whatever setup the bootloader throws at it. The only clocks
> that could be taken out is the base clocks (clk_onecell_data
> clk_base_data) except for one of them. But splitting this table would
> be a bad idea as hw clk numbers are used as indexes for easy look up.
>
> Come to think of it; isn't splitting the clock table between a early
> init and platform driver going become a problem?
> At least the lookup in the driver or framework would become more complex(?)
> And won't you confuse the lookup?
> If the early driver register one clock table with
> of_clk_add_provider() and then sometime later the platform driver
> register another clock table, both using the same of_node. How is that
> suppose to work?
I believe that should work, although I haven't tested it. The
code looks until it finds a provider that matches the device node
and gives us a valid clk pointer. If we don't get a valid pointer
we keep looking for another provider until we exhaust all
providers.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: add lpc18xx creg clk driver
Date: Thu, 18 Feb 2016 18:36:45 -0800 [thread overview]
Message-ID: <20160219023645.GP4847@codeaurora.org> (raw)
In-Reply-To: <CAGhQ9VxPt7FmE4JN_-rBJMNpLpGoKVKocVFPWc3siV29Pk0_mQ@mail.gmail.com>
On 02/17, Joachim Eastwood wrote:
>
> For creg-clk it would probably work.
>
> cgu would need to register most of clocks early since it needs to
> support whatever setup the bootloader throws at it. The only clocks
> that could be taken out is the base clocks (clk_onecell_data
> clk_base_data) except for one of them. But splitting this table would
> be a bad idea as hw clk numbers are used as indexes for easy look up.
>
> Come to think of it; isn't splitting the clock table between a early
> init and platform driver going become a problem?
> At least the lookup in the driver or framework would become more complex(?)
> And won't you confuse the lookup?
> If the early driver register one clock table with
> of_clk_add_provider() and then sometime later the platform driver
> register another clock table, both using the same of_node. How is that
> suppose to work?
I believe that should work, although I haven't tested it. The
code looks until it finds a provider that matches the device node
and gives us a valid clk pointer. If we don't get a valid pointer
we keep looking for another provider until we exhaust all
providers.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-02-19 2:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 21:48 [PATCH 0/2] CREG clk driver for NXP LPC18xx family Joachim Eastwood
2015-07-11 21:48 ` Joachim Eastwood
2015-07-11 21:48 ` Joachim Eastwood
2015-07-11 21:48 ` [PATCH 1/2] clk: add lpc18xx creg clk driver Joachim Eastwood
2015-07-11 21:48 ` Joachim Eastwood
2015-07-11 21:48 ` Joachim Eastwood
2015-08-11 20:41 ` Michael Turquette
2015-08-11 20:41 ` Michael Turquette
2015-08-11 20:41 ` Michael Turquette
2015-08-13 20:43 ` Joachim Eastwood
2015-08-13 20:43 ` Joachim Eastwood
2015-08-13 20:43 ` Joachim Eastwood
2015-08-18 0:26 ` Michael Turquette
2015-08-18 0:26 ` Michael Turquette
2015-08-18 0:26 ` Michael Turquette
2016-02-13 14:38 ` Joachim Eastwood
2016-02-13 14:38 ` Joachim Eastwood
2016-02-17 0:56 ` Michael Turquette
2016-02-17 0:56 ` Michael Turquette
2016-02-17 0:56 ` Michael Turquette
2016-02-17 18:24 ` Joachim Eastwood
2016-02-17 18:24 ` Joachim Eastwood
2016-02-17 20:28 ` Michael Turquette
2016-02-17 20:28 ` Michael Turquette
2016-02-17 20:28 ` Michael Turquette
2016-02-17 21:52 ` Joachim Eastwood
2016-02-17 21:52 ` Joachim Eastwood
2016-02-17 21:52 ` Joachim Eastwood
2016-02-19 2:36 ` Stephen Boyd [this message]
2016-02-19 2:36 ` Stephen Boyd
2015-07-11 21:48 ` [PATCH 2/2] doc: dt: add documentation for lpc1850-creg-clk driver Joachim Eastwood
2015-07-11 21:48 ` Joachim Eastwood
2015-07-11 21:48 ` Joachim Eastwood
2016-02-08 22:26 ` [PATCH 0/2] CREG clk driver for NXP LPC18xx family Stephen Boyd
2016-02-08 22:26 ` Stephen Boyd
2016-02-09 10:19 ` Joachim Eastwood
2016-02-09 10:19 ` Joachim Eastwood
2016-02-09 18:29 ` Stephen Boyd
2016-02-09 18:29 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219023645.GP4847@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.