All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Peter Rosin <peda@lysator.liu.se>
Cc: Dirk Eibach <eibach@gdsys.de>, Peter Rosin <peda@axentia.se>,
	Jean Delvare <jdelvare@suse.de>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
Date: Fri, 19 Feb 2016 03:16:40 +0000	[thread overview]
Message-ID: <20160219031640.GA8786@roeck-us.net> (raw)
In-Reply-To: <56C65027.5010403@lysator.liu.se>

On Fri, Feb 19, 2016 at 12:13:43AM +0100, Peter Rosin wrote:
> Hi!
> 
> Sorry for the noise, but...
> 
> On 2016-02-18 14:07, Peter Rosin wrote:
> > From: Peter Rosin <peda@axentia.se>
> > 
> > Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> > dividends when the divisor is unsigned.
> > 
> > Signed-off-by: Peter Rosin <peda@axentia.se>
> 
> ...I forgot to add this to the commit message
> Cc: stable@vger.kernel.org
> 
No problem, I prefer to do that myself anyway.

Patch applied.

Thanks,
Guenter

> I also didn't explicitly mention any example platform where this
> bug causes real problems; it was triggered on ARM (atmel sama5d).
> 
> Cheers,
> Peter
> 
> > ---
> >  drivers/hwmon/ads1015.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
> > index f155b8380481..2b3105c8aed3 100644
> > --- a/drivers/hwmon/ads1015.c
> > +++ b/drivers/hwmon/ads1015.c
> > @@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
> >  	struct ads1015_data *data = i2c_get_clientdata(client);
> >  	unsigned int pga = data->channel_data[channel].pga;
> >  	int fullscale = fullscale_table[pga];
> > -	const unsigned mask = data->id = ads1115 ? 0x7fff : 0x7ff0;
> > +	const int mask = data->id = ads1115 ? 0x7fff : 0x7ff0;
> >  
> >  	return DIV_ROUND_CLOSEST(reg * fullscale, mask);
> >  }
> > 

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Peter Rosin <peda@lysator.liu.se>
Cc: Dirk Eibach <eibach@gdsys.de>, Peter Rosin <peda@axentia.se>,
	Jean Delvare <jdelvare@suse.de>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (ads1015) Handle negative conversion values correctly
Date: Thu, 18 Feb 2016 19:16:40 -0800	[thread overview]
Message-ID: <20160219031640.GA8786@roeck-us.net> (raw)
In-Reply-To: <56C65027.5010403@lysator.liu.se>

On Fri, Feb 19, 2016 at 12:13:43AM +0100, Peter Rosin wrote:
> Hi!
> 
> Sorry for the noise, but...
> 
> On 2016-02-18 14:07, Peter Rosin wrote:
> > From: Peter Rosin <peda@axentia.se>
> > 
> > Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> > dividends when the divisor is unsigned.
> > 
> > Signed-off-by: Peter Rosin <peda@axentia.se>
> 
> ...I forgot to add this to the commit message
> Cc: stable@vger.kernel.org
> 
No problem, I prefer to do that myself anyway.

Patch applied.

Thanks,
Guenter

> I also didn't explicitly mention any example platform where this
> bug causes real problems; it was triggered on ARM (atmel sama5d).
> 
> Cheers,
> Peter
> 
> > ---
> >  drivers/hwmon/ads1015.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
> > index f155b8380481..2b3105c8aed3 100644
> > --- a/drivers/hwmon/ads1015.c
> > +++ b/drivers/hwmon/ads1015.c
> > @@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
> >  	struct ads1015_data *data = i2c_get_clientdata(client);
> >  	unsigned int pga = data->channel_data[channel].pga;
> >  	int fullscale = fullscale_table[pga];
> > -	const unsigned mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
> > +	const int mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
> >  
> >  	return DIV_ROUND_CLOSEST(reg * fullscale, mask);
> >  }
> > 

  reply	other threads:[~2016-02-19  3:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 13:07 [lm-sensors] [PATCH] hwmon: (ads1015) Handle negative conversion values correctly Peter Rosin
2016-02-18 13:07 ` Peter Rosin
2016-02-18 23:13 ` [lm-sensors] " Peter Rosin
2016-02-18 23:13   ` Peter Rosin
2016-02-19  3:16   ` Guenter Roeck [this message]
2016-02-19  3:16     ` Guenter Roeck
2016-02-19 22:26 ` [lm-sensors] " Greg KH
2016-02-19 22:26   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160219031640.GA8786@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=eibach@gdsys.de \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=peda@axentia.se \
    --cc=peda@lysator.liu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.