* [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
@ 2016-02-15 3:37 ` Shalin Mehta
0 siblings, 0 replies; 12+ messages in thread
From: Shalin Mehta @ 2016-02-15 3:37 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger, kernel-janitors
Cc: lustre-devel, devel, linux-kernel, Shalin Mehta
The parentehsis are fixed in the macro for the ldlm lock to set and
clear the flags.
Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
---
drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
index 0d3ed87..4f9e9ad 100644
--- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
+++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
@@ -365,10 +365,10 @@
#define LDLM_TEST_FLAG(_l, _b) (((_l)->l_flags & (_b)) != 0)
/** set a ldlm_lock flag bit */
-#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
+#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
/** clear a ldlm_lock flag bit */
-#define LDLM_CLEAR_FLAG(_l, _b) (((_l)->l_flags &= ~(_b))
+#define LDLM_CLEAR_FLAG(_l, _b) ((_l)->l_flags &= ~(_b))
/** Mask of flags inherited from parent lock when doing intents. */
#define LDLM_INHERIT_FLAGS LDLM_FL_INHERIT_MASK
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] staging: lustre: Fixed the parenthesis
@ 2016-02-15 3:37 ` Shalin Mehta
0 siblings, 0 replies; 12+ messages in thread
From: Shalin Mehta @ 2016-02-15 3:37 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger, kernel-janitors
Cc: lustre-devel, devel, linux-kernel, Shalin Mehta
The parentehsis are fixed in the macro for the ldlm lock to set and
clear the flags.
Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
---
drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
index 0d3ed87..4f9e9ad 100644
--- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
+++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
@@ -365,10 +365,10 @@
#define LDLM_TEST_FLAG(_l, _b) (((_l)->l_flags & (_b)) != 0)
/** set a ldlm_lock flag bit */
-#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
+#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
/** clear a ldlm_lock flag bit */
-#define LDLM_CLEAR_FLAG(_l, _b) (((_l)->l_flags &= ~(_b))
+#define LDLM_CLEAR_FLAG(_l, _b) ((_l)->l_flags &= ~(_b))
/** Mask of flags inherited from parent lock when doing intents. */
#define LDLM_INHERIT_FLAGS LDLM_FL_INHERIT_MASK
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
2016-02-15 3:37 ` Shalin Mehta
@ 2016-02-16 2:28 ` Greg KH
-1 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2016-02-16 2:28 UTC (permalink / raw)
To: Shalin Mehta
Cc: oleg.drokin, andreas.dilger, kernel-janitors, devel, linux-kernel,
lustre-devel
On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.
"fixed" in what way? Did you test-build this patch? Also, you
mispelled a word here...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] staging: lustre: Fixed the parenthesis
@ 2016-02-16 2:28 ` Greg KH
0 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2016-02-16 2:28 UTC (permalink / raw)
To: Shalin Mehta
Cc: oleg.drokin, andreas.dilger, kernel-janitors, devel, linux-kernel,
lustre-devel
On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.
"fixed" in what way? Did you test-build this patch? Also, you
mispelled a word here...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
2016-02-16 2:28 ` Greg KH
@ 2016-02-16 2:41 ` Drokin, Oleg
-1 siblings, 0 replies; 12+ messages in thread
From: Drokin, Oleg @ 2016-02-16 2:41 UTC (permalink / raw)
To: Greg KH
Cc: Shalin Mehta, Dilger, Andreas,
<kernel-janitors@lists.osdl.org>,
<devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>,
<lustre-devel@lists.lustre.org>
On Feb 15, 2016, at 9:28 PM, Greg KH wrote:
> On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
>
> "fixed" in what way? Did you test-build this patch? Also, you
> mispelled a word here?
The fix in the patch is to make sure number of parenthesis matches, as is
it appears there's one more opening one than the closing.
The original patch that add this had an error somehow, but back then none
of the users were later introduced, so the bug is "hidden" until
first user actually appears.
Compiles work with or without this fix as the result (I also just checked
just to be sure).
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] staging: lustre: Fixed the parenthesis
@ 2016-02-16 2:41 ` Drokin, Oleg
0 siblings, 0 replies; 12+ messages in thread
From: Drokin, Oleg @ 2016-02-16 2:41 UTC (permalink / raw)
To: Greg KH
Cc: Shalin Mehta, Dilger, Andreas,
<kernel-janitors@lists.osdl.org>,
<devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>,
<lustre-devel@lists.lustre.org>
On Feb 15, 2016, at 9:28 PM, Greg KH wrote:
> On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
>
> "fixed" in what way? Did you test-build this patch? Also, you
> mispelled a word here…
The fix in the patch is to make sure number of parenthesis matches, as is
it appears there's one more opening one than the closing.
The original patch that add this had an error somehow, but back then none
of the users were later introduced, so the bug is "hidden" until
first user actually appears.
Compiles work with or without this fix as the result (I also just checked
just to be sure).
^ permalink raw reply [flat|nested] 12+ messages in thread
* [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
2016-02-15 3:37 ` Shalin Mehta
@ 2016-02-16 2:51 ` Drokin, Oleg
-1 siblings, 0 replies; 12+ messages in thread
From: Drokin, Oleg @ 2016-02-16 2:51 UTC (permalink / raw)
To: Shalin Mehta
Cc: Dilger, Andreas, <kernel-janitors@lists.osdl.org>,
<devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>,
<lustre-devel@lists.lustre.org>
On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:
> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.
>
> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
> ---
> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> index 0d3ed87..4f9e9ad 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> @@ -365,10 +365,10 @@
> #define LDLM_TEST_FLAG(_l, _b) (((_l)->l_flags & (_b)) != 0)
>
> /** set a ldlm_lock flag bit */
> -#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
> +#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
>
> /** clear a ldlm_lock flag bit */
> -#define LDLM_CLEAR_FLAG(_l, _b) (((_l)->l_flags &= ~(_b))
> +#define LDLM_CLEAR_FLAG(_l, _b) ((_l)->l_flags &= ~(_b))
>
> /** Mask of flags inherited from parent lock when doing intents. */
> #define LDLM_INHERIT_FLAGS LDLM_FL_INHERIT_MASK
Acked-by: Oleg Drokin <oleg.drokin@intel.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
@ 2016-02-16 2:51 ` Drokin, Oleg
0 siblings, 0 replies; 12+ messages in thread
From: Drokin, Oleg @ 2016-02-16 2:51 UTC (permalink / raw)
To: Shalin Mehta
Cc: Dilger, Andreas, <kernel-janitors@lists.osdl.org>,
<devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>,
<lustre-devel@lists.lustre.org>
On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:
> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.
>
> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
> ---
> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> index 0d3ed87..4f9e9ad 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> @@ -365,10 +365,10 @@
> #define LDLM_TEST_FLAG(_l, _b) (((_l)->l_flags & (_b)) != 0)
>
> /** set a ldlm_lock flag bit */
> -#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
> +#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
>
> /** clear a ldlm_lock flag bit */
> -#define LDLM_CLEAR_FLAG(_l, _b) (((_l)->l_flags &= ~(_b))
> +#define LDLM_CLEAR_FLAG(_l, _b) ((_l)->l_flags &= ~(_b))
>
> /** Mask of flags inherited from parent lock when doing intents. */
> #define LDLM_INHERIT_FLAGS LDLM_FL_INHERIT_MASK
Acked-by: Oleg Drokin <oleg.drokin@intel.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
2016-02-16 2:51 ` Drokin, Oleg
@ 2016-02-17 6:39 ` shalin mehta
-1 siblings, 0 replies; 12+ messages in thread
From: shalin mehta @ 2016-02-17 6:39 UTC (permalink / raw)
To: Drokin, Oleg
Cc: Dilger, Andreas, <kernel-janitors@lists.osdl.org>,
<devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>,
<lustre-devel@lists.lustre.org>
Hello,
Should I send this patch again due the spelling mistake in the patch
description?
Thanks,
Shalin
On Mon, Feb 15, 2016 at 6:51 PM, Drokin, Oleg <oleg.drokin@intel.com> wrote:
>
> On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:
>
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
>>
>> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> index 0d3ed87..4f9e9ad 100644
>> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> @@ -365,10 +365,10 @@
>> #define LDLM_TEST_FLAG(_l, _b) (((_l)->l_flags & (_b)) != 0)
>>
>> /** set a ldlm_lock flag bit */
>> -#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
>> +#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
>>
>> /** clear a ldlm_lock flag bit */
>> -#define LDLM_CLEAR_FLAG(_l, _b) (((_l)->l_flags &= ~(_b))
>> +#define LDLM_CLEAR_FLAG(_l, _b) ((_l)->l_flags &= ~(_b))
>>
>> /** Mask of flags inherited from parent lock when doing intents. */
>> #define LDLM_INHERIT_FLAGS LDLM_FL_INHERIT_MASK
>
> Acked-by: Oleg Drokin <oleg.drokin@intel.com>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
@ 2016-02-17 6:39 ` shalin mehta
0 siblings, 0 replies; 12+ messages in thread
From: shalin mehta @ 2016-02-17 6:39 UTC (permalink / raw)
To: Drokin, Oleg
Cc: Dilger, Andreas, <kernel-janitors@lists.osdl.org>,
<devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>,
<lustre-devel@lists.lustre.org>
Hello,
Should I send this patch again due the spelling mistake in the patch
description?
Thanks,
Shalin
On Mon, Feb 15, 2016 at 6:51 PM, Drokin, Oleg <oleg.drokin@intel.com> wrote:
>
> On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:
>
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
>>
>> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> index 0d3ed87..4f9e9ad 100644
>> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> @@ -365,10 +365,10 @@
>> #define LDLM_TEST_FLAG(_l, _b) (((_l)->l_flags & (_b)) != 0)
>>
>> /** set a ldlm_lock flag bit */
>> -#define LDLM_SET_FLAG(_l, _b) (((_l)->l_flags |= (_b))
>> +#define LDLM_SET_FLAG(_l, _b) ((_l)->l_flags |= (_b))
>>
>> /** clear a ldlm_lock flag bit */
>> -#define LDLM_CLEAR_FLAG(_l, _b) (((_l)->l_flags &= ~(_b))
>> +#define LDLM_CLEAR_FLAG(_l, _b) ((_l)->l_flags &= ~(_b))
>>
>> /** Mask of flags inherited from parent lock when doing intents. */
>> #define LDLM_INHERIT_FLAGS LDLM_FL_INHERIT_MASK
>
> Acked-by: Oleg Drokin <oleg.drokin@intel.com>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
2016-02-17 6:39 ` shalin mehta
@ 2016-02-19 10:22 ` Dan Carpenter
-1 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2016-02-19 10:22 UTC (permalink / raw)
To: shalin mehta
Cc: Drokin, Oleg, <devel@driverdev.osuosl.org>,
<kernel-janitors@lists.osdl.org>, Dilger, Andreas,
<linux-kernel@vger.kernel.org>,
<lustre-devel@lists.lustre.org>
On Tue, Feb 16, 2016 at 10:39:05PM -0800, shalin mehta wrote:
> Hello,
>
> Should I send this patch again due the spelling mistake in the patch
> description?
>
Yes. And put what Oleg Drokin said about it worked because there were
no users in the changelog.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
@ 2016-02-19 10:22 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2016-02-19 10:22 UTC (permalink / raw)
To: shalin mehta
Cc: Drokin, Oleg, <devel@driverdev.osuosl.org>,
<kernel-janitors@lists.osdl.org>, Dilger, Andreas,
<linux-kernel@vger.kernel.org>,
<lustre-devel@lists.lustre.org>
On Tue, Feb 16, 2016 at 10:39:05PM -0800, shalin mehta wrote:
> Hello,
>
> Should I send this patch again due the spelling mistake in the patch
> description?
>
Yes. And put what Oleg Drokin said about it worked because there were
no users in the changelog.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-02-19 10:22 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-15 3:37 [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis Shalin Mehta
2016-02-15 3:37 ` Shalin Mehta
2016-02-16 2:28 ` [lustre-devel] " Greg KH
2016-02-16 2:28 ` Greg KH
2016-02-16 2:41 ` [lustre-devel] " Drokin, Oleg
2016-02-16 2:41 ` Drokin, Oleg
2016-02-16 2:51 ` [lustre-devel] " Drokin, Oleg
2016-02-16 2:51 ` Drokin, Oleg
2016-02-17 6:39 ` shalin mehta
2016-02-17 6:39 ` shalin mehta
2016-02-19 10:22 ` Dan Carpenter
2016-02-19 10:22 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.