From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org,
luto@amacapital.net, rusty@rustcorp.com.au,
david.vrabel@citrix.com, konrad.wilk@oracle.com, mcb30@ipxe.org,
jgross@suse.com, andriy.shevchenko@linux.intel.com,
xen-devel@lists.xensource.com
Subject: Re: [RFC v2 1/6] x86/boot: add BIT() to boot/bitops.h
Date: Fri, 19 Feb 2016 22:03:29 +0100 [thread overview]
Message-ID: <20160219210329.GT25240@wotan.suse.de> (raw)
In-Reply-To: <56C73162.1040207@oracle.com>
On Fri, Feb 19, 2016 at 10:14:42AM -0500, Boris Ostrovsky wrote:
>
>
> On 02/19/2016 09:15 AM, Luis R. Rodriguez wrote:
> >diff --git a/arch/x86/boot/bitops.h b/arch/x86/boot/bitops.h
> >index 878e4b9940d9..232cff0ff4e3 100644
> >--- a/arch/x86/boot/bitops.h
> >+++ b/arch/x86/boot/bitops.h
> >@@ -40,4 +40,6 @@ static inline void set_bit(int nr, void *addr)
> > asm("btsl %1,%0" : "+m" (*(u32 *)addr) : "Ir" (nr));
> > }
> >+#define BIT(x) (1 << x)
>
> Parenthesize x.
I'll just use (1UL << (nr)) then as well to match what
include/linux/bitmap.h uses.
Luis
next prev parent reply other threads:[~2016-02-19 21:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 14:15 [RFC v2 0/6] x86/init: use linker table Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 1/6] x86/boot: add BIT() to boot/bitops.h Luis R. Rodriguez
2016-02-19 15:14 ` Boris Ostrovsky
2016-02-19 21:03 ` Luis R. Rodriguez [this message]
2016-02-19 14:15 ` [RFC v2 2/6] x86/init: use linker tables to simplify x86 init and annotate dependencies Luis R. Rodriguez
2016-02-19 16:40 ` Andy Lutomirski
2016-02-20 0:42 ` Luis R. Rodriguez
2016-02-20 7:30 ` Andy Lutomirski
2016-02-27 0:19 ` Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 3/6] x86/init: move ebda reservations into linker table Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 4/6] x86/init: use linker table for i386 early setup Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 5/6] x86/init: user linker table for ce4100 " Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 6/6] x86/init: use linker table for mid " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219210329.GT25240@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcb30@ipxe.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.