* [PATCH 1/4] staging: rtl8712: Place constants on the right side
@ 2016-02-19 13:47 Bhaktipriya Shridhar
2016-02-20 23:18 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Bhaktipriya Shridhar @ 2016-02-19 13:47 UTC (permalink / raw)
To: outreachy-kernel
Move constants to the right of binary operators.
This issue was identified using the Coccinelle script
misc/compare_const_fl.cocci
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/staging/rtl8712/wifi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h
index 7a352c4..ee41971 100644
--- a/drivers/staging/rtl8712/wifi.h
+++ b/drivers/staging/rtl8712/wifi.h
@@ -260,12 +260,12 @@ enum WIFI_REG_DOMAIN {
*(unsigned short *)((addr_t)(pbuf) + 22) = \
((*(unsigned short *)((addr_t)(pbuf) + 22)) & \
le16_to_cpu((unsigned short)0x000f)) | \
- le16_to_cpu((unsigned short)(0xfff0 & (num << 4))); \
+ le16_to_cpu((unsigned short)((num << 4) & 0xfff0)); \
})
#define SetDuration(pbuf, dur) ({ \
*(unsigned short *)((addr_t)(pbuf) + 2) |= \
- cpu_to_le16(0xffff & (dur)); \
+ cpu_to_le16((dur) & 0xffff); \
})
#define SetPriority(pbuf, tid) ({ \
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/4] staging: rtl8712: Place constants on the right side
2016-02-19 13:47 [PATCH 1/4] staging: rtl8712: Place constants on the right side Bhaktipriya Shridhar
@ 2016-02-20 23:18 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-02-20 23:18 UTC (permalink / raw)
To: Bhaktipriya Shridhar; +Cc: outreachy-kernel
On Fri, Feb 19, 2016 at 07:17:15PM +0530, Bhaktipriya Shridhar wrote:
> Move constants to the right of binary operators.
> This issue was identified using the Coccinelle script
> misc/compare_const_fl.cocci
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/staging/rtl8712/wifi.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
All 4 of these patches have the same subject: so I can't take them :(
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-20 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19 13:47 [PATCH 1/4] staging: rtl8712: Place constants on the right side Bhaktipriya Shridhar
2016-02-20 23:18 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.