From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: mark.rutland@arm.com, peter.maydell@linaro.org,
matt@codeblueprint.co.uk, stefanha@gmail.com,
qemu-devel@nongnu.org, eric@anholt.net, kraxel@redhat.com,
linux-api@vger.kernel.org, agross@codeaurora.org,
pawel.moll@arm.com, zajec5@gmail.com,
rmk+kernel@arm.linux.org.uk, lersek@redhat.com,
devicetree@vger.kernel.org, ehabkost@redhat.com, arnd@arndb.de,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
leif.lindholm@linaro.org, robh+dt@kernel.org,
pbonzini@redhat.com, rth@twiddle.net, ard.biesheuvel@linaro.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
luto@amacapital.net, hanjun.guo@linaro.org, sudeep.holla@arm.com,
imammedo@redhat.com, revol@free.fr
Subject: Re: [PATCH v8 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device
Date: Sun, 21 Feb 2016 15:14:00 +0200 [thread overview]
Message-ID: <20160221151050-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20160221130614.GA4511@GLSMBP.INI.CMU.EDU>
On Sun, Feb 21, 2016 at 08:06:17AM -0500, Gabriel L. Somlo wrote:
> > So for all arches which support ACPI, I think this driver
> > should just rely on ACPI.
>
> There was a discussion about that a few versions ago, and IIRC the
> conclusion was not to expect the firmware to contend for fw_cfg access
> after the guest kernel boots:
>
> https://lkml.org/lkml/2015/10/5/283
Interesting. Igor wanted to do this again recently ...
I'll think it over and get back to you/list on this.
> (I even had a prototype version doing what you suggested, but per the above
> reference decided to drop it -- which IMHO is for the better, since otherwise
> I'd have had to ifdef between ACPI and non-ACPI versions of the driver --
> see https://lkml.org/lkml/2015/11/4/534 )
I'm not sure I get it - won't you only ifdef the accessor function?
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
arnd@arndb.de, lersek@redhat.com, ralf@linux-mips.org,
rmk+kernel@arm.linux.org.uk, eric@anholt.net,
hanjun.guo@linaro.org, zajec5@gmail.com, sudeep.holla@arm.com,
agross@codeaurora.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
qemu-devel@nongnu.org, imammedo@redhat.com,
peter.maydell@linaro.org, leif.lindholm@linaro.org,
ard.biesheuvel@linaro.org, pbonzini@redhat.com,
kraxel@redhat.com, ehabkost@redhat.com, luto@amacapital.net,
stefanha@gmail.com, revol@free.fr, matt@codeblueprint.co.uk,
rth@twiddle.net
Subject: Re: [PATCH v8 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device
Date: Sun, 21 Feb 2016 15:14:00 +0200 [thread overview]
Message-ID: <20160221151050-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20160221130614.GA4511@GLSMBP.INI.CMU.EDU>
On Sun, Feb 21, 2016 at 08:06:17AM -0500, Gabriel L. Somlo wrote:
> > So for all arches which support ACPI, I think this driver
> > should just rely on ACPI.
>
> There was a discussion about that a few versions ago, and IIRC the
> conclusion was not to expect the firmware to contend for fw_cfg access
> after the guest kernel boots:
>
> https://lkml.org/lkml/2015/10/5/283
Interesting. Igor wanted to do this again recently ...
I'll think it over and get back to you/list on this.
> (I even had a prototype version doing what you suggested, but per the above
> reference decided to drop it -- which IMHO is for the better, since otherwise
> I'd have had to ifdef between ACPI and non-ACPI versions of the driver --
> see https://lkml.org/lkml/2015/11/4/534 )
I'm not sure I get it - won't you only ifdef the accessor function?
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: mark.rutland@arm.com, peter.maydell@linaro.org,
matt@codeblueprint.co.uk, stefanha@gmail.com,
qemu-devel@nongnu.org, eric@anholt.net, kraxel@redhat.com,
linux-api@vger.kernel.org, agross@codeaurora.org,
pawel.moll@arm.com, zajec5@gmail.com,
rmk+kernel@arm.linux.org.uk, lersek@redhat.com,
devicetree@vger.kernel.org, ehabkost@redhat.com, arnd@arndb.de,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
leif.lindholm@linaro.org, robh+dt@kernel.org,
pbonzini@redhat.com, rth@twiddle.net, ard.biesheuvel@linaro.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
luto@amacapital.net, hanjun.guo@linaro.org, sudeep.holla@arm.com,
imammedo@redhat.com, revol@free.fr
Subject: Re: [Qemu-devel] [PATCH v8 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device
Date: Sun, 21 Feb 2016 15:14:00 +0200 [thread overview]
Message-ID: <20160221151050-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20160221130614.GA4511@GLSMBP.INI.CMU.EDU>
On Sun, Feb 21, 2016 at 08:06:17AM -0500, Gabriel L. Somlo wrote:
> > So for all arches which support ACPI, I think this driver
> > should just rely on ACPI.
>
> There was a discussion about that a few versions ago, and IIRC the
> conclusion was not to expect the firmware to contend for fw_cfg access
> after the guest kernel boots:
>
> https://lkml.org/lkml/2015/10/5/283
Interesting. Igor wanted to do this again recently ...
I'll think it over and get back to you/list on this.
> (I even had a prototype version doing what you suggested, but per the above
> reference decided to drop it -- which IMHO is for the better, since otherwise
> I'd have had to ifdef between ACPI and non-ACPI versions of the driver --
> see https://lkml.org/lkml/2015/11/4/534 )
I'm not sure I get it - won't you only ifdef the accessor function?
--
MST
next prev parent reply other threads:[~2016-02-21 13:14 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 14:23 [PATCH v8 0/4] SysFS driver for QEMU fw_cfg device Gabriel L. Somlo
2016-01-28 14:23 ` [Qemu-devel] " Gabriel L. Somlo
2016-01-28 14:23 ` [PATCH v8 1/4] firmware: introduce sysfs driver for QEMU's " Gabriel L. Somlo
2016-01-28 14:23 ` [Qemu-devel] " Gabriel L. Somlo
2016-02-21 8:30 ` Michael S. Tsirkin
2016-02-21 8:30 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-21 8:30 ` Michael S. Tsirkin
2016-02-21 13:06 ` Gabriel L. Somlo
2016-02-21 13:06 ` [Qemu-devel] " Gabriel L. Somlo
2016-02-21 13:06 ` Gabriel L. Somlo
2016-02-21 13:10 ` Michael S. Tsirkin
2016-02-21 13:10 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-21 13:10 ` Michael S. Tsirkin
[not found] ` <20160221150904-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-02-21 17:20 ` Gabriel L. Somlo
2016-02-21 17:20 ` [Qemu-devel] " Gabriel L. Somlo
2016-02-21 17:20 ` Gabriel L. Somlo
2016-02-21 13:14 ` Michael S. Tsirkin [this message]
2016-02-21 13:14 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-21 13:14 ` Michael S. Tsirkin
[not found] ` <20160221130614.GA4511-VPZ87SnTp2qKUezXOiBB2eW1CriLhL8O@public.gmane.org>
2016-02-22 20:14 ` Michael S. Tsirkin
2016-02-22 20:14 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-22 20:14 ` Michael S. Tsirkin
[not found] ` <20160222220756-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-02-22 20:26 ` Gabriel L. Somlo
2016-02-22 20:26 ` [Qemu-devel] " Gabriel L. Somlo
2016-02-22 20:26 ` Gabriel L. Somlo
[not found] ` <20160222202623.GI16357-h65ZQ0r4j6KKUezXOiBB2eW1CriLhL8O@public.gmane.org>
2016-02-23 5:07 ` Michael S. Tsirkin
2016-02-23 5:07 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-23 5:07 ` Michael S. Tsirkin
2016-02-23 13:47 ` Gabriel L. Somlo
2016-02-23 13:47 ` [Qemu-devel] " Gabriel L. Somlo
2016-02-23 13:47 ` Gabriel L. Somlo
2016-02-23 14:14 ` Michael S. Tsirkin
2016-02-23 14:14 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-23 14:14 ` Michael S. Tsirkin
[not found] ` <20160223160555-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-02-24 0:03 ` Gabriel L. Somlo
2016-02-24 0:03 ` [Qemu-devel] " Gabriel L. Somlo
2016-02-24 0:03 ` Gabriel L. Somlo
2016-01-28 14:23 ` [PATCH v8 2/4] kobject: export kset_find_obj() for module use Gabriel L. Somlo
2016-01-28 14:23 ` [Qemu-devel] " Gabriel L. Somlo
[not found] ` <1453990994-17801-3-git-send-email-somlo-D+Gtc/HYRWM@public.gmane.org>
2016-02-07 7:24 ` Greg KH
2016-02-07 7:24 ` [Qemu-devel] " Greg KH
2016-02-07 7:24 ` Greg KH
[not found] ` <20160207072423.GC16215-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-02-07 14:27 ` Gabriel L. Somlo
2016-02-07 14:27 ` [Qemu-devel] " Gabriel L. Somlo
2016-02-07 14:27 ` Gabriel L. Somlo
2016-01-28 14:23 ` [PATCH v8 3/4] firmware: create directory hierarchy for sysfs fw_cfg entries Gabriel L. Somlo
2016-01-28 14:23 ` [Qemu-devel] " Gabriel L. Somlo
2016-01-28 14:23 ` Gabriel L. Somlo
[not found] ` <1453990994-17801-1-git-send-email-somlo-D+Gtc/HYRWM@public.gmane.org>
2016-01-28 14:23 ` [PATCH v8 4/4] devicetree: update documentation for fw_cfg ARM bindings Gabriel L. Somlo
2016-01-28 14:23 ` [Qemu-devel] " Gabriel L. Somlo
2016-01-28 14:23 ` Gabriel L. Somlo
2016-02-03 22:47 ` [PATCH v8 0/4] SysFS driver for QEMU fw_cfg device Matt Fleming
2016-02-03 22:47 ` [Qemu-devel] " Matt Fleming
2016-02-03 22:47 ` Matt Fleming
2016-02-10 1:38 ` Greg KH
2016-02-10 1:38 ` [Qemu-devel] " Greg KH
2016-02-10 1:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221151050-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=agross@codeaurora.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=ehabkost@redhat.com \
--cc=eric@anholt.net \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hanjun.guo@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=leif.lindholm@linaro.org \
--cc=lersek@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=pawel.moll@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=revol@free.fr \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=rth@twiddle.net \
--cc=somlo@cmu.edu \
--cc=stefanha@gmail.com \
--cc=sudeep.holla@arm.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.