* [PATCH] Staging: sm750fb: Remove trailing whitespace.
@ 2016-02-22 10:10 Sandhya Bankar
2016-02-23 15:55 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Sandhya Bankar @ 2016-02-22 10:10 UTC (permalink / raw)
To: outreachy-kernel
Remove trailing whitespace.This error is detected by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/sm750fb/ddk750_power.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm750fb/ddk750_power.c
index 33e092e..f34b15d 100644
--- a/drivers/staging/sm750fb/ddk750_power.c
+++ b/drivers/staging/sm750fb/ddk750_power.c
@@ -106,9 +106,9 @@ void enable2DEngine(unsigned int enable)
u32 gate;
gate = PEEK32(CURRENT_GATE);
- if (enable)
+ if (enable)
gate |= (CURRENT_GATE_DE | CURRENT_GATE_CSC);
- else
+ else
gate &= ~(CURRENT_GATE_DE | CURRENT_GATE_CSC);
setCurrentGate(gate);
--
1.8.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: Remove trailing whitespace.
2016-02-22 10:10 [PATCH] Staging: sm750fb: Remove trailing whitespace Sandhya Bankar
@ 2016-02-23 15:55 ` Julia Lawall
2016-02-23 17:47 ` sandhya bankar
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2016-02-23 15:55 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
On Mon, 22 Feb 2016, Sandhya Bankar wrote:
> Remove trailing whitespace.This error is detected by checkpatch.pl script.
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_power.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm750fb/ddk750_power.c
> index 33e092e..f34b15d 100644
> --- a/drivers/staging/sm750fb/ddk750_power.c
> +++ b/drivers/staging/sm750fb/ddk750_power.c
> @@ -106,9 +106,9 @@ void enable2DEngine(unsigned int enable)
> u32 gate;
>
> gate = PEEK32(CURRENT_GATE);
> - if (enable)
> + if (enable)
> gate |= (CURRENT_GATE_DE | CURRENT_GATE_CSC);
> - else
> + else
There is also an unneeded space in front of the else. Maybe you could fix
up all of the whitespace problems in this if at once.
julia
> gate &= ~(CURRENT_GATE_DE | CURRENT_GATE_CSC);
>
> setCurrentGate(gate);
> --
> 1.8.3.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160222100856.GA5026%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: Remove trailing whitespace.
2016-02-23 15:55 ` [Outreachy kernel] " Julia Lawall
@ 2016-02-23 17:47 ` sandhya bankar
0 siblings, 0 replies; 3+ messages in thread
From: sandhya bankar @ 2016-02-23 17:47 UTC (permalink / raw)
To: Julia Lawall, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]
hello,
thanks for suggestions..i will resend patch v2..
Thanks
sandhya bankar
On Tue, Feb 23, 2016 at 9:25 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Mon, 22 Feb 2016, Sandhya Bankar wrote:
>
> > Remove trailing whitespace.This error is detected by checkpatch.pl
> script.
> >
> > Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_power.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_power.c
> b/drivers/staging/sm750fb/ddk750_power.c
> > index 33e092e..f34b15d 100644
> > --- a/drivers/staging/sm750fb/ddk750_power.c
> > +++ b/drivers/staging/sm750fb/ddk750_power.c
> > @@ -106,9 +106,9 @@ void enable2DEngine(unsigned int enable)
> > u32 gate;
> >
> > gate = PEEK32(CURRENT_GATE);
> > - if (enable)
> > + if (enable)
> > gate |= (CURRENT_GATE_DE | CURRENT_GATE_CSC);
> > - else
> > + else
>
> There is also an unneeded space in front of the else. Maybe you could fix
> up all of the whitespace problems in this if at once.
>
> julia
>
> > gate &= ~(CURRENT_GATE_DE | CURRENT_GATE_CSC);
> >
> > setCurrentGate(gate);
> > --
> > 1.8.3.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20160222100856.GA5026%40sandhya
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>
[-- Attachment #2: Type: text/html, Size: 2980 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 17:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 10:10 [PATCH] Staging: sm750fb: Remove trailing whitespace Sandhya Bankar
2016-02-23 15:55 ` [Outreachy kernel] " Julia Lawall
2016-02-23 17:47 ` sandhya bankar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.