* [PATCH] Staging: slicoss: Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc(). @ 2016-02-22 10:36 Sandhya Bankar 2016-02-23 19:39 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 6+ messages in thread From: Sandhya Bankar @ 2016-02-22 10:36 UTC (permalink / raw) To: outreachy-kernel Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc(). Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> --- drivers/staging/slicoss/slicoss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index a91c60a..ea6b7b5 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -880,7 +880,7 @@ static int slic_upr_queue_request(struct adapter *adapter, struct slic_upr *upr; struct slic_upr *uprqueue; - upr = kmalloc(sizeof(struct slic_upr), GFP_ATOMIC); + upr = kmalloc(sizeof(*upr), GFP_ATOMIC); if (!upr) return -ENOMEM; @@ -1806,7 +1806,7 @@ static int slic_mcast_add_list(struct adapter *adapter, char *address) } /* Doesn't already exist. Allocate a structure to hold it */ - mcaddr = kmalloc(sizeof(struct mcast_address), GFP_ATOMIC); + mcaddr = kmalloc(sizeof(*mcaddr), GFP_ATOMIC); if (mcaddr == NULL) return 1; @@ -3049,7 +3049,7 @@ static u32 slic_card_locate(struct adapter *adapter) } if (!physcard) { /* no structure allocated for this physical card yet */ - physcard = kzalloc(sizeof(struct physcard), GFP_ATOMIC); + physcard = kzalloc(sizeof(*physcard), GFP_ATOMIC); if (!physcard) { if (card_hostid == SLIC_HOSTID_DEFAULT) kfree(card); -- 1.8.3.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: slicoss: Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc(). 2016-02-22 10:36 [PATCH] Staging: slicoss: Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc() Sandhya Bankar @ 2016-02-23 19:39 ` Julia Lawall 2016-02-23 19:46 ` sandhya bankar 0 siblings, 1 reply; 6+ messages in thread From: Julia Lawall @ 2016-02-23 19:39 UTC (permalink / raw) To: Sandhya Bankar; +Cc: outreachy-kernel On Mon, 22 Feb 2016, Sandhya Bankar wrote: > Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc(). > > Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> > --- > drivers/staging/slicoss/slicoss.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c > index a91c60a..ea6b7b5 100644 > --- a/drivers/staging/slicoss/slicoss.c > +++ b/drivers/staging/slicoss/slicoss.c > @@ -880,7 +880,7 @@ static int slic_upr_queue_request(struct adapter *adapter, > struct slic_upr *upr; > struct slic_upr *uprqueue; > > - upr = kmalloc(sizeof(struct slic_upr), GFP_ATOMIC); > + upr = kmalloc(sizeof(*upr), GFP_ATOMIC); > if (!upr) > return -ENOMEM; > > @@ -1806,7 +1806,7 @@ static int slic_mcast_add_list(struct adapter *adapter, char *address) > } > > /* Doesn't already exist. Allocate a structure to hold it */ > - mcaddr = kmalloc(sizeof(struct mcast_address), GFP_ATOMIC); > + mcaddr = kmalloc(sizeof(*mcaddr), GFP_ATOMIC); > if (mcaddr == NULL) You could make a series and also eliminate this == NULL test. julia > return 1; > > @@ -3049,7 +3049,7 @@ static u32 slic_card_locate(struct adapter *adapter) > } > if (!physcard) { > /* no structure allocated for this physical card yet */ > - physcard = kzalloc(sizeof(struct physcard), GFP_ATOMIC); > + physcard = kzalloc(sizeof(*physcard), GFP_ATOMIC); > if (!physcard) { > if (card_hostid == SLIC_HOSTID_DEFAULT) > kfree(card); > -- > 1.8.3.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160222103651.GA5176%40sandhya. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: slicoss: Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc(). 2016-02-23 19:39 ` [Outreachy kernel] " Julia Lawall @ 2016-02-23 19:46 ` sandhya bankar 2016-02-23 19:56 ` Julia Lawall 0 siblings, 1 reply; 6+ messages in thread From: sandhya bankar @ 2016-02-23 19:46 UTC (permalink / raw) To: Julia Lawall, outreachy-kernel [-- Attachment #1: Type: text/plain, Size: 2519 bytes --] Hello, I understand the ==NULL changes,but i have not understood the "make a series" concept. On Wed, Feb 24, 2016 at 1:09 AM, Julia Lawall <julia.lawall@lip6.fr> wrote: > > > On Mon, 22 Feb 2016, Sandhya Bankar wrote: > > > Use sizeof structure *pointer over sizeof structure in > kmalloc()/kzalloc(). > > > > Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> > > --- > > drivers/staging/slicoss/slicoss.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/staging/slicoss/slicoss.c > > index a91c60a..ea6b7b5 100644 > > --- a/drivers/staging/slicoss/slicoss.c > > +++ b/drivers/staging/slicoss/slicoss.c > > @@ -880,7 +880,7 @@ static int slic_upr_queue_request(struct adapter > *adapter, > > struct slic_upr *upr; > > struct slic_upr *uprqueue; > > > > - upr = kmalloc(sizeof(struct slic_upr), GFP_ATOMIC); > > + upr = kmalloc(sizeof(*upr), GFP_ATOMIC); > > if (!upr) > > return -ENOMEM; > > > > @@ -1806,7 +1806,7 @@ static int slic_mcast_add_list(struct adapter > *adapter, char *address) > > } > > > > /* Doesn't already exist. Allocate a structure to hold it */ > > - mcaddr = kmalloc(sizeof(struct mcast_address), GFP_ATOMIC); > > + mcaddr = kmalloc(sizeof(*mcaddr), GFP_ATOMIC); > > if (mcaddr == NULL) > > You could make a series and also eliminate this == NULL test. > > julia > > > return 1; > > > > @@ -3049,7 +3049,7 @@ static u32 slic_card_locate(struct adapter > *adapter) > > } > > if (!physcard) { > > /* no structure allocated for this physical card yet */ > > - physcard = kzalloc(sizeof(struct physcard), GFP_ATOMIC); > > + physcard = kzalloc(sizeof(*physcard), GFP_ATOMIC); > > if (!physcard) { > > if (card_hostid == SLIC_HOSTID_DEFAULT) > > kfree(card); > > -- > > 1.8.3.4 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20160222103651.GA5176%40sandhya > . > > For more options, visit https://groups.google.com/d/optout. > > > [-- Attachment #2: Type: text/html, Size: 3783 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: slicoss: Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc(). 2016-02-23 19:46 ` sandhya bankar @ 2016-02-23 19:56 ` Julia Lawall 2016-02-23 19:59 ` sandhya bankar 0 siblings, 1 reply; 6+ messages in thread From: Julia Lawall @ 2016-02-23 19:56 UTC (permalink / raw) To: sandhya bankar; +Cc: outreachy-kernel [-- Attachment #1: Type: TEXT/PLAIN, Size: 4238 bytes --] On Wed, 24 Feb 2016, sandhya bankar wrote: > Hello, > I understand the ==NULL changes,but i have not understood the "make a > series" concept. If you look at the patches sent by others, sometimes they say, eg [PATCH 1/4] That means that there is a series of four patches, and this one is the first one. Making a series is necessary when you have several different changes to make, and they all touch the same file. By putting 1/4, 2/4, etc in the subject line, the maintainer knows in what order they should be applied. This reduces the chance of patch application errors. This is described in more detail in the Outreachy kernel tutorial in the section "Submitting a patchset". http://kernelnewbies.org/Outreachyfirstpatch#head-e0c4dbf8c60d25ca8e3ae133b6b65560f3c84c09 julia > > On Wed, Feb 24, 2016 at 1:09 AM, Julia Lawall <julia.lawall@lip6.fr> wrote: > > > On Mon, 22 Feb 2016, Sandhya Bankar wrote: > > > Use sizeof structure *pointer over sizeof structure in > kmalloc()/kzalloc(). > > > > Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> > > --- > > drivers/staging/slicoss/slicoss.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/staging/slicoss/slicoss.c > > index a91c60a..ea6b7b5 100644 > > --- a/drivers/staging/slicoss/slicoss.c > > +++ b/drivers/staging/slicoss/slicoss.c > > @@ -880,7 +880,7 @@ static int slic_upr_queue_request(struct > adapter *adapter, > > struct slic_upr *upr; > > struct slic_upr *uprqueue; > > > > - upr = kmalloc(sizeof(struct slic_upr), GFP_ATOMIC); > > + upr = kmalloc(sizeof(*upr), GFP_ATOMIC); > > if (!upr) > > return -ENOMEM; > > > > @@ -1806,7 +1806,7 @@ static int slic_mcast_add_list(struct > adapter *adapter, char *address) > > } > > > > /* Doesn't already exist. Allocate a structure to hold > it */ > > - mcaddr = kmalloc(sizeof(struct mcast_address), > GFP_ATOMIC); > > + mcaddr = kmalloc(sizeof(*mcaddr), GFP_ATOMIC); > > if (mcaddr == NULL) > > You could make a series and also eliminate this == NULL test. > > julia > > > return 1; > > > > @@ -3049,7 +3049,7 @@ static u32 slic_card_locate(struct > adapter *adapter) > > } > > if (!physcard) { > > /* no structure allocated for this physical > card yet */ > > - physcard = kzalloc(sizeof(struct physcard), > GFP_ATOMIC); > > + physcard = kzalloc(sizeof(*physcard), > GFP_ATOMIC); > > if (!physcard) { > > if (card_hostid == SLIC_HOSTID_DEFAULT) > > kfree(card); > > -- > > 1.8.3.4 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, > send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to > outreachy-kernel@googlegroups.com. > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20160222103651.GA5176%4 > 0sandhya. > > For more options, visit https://groups.google.com/d/optout. > > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAA3ASz%3DisFucBfQL0sf6 > hqjhWfC2R-ag8a_7s6W8wDnJMnGeHw%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: slicoss: Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc(). 2016-02-23 19:56 ` Julia Lawall @ 2016-02-23 19:59 ` sandhya bankar 2016-02-23 20:46 ` sandhya bankar 0 siblings, 1 reply; 6+ messages in thread From: sandhya bankar @ 2016-02-23 19:59 UTC (permalink / raw) To: Julia Lawall, outreachy-kernel [-- Attachment #1: Type: text/plain, Size: 4417 bytes --] thank you !! On Wed, Feb 24, 2016 at 1:26 AM, Julia Lawall <julia.lawall@lip6.fr> wrote: > > > On Wed, 24 Feb 2016, sandhya bankar wrote: > > > Hello, > > I understand the ==NULL changes,but i have not understood the "make a > > series" concept. > > If you look at the patches sent by others, sometimes they say, eg > > [PATCH 1/4] > > That means that there is a series of four patches, and this one is the > first one. Making a series is necessary when you have several different > changes to make, and they all touch the same file. By putting 1/4, 2/4, > etc in the subject line, the maintainer knows in what order they should > be applied. This reduces the chance of patch application errors. > > This is described in more detail in the Outreachy kernel tutorial in the > section "Submitting a patchset". > > > http://kernelnewbies.org/Outreachyfirstpatch#head-e0c4dbf8c60d25ca8e3ae133b6b65560f3c84c09 > > julia > > > > > On Wed, Feb 24, 2016 at 1:09 AM, Julia Lawall <julia.lawall@lip6.fr> > wrote: > > > > > > On Mon, 22 Feb 2016, Sandhya Bankar wrote: > > > > > Use sizeof structure *pointer over sizeof structure in > > kmalloc()/kzalloc(). > > > > > > Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> > > > --- > > > drivers/staging/slicoss/slicoss.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/staging/slicoss/slicoss.c > > b/drivers/staging/slicoss/slicoss.c > > > index a91c60a..ea6b7b5 100644 > > > --- a/drivers/staging/slicoss/slicoss.c > > > +++ b/drivers/staging/slicoss/slicoss.c > > > @@ -880,7 +880,7 @@ static int slic_upr_queue_request(struct > > adapter *adapter, > > > struct slic_upr *upr; > > > struct slic_upr *uprqueue; > > > > > > - upr = kmalloc(sizeof(struct slic_upr), GFP_ATOMIC); > > > + upr = kmalloc(sizeof(*upr), GFP_ATOMIC); > > > if (!upr) > > > return -ENOMEM; > > > > > > @@ -1806,7 +1806,7 @@ static int slic_mcast_add_list(struct > > adapter *adapter, char *address) > > > } > > > > > > /* Doesn't already exist. Allocate a structure to hold > > it */ > > > - mcaddr = kmalloc(sizeof(struct mcast_address), > > GFP_ATOMIC); > > > + mcaddr = kmalloc(sizeof(*mcaddr), GFP_ATOMIC); > > > if (mcaddr == NULL) > > > > You could make a series and also eliminate this == NULL test. > > > > julia > > > > > return 1; > > > > > > @@ -3049,7 +3049,7 @@ static u32 slic_card_locate(struct > > adapter *adapter) > > > } > > > if (!physcard) { > > > /* no structure allocated for this physical > > card yet */ > > > - physcard = kzalloc(sizeof(struct physcard), > > GFP_ATOMIC); > > > + physcard = kzalloc(sizeof(*physcard), > > GFP_ATOMIC); > > > if (!physcard) { > > > if (card_hostid == SLIC_HOSTID_DEFAULT) > > > kfree(card); > > > -- > > > 1.8.3.4 > > > > > > -- > > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, > > send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To post to this group, send email to > > outreachy-kernel@googlegroups.com. > > > To view this discussion on the web visithttps:// > groups.google.com/d/msgid/outreachy-kernel/20160222103651.GA5176%4 > > 0sandhya. > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visithttps:// > groups.google.com/d/msgid/outreachy-kernel/CAA3ASz%3DisFucBfQL0sf6 > > hqjhWfC2R-ag8a_7s6W8wDnJMnGeHw%40mail.gmail.com. > > For more options, visit https://groups.google.com/d/optout. > > > > > [-- Attachment #2: Type: text/html, Size: 6906 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: slicoss: Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc(). 2016-02-23 19:59 ` sandhya bankar @ 2016-02-23 20:46 ` sandhya bankar 0 siblings, 0 replies; 6+ messages in thread From: sandhya bankar @ 2016-02-23 20:46 UTC (permalink / raw) To: Julia Lawall, outreachy-kernel [-- Attachment #1: Type: text/plain, Size: 4736 bytes --] hello, I sent series of patches..but [patch 2/3] cant see in mailing list? should i send it again? On Wed, Feb 24, 2016 at 1:29 AM, sandhya bankar <bankarsandhya512@gmail.com> wrote: > thank you !! > > On Wed, Feb 24, 2016 at 1:26 AM, Julia Lawall <julia.lawall@lip6.fr> > wrote: > >> >> >> On Wed, 24 Feb 2016, sandhya bankar wrote: >> >> > Hello, >> > I understand the ==NULL changes,but i have not understood the "make a >> > series" concept. >> >> If you look at the patches sent by others, sometimes they say, eg >> >> [PATCH 1/4] >> >> That means that there is a series of four patches, and this one is the >> first one. Making a series is necessary when you have several different >> changes to make, and they all touch the same file. By putting 1/4, 2/4, >> etc in the subject line, the maintainer knows in what order they should >> be applied. This reduces the chance of patch application errors. >> >> This is described in more detail in the Outreachy kernel tutorial in the >> section "Submitting a patchset". >> >> >> http://kernelnewbies.org/Outreachyfirstpatch#head-e0c4dbf8c60d25ca8e3ae133b6b65560f3c84c09 >> >> julia >> >> > >> > On Wed, Feb 24, 2016 at 1:09 AM, Julia Lawall <julia.lawall@lip6.fr> >> wrote: >> > >> > >> > On Mon, 22 Feb 2016, Sandhya Bankar wrote: >> > >> > > Use sizeof structure *pointer over sizeof structure in >> > kmalloc()/kzalloc(). >> > > >> > > Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> >> > > --- >> > > drivers/staging/slicoss/slicoss.c | 6 +++--- >> > > 1 file changed, 3 insertions(+), 3 deletions(-) >> > > >> > > diff --git a/drivers/staging/slicoss/slicoss.c >> > b/drivers/staging/slicoss/slicoss.c >> > > index a91c60a..ea6b7b5 100644 >> > > --- a/drivers/staging/slicoss/slicoss.c >> > > +++ b/drivers/staging/slicoss/slicoss.c >> > > @@ -880,7 +880,7 @@ static int slic_upr_queue_request(struct >> > adapter *adapter, >> > > struct slic_upr *upr; >> > > struct slic_upr *uprqueue; >> > > >> > > - upr = kmalloc(sizeof(struct slic_upr), GFP_ATOMIC); >> > > + upr = kmalloc(sizeof(*upr), GFP_ATOMIC); >> > > if (!upr) >> > > return -ENOMEM; >> > > >> > > @@ -1806,7 +1806,7 @@ static int slic_mcast_add_list(struct >> > adapter *adapter, char *address) >> > > } >> > > >> > > /* Doesn't already exist. Allocate a structure to hold >> > it */ >> > > - mcaddr = kmalloc(sizeof(struct mcast_address), >> > GFP_ATOMIC); >> > > + mcaddr = kmalloc(sizeof(*mcaddr), GFP_ATOMIC); >> > > if (mcaddr == NULL) >> > >> > You could make a series and also eliminate this == NULL test. >> > >> > julia >> > >> > > return 1; >> > > >> > > @@ -3049,7 +3049,7 @@ static u32 slic_card_locate(struct >> > adapter *adapter) >> > > } >> > > if (!physcard) { >> > > /* no structure allocated for this physical >> > card yet */ >> > > - physcard = kzalloc(sizeof(struct physcard), >> > GFP_ATOMIC); >> > > + physcard = kzalloc(sizeof(*physcard), >> > GFP_ATOMIC); >> > > if (!physcard) { >> > > if (card_hostid == SLIC_HOSTID_DEFAULT) >> > > kfree(card); >> > > -- >> > > 1.8.3.4 >> > > >> > > -- >> > > You received this message because you are subscribed to the Google >> > Groups "outreachy-kernel" group. >> > > To unsubscribe from this group and stop receiving emails from it, >> > send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> > > To post to this group, send email to >> > outreachy-kernel@googlegroups.com. >> > > To view this discussion on the web visithttps:// >> groups.google.com/d/msgid/outreachy-kernel/20160222103651.GA5176%4 >> > 0sandhya. >> > > For more options, visit https://groups.google.com/d/optout. >> > > >> > >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups >> > "outreachy-kernel" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an >> > email to outreachy-kernel+unsubscribe@googlegroups.com. >> > To post to this group, send email to outreachy-kernel@googlegroups.com. >> > To view this discussion on the web visithttps:// >> groups.google.com/d/msgid/outreachy-kernel/CAA3ASz%3DisFucBfQL0sf6 >> > hqjhWfC2R-ag8a_7s6W8wDnJMnGeHw%40mail.gmail.com. >> > For more options, visit https://groups.google.com/d/optout. >> > >> > >> > > [-- Attachment #2: Type: text/html, Size: 7508 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-23 20:46 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-22 10:36 [PATCH] Staging: slicoss: Use sizeof structure *pointer over sizeof structure in kmalloc()/kzalloc() Sandhya Bankar 2016-02-23 19:39 ` [Outreachy kernel] " Julia Lawall 2016-02-23 19:46 ` sandhya bankar 2016-02-23 19:56 ` Julia Lawall 2016-02-23 19:59 ` sandhya bankar 2016-02-23 20:46 ` sandhya bankar
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.