* Re: [Outreachy kernel] [PATCH] staging: wilc1000: Use __packed instead of __attribute__((packed))
2016-02-20 16:12 Rakhi Sharma
@ 2016-02-20 22:43 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-02-20 22:43 UTC (permalink / raw)
To: Rakhi Sharma; +Cc: outreachy-kernel
On Sat, Feb 20, 2016 at 09:42:34PM +0530, Rakhi Sharma wrote:
> This patch fixes the warning: "__packed is preferred over
> __attribute__((packed))" as reported by checkpatch.pl.
>
> Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
> ---
> drivers/staging/wilc1000/linux_mon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This change was done by someone else a while ago, are you sure you are
working against the correct kernel tree and branch?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: wilc1000: Use __packed instead of __attribute__((packed))
@ 2016-02-22 4:26 Rakhi Sharma
2016-02-22 20:02 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Rakhi Sharma @ 2016-02-22 4:26 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Rakhi Sharma
This patch fixes the warning: "__packed is preferred over
__attribute__((packed))" as reported by checkpatch.pl.
Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
---
drivers/staging/wilc1000/linux_mon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index e550027..284dfb0 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -15,14 +15,14 @@
struct wilc_wfi_radiotap_hdr {
struct ieee80211_radiotap_header hdr;
u8 rate;
-} __attribute__((packed));
+} __packed;
struct wilc_wfi_radiotap_cb_hdr {
struct ieee80211_radiotap_header hdr;
u8 rate;
u8 dump;
u16 tx_flags;
-} __attribute__((packed));
+} __packed;
static struct net_device *wilc_wfi_mon; /* global monitor netdev */
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: wilc1000: Use __packed instead of __attribute__((packed))
2016-02-22 4:26 [PATCH] staging: wilc1000: Use __packed instead of __attribute__((packed)) Rakhi Sharma
@ 2016-02-22 20:02 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-02-22 20:02 UTC (permalink / raw)
To: Rakhi Sharma; +Cc: outreachy-kernel
On Mon, Feb 22, 2016 at 09:56:39AM +0530, Rakhi Sharma wrote:
> This patch fixes the warning: "__packed is preferred over
> __attribute__((packed))" as reported by checkpatch.pl.
>
> Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>
> ---
> drivers/staging/wilc1000/linux_mon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This is already in my tree :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-22 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 4:26 [PATCH] staging: wilc1000: Use __packed instead of __attribute__((packed)) Rakhi Sharma
2016-02-22 20:02 ` [Outreachy kernel] " Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-02-20 16:12 Rakhi Sharma
2016-02-20 22:43 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.