From: Johannes Weiner <hannes@cmpxchg.org>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH v2] mm: scale kswapd watermarks in proportion to memory
Date: Mon, 22 Feb 2016 17:53:18 -0800 [thread overview]
Message-ID: <20160223015318.GA30924@cmpxchg.org> (raw)
In-Reply-To: <1456191393.7716.28.camel@redhat.com>
On Mon, Feb 22, 2016 at 08:36:33PM -0500, Rik van Riel wrote:
> On Mon, 2016-02-22 at 15:33 -0800, Johannes Weiner wrote:
>
> > Beyond 1G of memory, this will produce bigger watermark steps than
>
> Is that supposed to be beyond 16GB?
The old formula formula is
min = sqrt(kb * 16)
low = min >> 2
and the new one is
low = kb * 0.001
and
sqrt(x/1024 * 16) >> 2 = x/1024 * 0.001
puts x at
x = 1 << 30
Did I miss something?
> Acked-by: Rik van Riel <riel@redhat.com>
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH v2] mm: scale kswapd watermarks in proportion to memory
Date: Mon, 22 Feb 2016 17:53:18 -0800 [thread overview]
Message-ID: <20160223015318.GA30924@cmpxchg.org> (raw)
In-Reply-To: <1456191393.7716.28.camel@redhat.com>
On Mon, Feb 22, 2016 at 08:36:33PM -0500, Rik van Riel wrote:
> On Mon, 2016-02-22 at 15:33 -0800, Johannes Weiner wrote:
>
> > Beyond 1G of memory, this will produce bigger watermark steps than
>
> Is that supposed to be beyond 16GB?
The old formula formula is
min = sqrt(kb * 16)
low = min >> 2
and the new one is
low = kb * 0.001
and
sqrt(x/1024 * 16) >> 2 = x/1024 * 0.001
puts x at
x = 1 << 30
Did I miss something?
> Acked-by: Rik van Riel <riel@redhat.com>
Thanks!
next prev parent reply other threads:[~2016-02-23 1:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 23:33 [PATCH v2] mm: scale kswapd watermarks in proportion to memory Johannes Weiner
2016-02-22 23:33 ` Johannes Weiner
2016-02-23 1:36 ` Rik van Riel
2016-02-23 1:53 ` Johannes Weiner [this message]
2016-02-23 1:53 ` Johannes Weiner
2016-02-23 2:23 ` David Rientjes
2016-02-23 2:23 ` David Rientjes
2016-02-24 0:36 ` Johannes Weiner
2016-02-24 0:36 ` Johannes Weiner
2016-02-24 0:39 ` David Rientjes
2016-02-24 0:39 ` David Rientjes
2016-02-25 0:37 ` Joonsoo Kim
2016-02-25 0:37 ` Joonsoo Kim
2016-02-25 20:07 ` Johannes Weiner
2016-02-25 20:07 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223015318.GA30924@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.