All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andri Yngvason <andri.yngvason@marel.com>
To: Stephane Grosjean <s.grosjean@peak-system.com>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can/peak_pci: fix FPGA potential frame loss issue
Date: Tue, 23 Feb 2016 16:53:09 +0000	[thread overview]
Message-ID: <20160223165309.GA14154@maxwell.marel.net> (raw)
In-Reply-To: <1453288532-15034-1-git-send-email-s.grosjean@peak-system.com>

On Wed, Jan 20, 2016 at 12:15:32PM +0100, Stephane Grosjean wrote:
> This patch installs a workaround when the driver detects one of the
> following PEAK-System CAN interfaces, running a firmware < v1.3.0:
> 
> PCAN-PCI Express 1/2/4 CAN; DeviceID 0x0003
> PCAN-PCI/104 Express 1/2/4 CAN; DeviceID 0x0007
> PCAN-miniPCIe 1/2 CAN; DeviceID 0x0008
> PCAN-PCI Express OEM 1/2/4 CAN; DeviceID 0x0009
> PCAN-ExpressCard 34 1 CAN; DeviceID 0x000A
> 
> This fixes potential loss of one tx frame in Linux SMP when some other
> task does another Command Register write (e.g. Release Receive Buffer)
> in between the triggering Tx Request and the next Sample Point.
> 
> This workaround is useless thus *NOT* installed when the firmware
> has been upgraded to v1.3.0 or higher, nor if the CAN interface is equipped
> with true SJA1000 controller(s).
> 
> Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
> ---
>  drivers/net/can/sja1000/peak_pci.c | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)
> 
[...]

Hi Stéphane,

Is this still being worked on?

I can test this if you like. I just need to have the firmware upgrade.

Regards,
Andri

      parent reply	other threads:[~2016-02-23 17:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 11:15 [PATCH] can/peak_pci: fix FPGA potential frame loss issue Stephane Grosjean
2016-01-20 14:11 ` Marc Kleine-Budde
2016-01-20 14:29   ` Stephane Grosjean
2016-01-20 14:33     ` Marc Kleine-Budde
2016-01-21 17:51       ` Oliver Hartkopp
2016-01-22  9:10         ` Stephane Grosjean
2016-04-08  5:36           ` Oliver Hartkopp
2016-01-20 14:51 ` Andri Yngvason
2016-02-23 16:53 ` Andri Yngvason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160223165309.GA14154@maxwell.marel.net \
    --to=andri.yngvason@marel.com \
    --cc=linux-can@vger.kernel.org \
    --cc=s.grosjean@peak-system.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.