Re: [PATCH] can/peak_pci: fix FPGA potential frame loss issue

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2172 bytes --]

On 01/20/2016 03:29 PM, Stephane Grosjean wrote:
> 
> Le 20/01/2016 15:11, Marc Kleine-Budde a écrit :
>> On 01/20/2016 12:15 PM, Stephane Grosjean wrote:
>>> This patch installs a workaround when the driver detects one of the
>>> following PEAK-System CAN interfaces, running a firmware < v1.3.0:
>> Is the problem fixed on FW >= 1.3.0? Is it possible to update the
>> firmware? If so, what about printing a warning message about known
>> problem with the firmware?
> 
> Yes, problem is fixed with 1.3.0.
> And yes, firmware can be updated.
> What kind of warning message are you talking about? Do you mean that 
> peak_pci could dev_warn() a text msg to inform about the fact that the 
> current FW is able to be upgraded?
> 
> If yes, since peak_pci prints a single info line per CAN channel, what 
> would you prefer?
> 
> - the same warning about the old FW version, for each candev, something 
> like:
> 
> [ 2200.129168] peak_pci 0000:05:01.0: can0 at 
> reg_base=0xffffc90000678000 cfg_base=0xffffc90000676000 irq=22 FW=1.2.0 
> should be updated
> [ 2200.129307] peak_pci 0000:05:01.0: can1 at 
> reg_base=0xffffc90000678400 cfg_base=0xffffc90000676000 irq=22 FW=1.2.0 
> should be updated
> 
> - or a single warning msg for the hardware device, something like:
> 
> [ 2200.129168] peak_pci 0000:05:01.0: Warning: FW v1.2.0 needs a 
> workaround; update is available

One per hardware device is enough.
"Warning: FW v1.2.0 workaround active; Please update device Firmeware."

...and a webpage displaying this message, so that you will find it.
Maybe even add a link to the website in the commit message.

> [ 2200.129168] peak_pci 0000:05:01.0: can0 at 
> reg_base=0xffffc90000678000 cfg_base=0xffffc90000676000 irq=22
> [ 2200.129307] peak_pci 0000:05:01.0: can1 at 
> reg_base=0xffffc90000678400 cfg_base=0xffffc90000676000 irq=22

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]