From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH] drivers/rtc: make class.c explicitly non-modular
Date: Wed, 24 Feb 2016 00:13:28 +0100 [thread overview]
Message-ID: <20160223231328.GD10681@piout.net> (raw)
In-Reply-To: <1455480259-13433-1-git-send-email-paul.gortmaker@windriver.com>
On 14/02/2016 at 15:04:19 -0500, Paul Gortmaker wrote :
> The Makefile/Kconfig currently controlling compilation of this code is:
>
> obj-$(CONFIG_RTC_CLASS) += rtc-core.o
> rtc-core-y := class.o interface.o
>
> drivers/rtc/Kconfig:menuconfig RTC_CLASS
> drivers/rtc/Kconfig: bool "Real Time Clock"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the code there is no doubt it is builtin-only.
>
> We don't replace module.h with init.h since the file does need
> to know what a struct module is.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: rtc-linux@googlegroups.com
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/rtc/class.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH] drivers/rtc: make class.c explicitly non-modular
Date: Wed, 24 Feb 2016 00:13:28 +0100 [thread overview]
Message-ID: <20160223231328.GD10681@piout.net> (raw)
In-Reply-To: <1455480259-13433-1-git-send-email-paul.gortmaker@windriver.com>
On 14/02/2016 at 15:04:19 -0500, Paul Gortmaker wrote :
> The Makefile/Kconfig currently controlling compilation of this code is:
>
> obj-$(CONFIG_RTC_CLASS) += rtc-core.o
> rtc-core-y := class.o interface.o
>
> drivers/rtc/Kconfig:menuconfig RTC_CLASS
> drivers/rtc/Kconfig: bool "Real Time Clock"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the code there is no doubt it is builtin-only.
>
> We don't replace module.h with init.h since the file does need
> to know what a struct module is.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: rtc-linux@googlegroups.com
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/rtc/class.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-23 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 20:04 [rtc-linux] [PATCH] drivers/rtc: make class.c explicitly non-modular Paul Gortmaker
2016-02-14 20:04 ` Paul Gortmaker
2016-02-23 23:13 ` Alexandre Belloni [this message]
2016-02-23 23:13 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223231328.GD10681@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.