* [PATCH] staging: fbtft: replace ternary operator with min macro
@ 2016-02-24 6:48 Alison Schofield
2016-02-24 9:08 ` [Outreachy kernel] " Julia Lawall
2016-02-24 17:20 ` [PATCH v2] " Alison Schofield
0 siblings, 2 replies; 3+ messages in thread
From: Alison Schofield @ 2016-02-24 6:48 UTC (permalink / raw)
To: outreachy-kernel
Use macro min() to get the minimum of two values for
brevity and readability.
Found using Coccinelle:
@ type T; T x; T y; @@
(
- x < y ? x : y
+ min(x,y)
|
- x > y ? x : y
+ max(x,y)
)
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
---
drivers/staging/fbtft/fb_ra8875.c | 2 +-
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c
index b167c50..0585e0b 100644
--- a/drivers/staging/fbtft/fb_ra8875.c
+++ b/drivers/staging/fbtft/fb_ra8875.c
@@ -277,7 +277,7 @@ static int write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
startbyte_size = 1;
while (remain) {
- to_copy = remain > tx_array_size ? tx_array_size : remain;
+ to_copy = min(tx_array_size, remain);
dev_dbg(par->info->device, " to_copy=%zu, remain=%zu\n",
to_copy, remain - to_copy);
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 58449ad8..b31f111 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -157,7 +157,7 @@ int fbtft_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
}
while (remain) {
- to_copy = remain > tx_array_size ? tx_array_size : remain;
+ to_copy = min(tx_array_size, remain);
dev_dbg(par->info->device, " to_copy=%zu, remain=%zu\n",
to_copy, remain - to_copy);
@@ -201,7 +201,7 @@ int fbtft_write_vmem16_bus9(struct fbtft_par *par, size_t offset, size_t len)
tx_array_size = par->txbuf.len / 2;
while (remain) {
- to_copy = remain > tx_array_size ? tx_array_size : remain;
+ to_copy = min(tx_array_size, remain);
dev_dbg(par->info->device, " to_copy=%zu, remain=%zu\n",
to_copy, remain - to_copy);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: fbtft: replace ternary operator with min macro
2016-02-24 6:48 [PATCH] staging: fbtft: replace ternary operator with min macro Alison Schofield
@ 2016-02-24 9:08 ` Julia Lawall
2016-02-24 17:20 ` [PATCH v2] " Alison Schofield
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2016-02-24 9:08 UTC (permalink / raw)
To: Alison Schofield; +Cc: outreachy-kernel
On Tue, 23 Feb 2016, Alison Schofield wrote:
> Use macro min() to get the minimum of two values for
> brevity and readability.
>
> Found using Coccinelle:
> @ type T; T x; T y; @@
The first @ is missing.
julia
> (
> - x < y ? x : y
> + min(x,y)
> |
> - x > y ? x : y
> + max(x,y)
> )
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> ---
> drivers/staging/fbtft/fb_ra8875.c | 2 +-
> drivers/staging/fbtft/fbtft-bus.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c
> index b167c50..0585e0b 100644
> --- a/drivers/staging/fbtft/fb_ra8875.c
> +++ b/drivers/staging/fbtft/fb_ra8875.c
> @@ -277,7 +277,7 @@ static int write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
> startbyte_size = 1;
>
> while (remain) {
> - to_copy = remain > tx_array_size ? tx_array_size : remain;
> + to_copy = min(tx_array_size, remain);
> dev_dbg(par->info->device, " to_copy=%zu, remain=%zu\n",
> to_copy, remain - to_copy);
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 58449ad8..b31f111 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -157,7 +157,7 @@ int fbtft_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
> }
>
> while (remain) {
> - to_copy = remain > tx_array_size ? tx_array_size : remain;
> + to_copy = min(tx_array_size, remain);
> dev_dbg(par->info->device, " to_copy=%zu, remain=%zu\n",
> to_copy, remain - to_copy);
>
> @@ -201,7 +201,7 @@ int fbtft_write_vmem16_bus9(struct fbtft_par *par, size_t offset, size_t len)
> tx_array_size = par->txbuf.len / 2;
>
> while (remain) {
> - to_copy = remain > tx_array_size ? tx_array_size : remain;
> + to_copy = min(tx_array_size, remain);
> dev_dbg(par->info->device, " to_copy=%zu, remain=%zu\n",
> to_copy, remain - to_copy);
>
> --
> 2.1.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160224064843.GA17889%40d830.WORKGROUP.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] staging: fbtft: replace ternary operator with min macro
2016-02-24 6:48 [PATCH] staging: fbtft: replace ternary operator with min macro Alison Schofield
2016-02-24 9:08 ` [Outreachy kernel] " Julia Lawall
@ 2016-02-24 17:20 ` Alison Schofield
1 sibling, 0 replies; 3+ messages in thread
From: Alison Schofield @ 2016-02-24 17:20 UTC (permalink / raw)
To: outreachy-kernel
Use macro min() to get the minimum of two values for
brevity and readability.
Found using Coccinelle:
@@ type T; T x; T y; @@
(
- x < y ? x : y
+ min(x,y)
|
- x > y ? x : y
+ max(x,y)
)
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
---
Change in v2:
- corrected Coccinelle script
drivers/staging/fbtft/fb_ra8875.c | 2 +-
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c
index b167c50..0585e0b 100644
--- a/drivers/staging/fbtft/fb_ra8875.c
+++ b/drivers/staging/fbtft/fb_ra8875.c
@@ -277,7 +277,7 @@ static int write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
startbyte_size = 1;
while (remain) {
- to_copy = remain > tx_array_size ? tx_array_size : remain;
+ to_copy = min(tx_array_size, remain);
dev_dbg(par->info->device, " to_copy=%zu, remain=%zu\n",
to_copy, remain - to_copy);
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 58449ad8..b31f111 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -157,7 +157,7 @@ int fbtft_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
}
while (remain) {
- to_copy = remain > tx_array_size ? tx_array_size : remain;
+ to_copy = min(tx_array_size, remain);
dev_dbg(par->info->device, " to_copy=%zu, remain=%zu\n",
to_copy, remain - to_copy);
@@ -201,7 +201,7 @@ int fbtft_write_vmem16_bus9(struct fbtft_par *par, size_t offset, size_t len)
tx_array_size = par->txbuf.len / 2;
while (remain) {
- to_copy = remain > tx_array_size ? tx_array_size : remain;
+ to_copy = min(tx_array_size, remain);
dev_dbg(par->info->device, " to_copy=%zu, remain=%zu\n",
to_copy, remain - to_copy);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-24 17:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 6:48 [PATCH] staging: fbtft: replace ternary operator with min macro Alison Schofield
2016-02-24 9:08 ` [Outreachy kernel] " Julia Lawall
2016-02-24 17:20 ` [PATCH v2] " Alison Schofield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.