* [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions
@ 2016-02-19 14:48 ` Ludovic Desroches
0 siblings, 0 replies; 9+ messages in thread
From: Ludovic Desroches @ 2016-02-19 14:48 UTC (permalink / raw)
To: linux-arm-kernel
PIN_PA15 macro has the same value as PIN_PA14 so we were overriding PA14
mux/configuration.
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Reported-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Fixes: 7f16cb676c00 ("ARM: at91/dt: add sama5d2 pinmux")
Cc: stable at vger.kernel.org #4.4 and later
---
arch/arm/boot/dts/sama5d2-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
index 1afe246..b0c912fe 100644
--- a/arch/arm/boot/dts/sama5d2-pinfunc.h
+++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
@@ -90,7 +90,7 @@
#define PIN_PA14__I2SC1_MCK PINMUX_PIN(PIN_PA14, 4, 2)
#define PIN_PA14__FLEXCOM3_IO2 PINMUX_PIN(PIN_PA14, 5, 1)
#define PIN_PA14__D9 PINMUX_PIN(PIN_PA14, 6, 2)
-#define PIN_PA15 14
+#define PIN_PA15 15
#define PIN_PA15__GPIO PINMUX_PIN(PIN_PA15, 0, 0)
#define PIN_PA15__SPI0_MOSI PINMUX_PIN(PIN_PA15, 1, 1)
#define PIN_PA15__TF1 PINMUX_PIN(PIN_PA15, 2, 1)
--
2.5.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions
@ 2016-02-19 14:48 ` Ludovic Desroches
0 siblings, 0 replies; 9+ messages in thread
From: Ludovic Desroches @ 2016-02-19 14:48 UTC (permalink / raw)
To: alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w, Ludovic Desroches
PIN_PA15 macro has the same value as PIN_PA14 so we were overriding PA14
mux/configuration.
Signed-off-by: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Reported-by: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Fixes: 7f16cb676c00 ("ARM: at91/dt: add sama5d2 pinmux")
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org #4.4 and later
---
arch/arm/boot/dts/sama5d2-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
index 1afe246..b0c912fe 100644
--- a/arch/arm/boot/dts/sama5d2-pinfunc.h
+++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
@@ -90,7 +90,7 @@
#define PIN_PA14__I2SC1_MCK PINMUX_PIN(PIN_PA14, 4, 2)
#define PIN_PA14__FLEXCOM3_IO2 PINMUX_PIN(PIN_PA14, 5, 1)
#define PIN_PA14__D9 PINMUX_PIN(PIN_PA14, 6, 2)
-#define PIN_PA15 14
+#define PIN_PA15 15
#define PIN_PA15__GPIO PINMUX_PIN(PIN_PA15, 0, 0)
#define PIN_PA15__SPI0_MOSI PINMUX_PIN(PIN_PA15, 1, 1)
#define PIN_PA15__TF1 PINMUX_PIN(PIN_PA15, 2, 1)
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions
@ 2016-02-19 14:48 ` Ludovic Desroches
0 siblings, 0 replies; 9+ messages in thread
From: Ludovic Desroches @ 2016-02-19 14:48 UTC (permalink / raw)
To: alexandre.belloni, nicolas.ferre
Cc: devicetree, linux-arm-kernel, linux-kernel, cyrille.pitchen,
Ludovic Desroches
PIN_PA15 macro has the same value as PIN_PA14 so we were overriding PA14
mux/configuration.
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Reported-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Fixes: 7f16cb676c00 ("ARM: at91/dt: add sama5d2 pinmux")
Cc: stable@vger.kernel.org #4.4 and later
---
arch/arm/boot/dts/sama5d2-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
index 1afe246..b0c912fe 100644
--- a/arch/arm/boot/dts/sama5d2-pinfunc.h
+++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
@@ -90,7 +90,7 @@
#define PIN_PA14__I2SC1_MCK PINMUX_PIN(PIN_PA14, 4, 2)
#define PIN_PA14__FLEXCOM3_IO2 PINMUX_PIN(PIN_PA14, 5, 1)
#define PIN_PA14__D9 PINMUX_PIN(PIN_PA14, 6, 2)
-#define PIN_PA15 14
+#define PIN_PA15 15
#define PIN_PA15__GPIO PINMUX_PIN(PIN_PA15, 0, 0)
#define PIN_PA15__SPI0_MOSI PINMUX_PIN(PIN_PA15, 1, 1)
#define PIN_PA15__TF1 PINMUX_PIN(PIN_PA15, 2, 1)
--
2.5.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions
@ 2016-02-19 19:21 Alexandre Belloni
2016-02-24 8:08 ` Olof Johansson
0 siblings, 1 reply; 9+ messages in thread
From: Alexandre Belloni @ 2016-02-19 19:21 UTC (permalink / raw)
To: arm
Cc: Olof Johansson, Arnd Bergmann, Nicolas Ferre, Ludovic Desroches,
# v4 . 4+, Alexandre Belloni
From: Ludovic Desroches <ludovic.desroches@atmel.com>
PIN_PA15 macro has the same value as PIN_PA14 so we were overriding PA14
mux/configuration.
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Reported-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Fixes: 7f16cb676c00 ("ARM: at91/dt: add sama5d2 pinmux")
Cc: <stable@vger.kernel.org> # v4.4+
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/sama5d2-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
index 1afe24629d1f..b0c912feaa2f 100644
--- a/arch/arm/boot/dts/sama5d2-pinfunc.h
+++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
@@ -90,7 +90,7 @@
#define PIN_PA14__I2SC1_MCK PINMUX_PIN(PIN_PA14, 4, 2)
#define PIN_PA14__FLEXCOM3_IO2 PINMUX_PIN(PIN_PA14, 5, 1)
#define PIN_PA14__D9 PINMUX_PIN(PIN_PA14, 6, 2)
-#define PIN_PA15 14
+#define PIN_PA15 15
#define PIN_PA15__GPIO PINMUX_PIN(PIN_PA15, 0, 0)
#define PIN_PA15__SPI0_MOSI PINMUX_PIN(PIN_PA15, 1, 1)
#define PIN_PA15__TF1 PINMUX_PIN(PIN_PA15, 2, 1)
--
2.7.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions
2016-02-19 19:21 [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions Alexandre Belloni
@ 2016-02-24 8:08 ` Olof Johansson
0 siblings, 0 replies; 9+ messages in thread
From: Olof Johansson @ 2016-02-24 8:08 UTC (permalink / raw)
To: Alexandre Belloni
Cc: arm, Arnd Bergmann, Nicolas Ferre, Ludovic Desroches, # v4 . 4+
On Fri, Feb 19, 2016 at 08:21:17PM +0100, Alexandre Belloni wrote:
> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>
> PIN_PA15 macro has the same value as PIN_PA14 so we were overriding PA14
> mux/configuration.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> Reported-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Fixes: 7f16cb676c00 ("ARM: at91/dt: add sama5d2 pinmux")
> Cc: <stable@vger.kernel.org> # v4.4+
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Applied to fixes. Thanks.
-Olof
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions
@ 2018-09-14 15:20 ` Michał Mirosław
0 siblings, 0 replies; 9+ messages in thread
From: Michał Mirosław @ 2018-09-14 15:20 UTC (permalink / raw)
To: linux-arm-kernel
Fix SSC0 pin TD0 where wrongly called TDO.
Signed-off-by: Micha? Miros?aw <mirq-linux@rere.qmqm.pl>
---
Against v4.18.7
arch/arm/boot/dts/sama5d2-pinfunc.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
index e57191fb83de..1c01a6f843d8 100644
--- a/arch/arm/boot/dts/sama5d2-pinfunc.h
+++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
@@ -375,7 +375,7 @@
#define PIN_PB22__GPIO PINMUX_PIN(PIN_PB22, 0, 0)
#define PIN_PB22__LCDDAT11 PINMUX_PIN(PIN_PB22, 1, 1)
#define PIN_PB22__A11 PINMUX_PIN(PIN_PB22, 2, 1)
-#define PIN_PB22__TDO PINMUX_PIN(PIN_PB22, 3, 1)
+#define PIN_PB22__TD0 PINMUX_PIN(PIN_PB22, 3, 1)
#define PIN_PB22__TIOA2 PINMUX_PIN(PIN_PB22, 4, 2)
#define PIN_PB22__FLEXCOM3_IO1 PINMUX_PIN(PIN_PB22, 5, 3)
#define PIN_PB22__GMDC PINMUX_PIN(PIN_PB22, 6, 3)
@@ -556,7 +556,7 @@
#define PIN_PC14__LCDDAT6 PINMUX_PIN(PIN_PC14, 1, 2)
#define PIN_PC14__GRX0 PINMUX_PIN(PIN_PC14, 2, 1)
#define PIN_PC14__ISC_D5 PINMUX_PIN(PIN_PC14, 3, 1)
-#define PIN_PC14__TDO PINMUX_PIN(PIN_PC14, 5, 2)
+#define PIN_PC14__TD0 PINMUX_PIN(PIN_PC14, 5, 2)
#define PIN_PC14__A3 PINMUX_PIN(PIN_PC14, 6, 2)
#define PIN_PC15 79
#define PIN_PC15__GPIO PINMUX_PIN(PIN_PC15, 0, 0)
--
2.18.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions
@ 2018-09-14 15:20 ` Michał Mirosław
0 siblings, 0 replies; 9+ messages in thread
From: Michał Mirosław @ 2018-09-14 15:20 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Mark Rutland, devicetree, Alexandre Belloni, Rob Herring
Fix SSC0 pin TD0 where wrongly called TDO.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
Against v4.18.7
arch/arm/boot/dts/sama5d2-pinfunc.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
index e57191fb83de..1c01a6f843d8 100644
--- a/arch/arm/boot/dts/sama5d2-pinfunc.h
+++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
@@ -375,7 +375,7 @@
#define PIN_PB22__GPIO PINMUX_PIN(PIN_PB22, 0, 0)
#define PIN_PB22__LCDDAT11 PINMUX_PIN(PIN_PB22, 1, 1)
#define PIN_PB22__A11 PINMUX_PIN(PIN_PB22, 2, 1)
-#define PIN_PB22__TDO PINMUX_PIN(PIN_PB22, 3, 1)
+#define PIN_PB22__TD0 PINMUX_PIN(PIN_PB22, 3, 1)
#define PIN_PB22__TIOA2 PINMUX_PIN(PIN_PB22, 4, 2)
#define PIN_PB22__FLEXCOM3_IO1 PINMUX_PIN(PIN_PB22, 5, 3)
#define PIN_PB22__GMDC PINMUX_PIN(PIN_PB22, 6, 3)
@@ -556,7 +556,7 @@
#define PIN_PC14__LCDDAT6 PINMUX_PIN(PIN_PC14, 1, 2)
#define PIN_PC14__GRX0 PINMUX_PIN(PIN_PC14, 2, 1)
#define PIN_PC14__ISC_D5 PINMUX_PIN(PIN_PC14, 3, 1)
-#define PIN_PC14__TDO PINMUX_PIN(PIN_PC14, 5, 2)
+#define PIN_PC14__TD0 PINMUX_PIN(PIN_PC14, 5, 2)
#define PIN_PC14__A3 PINMUX_PIN(PIN_PC14, 6, 2)
#define PIN_PC15 79
#define PIN_PC15__GPIO PINMUX_PIN(PIN_PC15, 0, 0)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions
2018-09-14 15:20 ` Michał Mirosław
@ 2018-09-14 15:30 ` Nicolas Ferre
-1 siblings, 0 replies; 9+ messages in thread
From: Nicolas Ferre @ 2018-09-14 15:30 UTC (permalink / raw)
To: linux-arm-kernel
On 14/09/2018 at 17:20, Micha? Miros?aw wrote:
> Fix SSC0 pin TD0 where wrongly called TDO.
>
> Signed-off-by: Micha? Miros?aw <mirq-linux@rere.qmqm.pl>
Micha?,
Thanks for your patch. But the exact same one is already integrated in
Linus' tree as:
c8cbc1c20c29 ("ARM: dts: at91: fix typos for SSC TD functions")
Best regards,
Nicolas
> ---
> Against v4.18.7
>
> arch/arm/boot/dts/sama5d2-pinfunc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
> index e57191fb83de..1c01a6f843d8 100644
> --- a/arch/arm/boot/dts/sama5d2-pinfunc.h
> +++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
> @@ -375,7 +375,7 @@
> #define PIN_PB22__GPIO PINMUX_PIN(PIN_PB22, 0, 0)
> #define PIN_PB22__LCDDAT11 PINMUX_PIN(PIN_PB22, 1, 1)
> #define PIN_PB22__A11 PINMUX_PIN(PIN_PB22, 2, 1)
> -#define PIN_PB22__TDO PINMUX_PIN(PIN_PB22, 3, 1)
> +#define PIN_PB22__TD0 PINMUX_PIN(PIN_PB22, 3, 1)
> #define PIN_PB22__TIOA2 PINMUX_PIN(PIN_PB22, 4, 2)
> #define PIN_PB22__FLEXCOM3_IO1 PINMUX_PIN(PIN_PB22, 5, 3)
> #define PIN_PB22__GMDC PINMUX_PIN(PIN_PB22, 6, 3)
> @@ -556,7 +556,7 @@
> #define PIN_PC14__LCDDAT6 PINMUX_PIN(PIN_PC14, 1, 2)
> #define PIN_PC14__GRX0 PINMUX_PIN(PIN_PC14, 2, 1)
> #define PIN_PC14__ISC_D5 PINMUX_PIN(PIN_PC14, 3, 1)
> -#define PIN_PC14__TDO PINMUX_PIN(PIN_PC14, 5, 2)
> +#define PIN_PC14__TD0 PINMUX_PIN(PIN_PC14, 5, 2)
> #define PIN_PC14__A3 PINMUX_PIN(PIN_PC14, 6, 2)
> #define PIN_PC15 79
> #define PIN_PC15__GPIO PINMUX_PIN(PIN_PC15, 0, 0)
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions
@ 2018-09-14 15:30 ` Nicolas Ferre
0 siblings, 0 replies; 9+ messages in thread
From: Nicolas Ferre @ 2018-09-14 15:30 UTC (permalink / raw)
To: Michał Mirosław, linux-arm-kernel
Cc: Mark Rutland, devicetree, Alexandre Belloni, Rob Herring,
Claudiu Beznea - M18063
On 14/09/2018 at 17:20, Michał Mirosław wrote:
> Fix SSC0 pin TD0 where wrongly called TDO.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Michał,
Thanks for your patch. But the exact same one is already integrated in
Linus' tree as:
c8cbc1c20c29 ("ARM: dts: at91: fix typos for SSC TD functions")
Best regards,
Nicolas
> ---
> Against v4.18.7
>
> arch/arm/boot/dts/sama5d2-pinfunc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
> index e57191fb83de..1c01a6f843d8 100644
> --- a/arch/arm/boot/dts/sama5d2-pinfunc.h
> +++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
> @@ -375,7 +375,7 @@
> #define PIN_PB22__GPIO PINMUX_PIN(PIN_PB22, 0, 0)
> #define PIN_PB22__LCDDAT11 PINMUX_PIN(PIN_PB22, 1, 1)
> #define PIN_PB22__A11 PINMUX_PIN(PIN_PB22, 2, 1)
> -#define PIN_PB22__TDO PINMUX_PIN(PIN_PB22, 3, 1)
> +#define PIN_PB22__TD0 PINMUX_PIN(PIN_PB22, 3, 1)
> #define PIN_PB22__TIOA2 PINMUX_PIN(PIN_PB22, 4, 2)
> #define PIN_PB22__FLEXCOM3_IO1 PINMUX_PIN(PIN_PB22, 5, 3)
> #define PIN_PB22__GMDC PINMUX_PIN(PIN_PB22, 6, 3)
> @@ -556,7 +556,7 @@
> #define PIN_PC14__LCDDAT6 PINMUX_PIN(PIN_PC14, 1, 2)
> #define PIN_PC14__GRX0 PINMUX_PIN(PIN_PC14, 2, 1)
> #define PIN_PC14__ISC_D5 PINMUX_PIN(PIN_PC14, 3, 1)
> -#define PIN_PC14__TDO PINMUX_PIN(PIN_PC14, 5, 2)
> +#define PIN_PC14__TD0 PINMUX_PIN(PIN_PC14, 5, 2)
> #define PIN_PC14__A3 PINMUX_PIN(PIN_PC14, 6, 2)
> #define PIN_PC15 79
> #define PIN_PC15__GPIO PINMUX_PIN(PIN_PC15, 0, 0)
>
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-09-14 15:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19 19:21 [PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions Alexandre Belloni
2016-02-24 8:08 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2018-09-14 15:20 Michał Mirosław
2018-09-14 15:20 ` Michał Mirosław
2018-09-14 15:30 ` Nicolas Ferre
2018-09-14 15:30 ` Nicolas Ferre
2016-02-19 14:48 Ludovic Desroches
2016-02-19 14:48 ` Ludovic Desroches
2016-02-19 14:48 ` Ludovic Desroches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.