* [PATCH 0/6] i2c: sort includes for the core
@ 2016-02-20 22:38 Wolfram Sang
2016-02-20 22:38 ` [PATCH 1/6] i2c: i2c-boardinfo: sort includes Wolfram Sang
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: Wolfram Sang @ 2016-02-20 22:38 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang
If drivers must do it, the core should do it as well: keep the includes sorted
to make it hard to duplicate entries :)
Plain sorting, nothing has been added or removed.
Wolfram Sang (6):
i2c: i2c-boardinfo: sort includes
i2c: i2c-core: sort includes
i2c: i2c-dev: sort includes
i2c: i2c-mux: sort includes
i2c: i2c-smbus: sort includes
i2c: i2c-stub: sort includes
drivers/i2c/i2c-boardinfo.c | 6 +++---
drivers/i2c/i2c-core.c | 30 +++++++++++++++---------------
drivers/i2c/i2c-dev.c | 14 +++++++-------
drivers/i2c/i2c-mux.c | 8 ++++----
drivers/i2c/i2c-smbus.c | 8 ++++----
drivers/i2c/i2c-stub.c | 8 ++++----
6 files changed, 37 insertions(+), 37 deletions(-)
--
2.7.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/6] i2c: i2c-boardinfo: sort includes
2016-02-20 22:38 [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
@ 2016-02-20 22:38 ` Wolfram Sang
2016-02-20 22:38 ` [PATCH 2/6] i2c: i2c-core: " Wolfram Sang
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2016-02-20 22:38 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang
I request this for drivers, so the core should adhere to sorted includes as
well.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/i2c-boardinfo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/i2c-boardinfo.c b/drivers/i2c/i2c-boardinfo.c
index 90e32295930332..e33022e2d459f1 100644
--- a/drivers/i2c/i2c-boardinfo.c
+++ b/drivers/i2c/i2c-boardinfo.c
@@ -12,11 +12,11 @@
* GNU General Public License for more details.
*/
-#include <linux/kernel.h>
-#include <linux/i2c.h>
-#include <linux/slab.h>
#include <linux/export.h>
+#include <linux/i2c.h>
+#include <linux/kernel.h>
#include <linux/rwsem.h>
+#include <linux/slab.h>
#include "i2c-core.h"
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/6] i2c: i2c-core: sort includes
2016-02-20 22:38 [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
2016-02-20 22:38 ` [PATCH 1/6] i2c: i2c-boardinfo: sort includes Wolfram Sang
@ 2016-02-20 22:38 ` Wolfram Sang
2016-02-20 22:38 ` [PATCH 3/6] i2c: i2c-dev: " Wolfram Sang
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2016-02-20 22:38 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang
I request this for drivers, so the core should adhere to sorted includes as
well.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/i2c-core.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index ffe715d346d884..2949ab3c2293ad 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -28,32 +28,32 @@
*/
#include <dt-bindings/i2c/i2c.h>
-#include <linux/module.h>
-#include <linux/kernel.h>
+#include <asm/uaccess.h>
+#include <linux/acpi.h>
+#include <linux/clk/clk-conf.h>
+#include <linux/completion.h>
#include <linux/delay.h>
+#include <linux/err.h>
#include <linux/errno.h>
#include <linux/gpio.h>
-#include <linux/slab.h>
+#include <linux/hardirq.h>
#include <linux/i2c.h>
-#include <linux/init.h>
#include <linux/idr.h>
+#include <linux/init.h>
+#include <linux/irqflags.h>
+#include <linux/jump_label.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/mutex.h>
-#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of.h>
#include <linux/of_irq.h>
-#include <linux/clk/clk-conf.h>
-#include <linux/completion.h>
-#include <linux/hardirq.h>
-#include <linux/irqflags.h>
-#include <linux/rwsem.h>
-#include <linux/pm_runtime.h>
#include <linux/pm_domain.h>
+#include <linux/pm_runtime.h>
#include <linux/pm_wakeirq.h>
-#include <linux/acpi.h>
-#include <linux/jump_label.h>
-#include <asm/uaccess.h>
-#include <linux/err.h>
#include <linux/property.h>
+#include <linux/rwsem.h>
+#include <linux/slab.h>
#include "i2c-core.h"
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/6] i2c: i2c-dev: sort includes
2016-02-20 22:38 [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
2016-02-20 22:38 ` [PATCH 1/6] i2c: i2c-boardinfo: sort includes Wolfram Sang
2016-02-20 22:38 ` [PATCH 2/6] i2c: i2c-core: " Wolfram Sang
@ 2016-02-20 22:38 ` Wolfram Sang
2016-02-20 22:38 ` [PATCH 4/6] i2c: i2c-mux: " Wolfram Sang
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2016-02-20 22:38 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang
I request this for drivers, so the core should adhere to sorted includes as
well.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/i2c-dev.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index 2413ec9f8207ee..0b1108d3c2f397 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c-dev.c
@@ -22,17 +22,17 @@
/* The I2C_RDWR ioctl code is written by Kolja Waschk <waschk@telos.de> */
-#include <linux/kernel.h>
-#include <linux/module.h>
#include <linux/device.h>
-#include <linux/notifier.h>
#include <linux/fs.h>
-#include <linux/slab.h>
-#include <linux/init.h>
-#include <linux/list.h>
-#include <linux/i2c.h>
#include <linux/i2c-dev.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
#include <linux/jiffies.h>
+#include <linux/kernel.h>
+#include <linux/list.h>
+#include <linux/module.h>
+#include <linux/notifier.h>
+#include <linux/slab.h>
#include <linux/uaccess.h>
/*
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/6] i2c: i2c-mux: sort includes
2016-02-20 22:38 [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
` (2 preceding siblings ...)
2016-02-20 22:38 ` [PATCH 3/6] i2c: i2c-dev: " Wolfram Sang
@ 2016-02-20 22:38 ` Wolfram Sang
2016-02-20 22:38 ` [PATCH 5/6] i2c: i2c-smbus: " Wolfram Sang
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2016-02-20 22:38 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang
I request this for drivers, so the core should adhere to sorted includes as
well.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/i2c-mux.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/i2c-mux.c b/drivers/i2c/i2c-mux.c
index 00fc5b1c7b66bb..d4022878b2f0b6 100644
--- a/drivers/i2c/i2c-mux.c
+++ b/drivers/i2c/i2c-mux.c
@@ -19,13 +19,13 @@
* warranty of any kind, whether express or implied.
*/
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/slab.h>
+#include <linux/acpi.h>
#include <linux/i2c.h>
#include <linux/i2c-mux.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/of.h>
-#include <linux/acpi.h>
+#include <linux/slab.h>
/* multiplexer per channel data */
struct i2c_mux_priv {
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 5/6] i2c: i2c-smbus: sort includes
2016-02-20 22:38 [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
` (3 preceding siblings ...)
2016-02-20 22:38 ` [PATCH 4/6] i2c: i2c-mux: " Wolfram Sang
@ 2016-02-20 22:38 ` Wolfram Sang
2016-02-20 22:38 ` [PATCH 6/6] i2c: i2c-stub: " Wolfram Sang
2016-02-24 10:27 ` [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
6 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2016-02-20 22:38 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang
I request this for drivers, so the core should adhere to sorted includes as
well.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/i2c-smbus.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
index 94765a81970d8c..abb55d3e76f33a 100644
--- a/drivers/i2c/i2c-smbus.c
+++ b/drivers/i2c/i2c-smbus.c
@@ -15,14 +15,14 @@
* GNU General Public License for more details.
*/
-#include <linux/kernel.h>
-#include <linux/module.h>
#include <linux/device.h>
-#include <linux/interrupt.h>
-#include <linux/workqueue.h>
#include <linux/i2c.h>
#include <linux/i2c-smbus.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/slab.h>
+#include <linux/workqueue.h>
struct i2c_smbus_alert {
unsigned int alert_edge_triggered:1;
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 6/6] i2c: i2c-stub: sort includes
2016-02-20 22:38 [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
` (4 preceding siblings ...)
2016-02-20 22:38 ` [PATCH 5/6] i2c: i2c-smbus: " Wolfram Sang
@ 2016-02-20 22:38 ` Wolfram Sang
2016-02-24 10:27 ` [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
6 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2016-02-20 22:38 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang
I request this for drivers, so the core should adhere to sorted includes as
well.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/i2c-stub.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/i2c-stub.c b/drivers/i2c/i2c-stub.c
index af2a94e1140ba0..06af583d510150 100644
--- a/drivers/i2c/i2c-stub.c
+++ b/drivers/i2c/i2c-stub.c
@@ -17,13 +17,13 @@
#define DEBUG 1
-#include <linux/init.h>
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/slab.h>
#include <linux/errno.h>
#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
#include <linux/list.h>
+#include <linux/module.h>
+#include <linux/slab.h>
#define MAX_CHIPS 10
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/6] i2c: sort includes for the core
2016-02-20 22:38 [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
` (5 preceding siblings ...)
2016-02-20 22:38 ` [PATCH 6/6] i2c: i2c-stub: " Wolfram Sang
@ 2016-02-24 10:27 ` Wolfram Sang
6 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2016-02-24 10:27 UTC (permalink / raw)
To: linux-i2c
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
On Sat, Feb 20, 2016 at 11:38:45PM +0100, Wolfram Sang wrote:
> If drivers must do it, the core should do it as well: keep the includes sorted
> to make it hard to duplicate entries :)
>
> Plain sorting, nothing has been added or removed.
>
>
> Wolfram Sang (6):
> i2c: i2c-boardinfo: sort includes
> i2c: i2c-core: sort includes
> i2c: i2c-dev: sort includes
> i2c: i2c-mux: sort includes
> i2c: i2c-smbus: sort includes
> i2c: i2c-stub: sort includes
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-24 10:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-20 22:38 [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
2016-02-20 22:38 ` [PATCH 1/6] i2c: i2c-boardinfo: sort includes Wolfram Sang
2016-02-20 22:38 ` [PATCH 2/6] i2c: i2c-core: " Wolfram Sang
2016-02-20 22:38 ` [PATCH 3/6] i2c: i2c-dev: " Wolfram Sang
2016-02-20 22:38 ` [PATCH 4/6] i2c: i2c-mux: " Wolfram Sang
2016-02-20 22:38 ` [PATCH 5/6] i2c: i2c-smbus: " Wolfram Sang
2016-02-20 22:38 ` [PATCH 6/6] i2c: i2c-stub: " Wolfram Sang
2016-02-24 10:27 ` [PATCH 0/6] i2c: sort includes for the core Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.