[PATCH] Staging: gdm72x: Adding spaces before and after '*'

[PATCH] Staging: gdm72x: Adding spaces before and after '*'

[pooja.shamili]

This patch fixes the checkpatch.pl error: Spaces preferred around the
'*'

Signed-off-by: pooja.shamili <poojashamili@gmail.com>
---
 drivers/staging/gdm724x/gdm_mux.h | 4 ++--
 drivers/staging/gdm724x/gdm_usb.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_mux.h b/drivers/staging/gdm724x/gdm_mux.h
index 3d50383..0871b8f 100644
--- a/drivers/staging/gdm724x/gdm_mux.h
+++ b/drivers/staging/gdm724x/gdm_mux.h
@@ -27,8 +27,8 @@
 
 #define START_FLAG 0xA512485A
 #define MUX_HEADER_SIZE 14
-#define MUX_TX_MAX_SIZE (1024*10)
-#define MUX_RX_MAX_SIZE (1024*30)
+#define MUX_TX_MAX_SIZE (1024 * 10)
+#define MUX_RX_MAX_SIZE (1024 * 30)
 #define AT_PKT_TYPE 0xF011
 #define DM_PKT_TYPE 0xF010
 
diff --git a/drivers/staging/gdm724x/gdm_usb.h b/drivers/staging/gdm724x/gdm_usb.h
index e6486e7..ffb3d99 100644
--- a/drivers/staging/gdm724x/gdm_usb.h
+++ b/drivers/staging/gdm724x/gdm_usb.h
@@ -26,10 +26,10 @@
 #define PM_SUSPEND 1
 #define AUTO_SUSPEND_TIMER 5000 /* ms */
 
-#define RX_BUF_SIZE		(1024*32)
-#define TX_BUF_SIZE		(1024*32)
+#define RX_BUF_SIZE		(1024 * 32)
+#define TX_BUF_SIZE		(1024 * 32)
 #define SDU_BUF_SIZE	2048
-#define MAX_SDU_SIZE	(1024*30)
+#define MAX_SDU_SIZE	(1024 * 30)
 #define MAX_PACKET_IN_MULTI_SDU	256
 
 #define VID_GCT			0x1076
-- 
2.1.4

Re: [Outreachy kernel] [PATCH] Staging: gdm72x: Adding spaces before and after '*'

[Julia Lawall]

On Thu, 25 Feb 2016, pooja.shamili wrote:

> This patch fixes the checkpatch.pl error: Spaces preferred around the
> '*'

It is better to write the commit message in the imperative.  This tends to
be more concise, while also making it clear what is done. See
http://kernelnewbies.org/PatchPhilosophy

In this case, you donn't have much to say, so perhaps the current commit
message is OK.  But in the subject, it would be better to say "Add" rather
than "Adding".

julia

>
> Signed-off-by: pooja.shamili <poojashamili@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_mux.h | 4 ++--
>  drivers/staging/gdm724x/gdm_usb.h | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_mux.h b/drivers/staging/gdm724x/gdm_mux.h
> index 3d50383..0871b8f 100644
> --- a/drivers/staging/gdm724x/gdm_mux.h
> +++ b/drivers/staging/gdm724x/gdm_mux.h
> @@ -27,8 +27,8 @@
>
>  #define START_FLAG 0xA512485A
>  #define MUX_HEADER_SIZE 14
> -#define MUX_TX_MAX_SIZE (1024*10)
> -#define MUX_RX_MAX_SIZE (1024*30)
> +#define MUX_TX_MAX_SIZE (1024 * 10)
> +#define MUX_RX_MAX_SIZE (1024 * 30)
>  #define AT_PKT_TYPE 0xF011
>  #define DM_PKT_TYPE 0xF010
>
> diff --git a/drivers/staging/gdm724x/gdm_usb.h b/drivers/staging/gdm724x/gdm_usb.h
> index e6486e7..ffb3d99 100644
> --- a/drivers/staging/gdm724x/gdm_usb.h
> +++ b/drivers/staging/gdm724x/gdm_usb.h
> @@ -26,10 +26,10 @@
>  #define PM_SUSPEND 1
>  #define AUTO_SUSPEND_TIMER 5000 /* ms */
>
> -#define RX_BUF_SIZE		(1024*32)
> -#define TX_BUF_SIZE		(1024*32)
> +#define RX_BUF_SIZE		(1024 * 32)
> +#define TX_BUF_SIZE		(1024 * 32)
>  #define SDU_BUF_SIZE	2048
> -#define MAX_SDU_SIZE	(1024*30)
> +#define MAX_SDU_SIZE	(1024 * 30)
>  #define MAX_PACKET_IN_MULTI_SDU	256
>
>  #define VID_GCT			0x1076
> --
> 2.1.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160225103007.GA702%40localhost.
> For more options, visit https://groups.google.com/d/optout.
>