All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] Staging: gdm72x: Add spaces before and after '*'
@ 2016-02-25 16:01 pooja.shamili
  2016-03-05 22:47 ` [Outreachy kernel] " Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: pooja.shamili @ 2016-02-25 16:01 UTC (permalink / raw)
  To: outreachy-kernel

This patch fixes the checkpatch.pl error:
CHECK: spaces preferred around that '*'

Signed-off-by: pooja.shamili <poojashamili@gmail.com>
---

Changes since v1:
	* Changed the commit message to the present tense

 drivers/staging/gdm724x/gdm_mux.h | 4 ++--
 drivers/staging/gdm724x/gdm_usb.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_mux.h b/drivers/staging/gdm724x/gdm_mux.h
index 3d50383..0871b8f 100644
--- a/drivers/staging/gdm724x/gdm_mux.h
+++ b/drivers/staging/gdm724x/gdm_mux.h
@@ -27,8 +27,8 @@
 
 #define START_FLAG 0xA512485A
 #define MUX_HEADER_SIZE 14
-#define MUX_TX_MAX_SIZE (1024*10)
-#define MUX_RX_MAX_SIZE (1024*30)
+#define MUX_TX_MAX_SIZE (1024 * 10)
+#define MUX_RX_MAX_SIZE (1024 * 30)
 #define AT_PKT_TYPE 0xF011
 #define DM_PKT_TYPE 0xF010
 
diff --git a/drivers/staging/gdm724x/gdm_usb.h b/drivers/staging/gdm724x/gdm_usb.h
index e6486e7..ffb3d99 100644
--- a/drivers/staging/gdm724x/gdm_usb.h
+++ b/drivers/staging/gdm724x/gdm_usb.h
@@ -26,10 +26,10 @@
 #define PM_SUSPEND 1
 #define AUTO_SUSPEND_TIMER 5000 /* ms */
 
-#define RX_BUF_SIZE		(1024*32)
-#define TX_BUF_SIZE		(1024*32)
+#define RX_BUF_SIZE		(1024 * 32)
+#define TX_BUF_SIZE		(1024 * 32)
 #define SDU_BUF_SIZE	2048
-#define MAX_SDU_SIZE	(1024*30)
+#define MAX_SDU_SIZE	(1024 * 30)
 #define MAX_PACKET_IN_MULTI_SDU	256
 
 #define VID_GCT			0x1076
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH v2] Staging: gdm72x: Add spaces before and after '*'
  2016-02-25 16:01 [PATCH v2] Staging: gdm72x: Add spaces before and after '*' pooja.shamili
@ 2016-03-05 22:47 ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-03-05 22:47 UTC (permalink / raw)
  To: pooja.shamili; +Cc: outreachy-kernel

On Thu, Feb 25, 2016 at 09:31:30PM +0530, pooja.shamili wrote:
> This patch fixes the checkpatch.pl error:
> CHECK: spaces preferred around that '*'
> 
> Signed-off-by: pooja.shamili <poojashamili@gmail.com>

We need a full name here, and in your From: line, not a username with a
'.' in it, as I doubt that is how you sign paperwork :)

I'm going to go drop this from my tree, as I shouldn't have accepted it.
Please resend all of your patches that you did this with so that they
can be properly accepted.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] Staging: gdm72x: Add spaces before and after '*'
@ 2016-03-06  9:09 G Pooja Shamili
  0 siblings, 0 replies; 3+ messages in thread
From: G Pooja Shamili @ 2016-03-06  9:09 UTC (permalink / raw)
  To: outreachy-kernel

This patch fixes the checkpatch.pl error:
CHECK: spaces preferred around that '*'

Signed-off-by: G Pooja Shamili <poojashamili@gmail.com>
---
Changes from Version 1:
	* Changed the name in the From: and Signed-off-by: to full name.
	
 drivers/staging/gdm724x/gdm_mux.h | 4 ++--
 drivers/staging/gdm724x/gdm_usb.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_mux.h b/drivers/staging/gdm724x/gdm_mux.h
index 3d50383..0871b8f 100644
--- a/drivers/staging/gdm724x/gdm_mux.h
+++ b/drivers/staging/gdm724x/gdm_mux.h
@@ -27,8 +27,8 @@
 
 #define START_FLAG 0xA512485A
 #define MUX_HEADER_SIZE 14
-#define MUX_TX_MAX_SIZE (1024*10)
-#define MUX_RX_MAX_SIZE (1024*30)
+#define MUX_TX_MAX_SIZE (1024 * 10)
+#define MUX_RX_MAX_SIZE (1024 * 30)
 #define AT_PKT_TYPE 0xF011
 #define DM_PKT_TYPE 0xF010
 
diff --git a/drivers/staging/gdm724x/gdm_usb.h b/drivers/staging/gdm724x/gdm_usb.h
index e6486e7..ffb3d99 100644
--- a/drivers/staging/gdm724x/gdm_usb.h
+++ b/drivers/staging/gdm724x/gdm_usb.h
@@ -26,10 +26,10 @@
 #define PM_SUSPEND 1
 #define AUTO_SUSPEND_TIMER 5000 /* ms */
 
-#define RX_BUF_SIZE		(1024*32)
-#define TX_BUF_SIZE		(1024*32)
+#define RX_BUF_SIZE		(1024 * 32)
+#define TX_BUF_SIZE		(1024 * 32)
 #define SDU_BUF_SIZE	2048
-#define MAX_SDU_SIZE	(1024*30)
+#define MAX_SDU_SIZE	(1024 * 30)
 #define MAX_PACKET_IN_MULTI_SDU	256
 
 #define VID_GCT			0x1076
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-06  9:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-25 16:01 [PATCH v2] Staging: gdm72x: Add spaces before and after '*' pooja.shamili
2016-03-05 22:47 ` [Outreachy kernel] " Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2016-03-06  9:09 G Pooja Shamili

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.