All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: meng.yi@nxp.com, linux@arm.linux.org.uk, eric@eukrea.com,
	alison.wang@freescale.com, daniel.vetter@ffwll.ch,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	denis@eukrea.com
Subject: Re: [PATCH v2 1/3] drm/fsl-dcu: use mode flags for hsync/vsync polarity
Date: Thu, 25 Feb 2016 17:48:27 +0100	[thread overview]
Message-ID: <20160225164827.GA6720@ulmo.nvidia.com> (raw)
In-Reply-To: <1454968663-30066-2-git-send-email-stefan@agner.ch>


[-- Attachment #1.1: Type: text/plain, Size: 1084 bytes --]

On Mon, Feb 08, 2016 at 01:57:41PM -0800, Stefan Agner wrote:
> The current default configuration is as follows:
> - Invert VSYNC signal (active LOW)
> - Invert HSYNC signal (active LOW)
> 
> The mode flags allow to specify the required polarity per
> mode. Furthermore, none of the current driver settings is
> actually a standard polarity.
> 
> This patch applies the current driver default polarities as
> explicit flags to the display which has been introduced with
> the driver (NEC WQVGA "nec,nl4827hc19-05b"). The driver now
> also parses the flags field and applies the configuration
> accordingly, by using the following values as standard
> polarities: (e.g. when no flags are specified):
> - VSYNC signal not inverted (active HIGH)
> - HSYNC signal not inverted (active HIGH)
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 11 ++++++++---
>  drivers/gpu/drm/panel/panel-simple.c       |  1 +
>  2 files changed, 9 insertions(+), 3 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie,
	daniel.vetter@ffwll.ch, jianwei.wang.chn@gmail.com,
	alison.wang@freescale.com, meng.yi@nxp.com,
	linux@arm.linux.org.uk, p.zabel@pengutronix.de, denis@eukrea.com,
	eric@eukrea.com, ville.syrjala@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] drm/fsl-dcu: use mode flags for hsync/vsync polarity
Date: Thu, 25 Feb 2016 17:48:27 +0100	[thread overview]
Message-ID: <20160225164827.GA6720@ulmo.nvidia.com> (raw)
In-Reply-To: <1454968663-30066-2-git-send-email-stefan@agner.ch>

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On Mon, Feb 08, 2016 at 01:57:41PM -0800, Stefan Agner wrote:
> The current default configuration is as follows:
> - Invert VSYNC signal (active LOW)
> - Invert HSYNC signal (active LOW)
> 
> The mode flags allow to specify the required polarity per
> mode. Furthermore, none of the current driver settings is
> actually a standard polarity.
> 
> This patch applies the current driver default polarities as
> explicit flags to the display which has been introduced with
> the driver (NEC WQVGA "nec,nl4827hc19-05b"). The driver now
> also parses the flags field and applies the configuration
> accordingly, by using the following values as standard
> polarities: (e.g. when no flags are specified):
> - VSYNC signal not inverted (active HIGH)
> - HSYNC signal not inverted (active HIGH)
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 11 ++++++++---
>  drivers/gpu/drm/panel/panel-simple.c       |  1 +
>  2 files changed, 9 insertions(+), 3 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-02-25 16:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 21:57 [PATCH v2 0/3] drm: introduce bus_flags for pixel clock polarity Stefan Agner
2016-02-08 21:57 ` Stefan Agner
2016-02-08 21:57 ` [PATCH v2 1/3] drm/fsl-dcu: use mode flags for hsync/vsync polarity Stefan Agner
2016-02-08 21:57   ` Stefan Agner
2016-02-25 16:48   ` Thierry Reding [this message]
2016-02-25 16:48     ` Thierry Reding
2016-02-25 23:55   ` Stefan Agner
2016-02-25 23:55     ` Stefan Agner
2016-02-08 21:57 ` [PATCH v2 2/3] drm: introduce bus_flags in drm_display_info Stefan Agner
2016-02-08 21:57   ` Stefan Agner
2016-02-08 21:57 ` [PATCH v2 3/3] drm/fsl-dcu: use bus_flags for pixel clock polarity Stefan Agner
2016-02-08 21:57   ` Stefan Agner
2016-02-23 23:30 ` [PATCH v2 0/3] drm: introduce " Stefan Agner
2016-02-23 23:30   ` Stefan Agner
2016-02-24 10:28   ` Philipp Zabel
2016-02-25  7:59     ` Manfred Schlaegl
2016-02-25  7:59       ` Manfred Schlaegl
2016-02-24 11:06   ` Tomi Valkeinen
2016-02-24 11:06     ` Tomi Valkeinen
2016-02-24 19:02     ` Stefan Agner
2016-02-24 19:02       ` Stefan Agner
2016-02-24 20:17     ` Ville Syrjälä
2016-02-24 20:17       ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160225164827.GA6720@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=alison.wang@freescale.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=denis@eukrea.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@eukrea.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=meng.yi@nxp.com \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.