Re: [PATCH] clk: sunxi: allow PLL6 clock to be reused

[Maxime Ripard <maxime.ripard@free-electrons.com>]

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

On Mon, Feb 22, 2016 at 09:38:53AM +0000, Andre Przywara wrote:
> >> diff --git a/drivers/clk/sunxi/clk-factors.h b/drivers/clk/sunxi/clk-factors.h
> >> index 1e63c5b..3a7da86 100644
> >> --- a/drivers/clk/sunxi/clk-factors.h
> >> +++ b/drivers/clk/sunxi/clk-factors.h
> >> @@ -36,6 +36,7 @@ struct factors_data {
> >>         void (*getter)(struct factors_request *req);
> >>         void (*recalc)(struct factors_request *req);
> >>         const char *name;
> >> +       int name_idx;
> > 
> > I would drop the .name field. It was a bad workaround
> > due to limitations of the factors clk code at the time
> > by me. We really shouldn't hard-code the name if we want
> > to reuse the driver.
> 
> I know what you mean (my first thought, too) and I totally agree, but we
> need it still for PLL5, which does not carry the original name in the DT
> output names.
> So at least this workaround here does not work, I guess we have to come
> up with something different - which would be a different patch.
> I can take a look into this later.

Actually, it could be easily worked around. Always take the first
clock output name, take whatever is before '_', and you can remove the
name field entirely.

Jens did something along these lines here:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/379900.html

Maybe we should simply rebase this patch, and remove the part that
falls back on the name field.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]