From: Greg KH <gregkh@linuxfoundation.org>
To: Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH v2] staging: lustre: lustre: obdclass: Remove unneeded NULL check
Date: Fri, 26 Feb 2016 06:16:32 +0000 [thread overview]
Message-ID: <20160226061631.GC21950@kroah.com> (raw)
In-Reply-To: <20160221195037.GA29036@janani-Inspiron-3521>
On Sun, Feb 21, 2016 at 02:50:37PM -0500, Janani Ravichandran wrote:
> Remove unneeded NULL check before debugfs_remove_recursive.
> Generated-by: scripts/coccinelle/free/ifnullfree.cocci
>
> Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
> ---
> drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> index 1913f3e..2045621 100644
> --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> @@ -454,8 +454,7 @@ out:
>
> int class_procfs_clean(void)
> {
> - if (debugfs_lustre_root != NULL)
> - debugfs_remove_recursive(debugfs_lustre_root);
> + debugfs_remove_recursive(debugfs_lustre_root);
>
> debugfs_lustre_root = NULL;
>
Doesn't apply to the tree :(
prev parent reply other threads:[~2016-02-26 6:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 19:50 [PATCH v2] staging: lustre: lustre: obdclass: Remove unneeded NULL check Janani Ravichandran
2016-02-26 6:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226061631.GC21950@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=janani.rvchndrn@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.