From: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
To: "Simmons, James A." <simmonsja@ornl.gov>
Cc: "Drokin, Oleg" <oleg.drokin@intel.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo data
Date: Fri, 26 Feb 2016 16:18:18 +0000 [thread overview]
Message-ID: <20160226161818.GA12212@kroah.com> (raw)
In-Reply-To: <3d8510f665034cd1a28eee812d572736@EXCHCS32.ornl.gov>
On Fri, Feb 26, 2016 at 03:46:02PM +0000, Simmons, James A. wrote:
> >On Fri, Feb 26, 2016 at 06:11:07AM +0000, Drokin, Oleg wrote:
> >>
> >> On Feb 26, 2016, at 1:03 AM, Greg Kroah-Hartman wrote:
> >>
> >> > On Thu, Feb 25, 2016 at 08:07:06PM -0500, James Simmons wrote:
> >> >> The module information for Lustre is stale or in some cases
> >> >> completely missing. This collection of patches brings the
> >> >> modinfo up to date as well as filling in any missing information.
> >> >> This patch set has been redone to rebase it on Oleg's latest
> >> >> patch set to avoid collisons in merging.
> >> >>
> >> >> Andreas Dilger (4):
> >> >> staging: lustre: add missing MODULE_AUTHOR for LNet selftest module
> >> >> staging: lustre: update the MODULE_DESCRIPTION for all lustre modules
> >> >> staging: lustre: make module_init/exit naming consistent
> >> >> staging: lustre: update comment for lnet_lib_init/exit
> >> >>
> >> >> James Simmons (2):
> >> >> staging: lustre: move module info to end of libcfs module.c file
> >> >> staging: lustre: update the MODULE_VERSION for all lustre modules
> >> >
> >> > What changed to need a v2 of this series?
> >> >
> >> > Please ALWAYS say what the difference is, don't expect us to "just
> >> > know".
> >> >
> >> > Please send a v3 of this, describing the changes, in the correct format,
> >> > in each patch. You know better than this?
> >>
> >> I think it says above that the rebase was done on top of my patchset
> >> to resolve the conflict that arose?
> >
> >Where? Ugh, yeah, kind of, but where is the big v2: marking or some
> >such thing like is required? It's very easy to miss this (as I did.)
> >Please make it easy for maintainers, not hard on them...
>
> Sorry, in the future I will add a ChangeLog section for newer versions of patches.
> The good news is the patches from Oleg's that conflicted landed already which
> means the this patch set is ready to land.
Can you please resend it with the proper format? It's out of my queue
now...
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
To: "Simmons, James A." <simmonsja@ornl.gov>
Cc: "Drokin, Oleg" <oleg.drokin@intel.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo data
Date: Fri, 26 Feb 2016 16:18:19 +0000 [thread overview]
Message-ID: <20160226161818.GA12212@kroah.com> (raw)
In-Reply-To: <3d8510f665034cd1a28eee812d572736@EXCHCS32.ornl.gov>
On Fri, Feb 26, 2016 at 03:46:02PM +0000, Simmons, James A. wrote:
> >On Fri, Feb 26, 2016 at 06:11:07AM +0000, Drokin, Oleg wrote:
> >>
> >> On Feb 26, 2016, at 1:03 AM, Greg Kroah-Hartman wrote:
> >>
> >> > On Thu, Feb 25, 2016 at 08:07:06PM -0500, James Simmons wrote:
> >> >> The module information for Lustre is stale or in some cases
> >> >> completely missing. This collection of patches brings the
> >> >> modinfo up to date as well as filling in any missing information.
> >> >> This patch set has been redone to rebase it on Oleg's latest
> >> >> patch set to avoid collisons in merging.
> >> >>
> >> >> Andreas Dilger (4):
> >> >> staging: lustre: add missing MODULE_AUTHOR for LNet selftest module
> >> >> staging: lustre: update the MODULE_DESCRIPTION for all lustre modules
> >> >> staging: lustre: make module_init/exit naming consistent
> >> >> staging: lustre: update comment for lnet_lib_init/exit
> >> >>
> >> >> James Simmons (2):
> >> >> staging: lustre: move module info to end of libcfs module.c file
> >> >> staging: lustre: update the MODULE_VERSION for all lustre modules
> >> >
> >> > What changed to need a v2 of this series?
> >> >
> >> > Please ALWAYS say what the difference is, don't expect us to "just
> >> > know".
> >> >
> >> > Please send a v3 of this, describing the changes, in the correct format,
> >> > in each patch. You know better than this…
> >>
> >> I think it says above that the rebase was done on top of my patchset
> >> to resolve the conflict that arose?
> >
> >Where? Ugh, yeah, kind of, but where is the big v2: marking or some
> >such thing like is required? It's very easy to miss this (as I did.)
> >Please make it easy for maintainers, not hard on them...
>
> Sorry, in the future I will add a ChangeLog section for newer versions of patches.
> The good news is the patches from Oleg's that conflicted landed already which
> means the this patch set is ready to land.
Can you please resend it with the proper format? It's out of my queue
now...
thanks,
greg k-h
next prev parent reply other threads:[~2016-02-26 16:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 1:07 [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo data James Simmons
2016-02-26 1:07 ` James Simmons
2016-02-26 1:07 ` [lustre-devel] [PATCH v2 1/6] staging: lustre: move module info to end of libcfs module.c file James Simmons
2016-02-26 1:07 ` James Simmons
2016-02-26 1:07 ` [lustre-devel] [PATCH v2 2/6] staging: lustre: add missing MODULE_AUTHOR for LNet selftest module James Simmons
2016-02-26 1:07 ` James Simmons
2016-02-26 1:07 ` [lustre-devel] [PATCH v2 3/6] staging: lustre: update the MODULE_VERSION for all lustre modules James Simmons
2016-02-26 1:07 ` James Simmons
2016-02-26 1:07 ` [lustre-devel] [PATCH v2 4/6] staging: lustre: update the MODULE_DESCRIPTION " James Simmons
2016-02-26 1:07 ` James Simmons
2016-02-26 1:07 ` [lustre-devel] [PATCH v2 5/6] staging: lustre: make module_init/exit naming consistent James Simmons
2016-02-26 1:07 ` James Simmons
2016-02-26 1:07 ` [lustre-devel] [PATCH v2 6/6] staging: lustre: update comment for lnet_lib_init/exit James Simmons
2016-02-26 1:07 ` James Simmons
2016-02-26 6:03 ` [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo data Greg Kroah-Hartman
2016-02-26 6:03 ` Greg Kroah-Hartman
2016-02-26 6:11 ` [lustre-devel] " Drokin, Oleg
2016-02-26 6:11 ` Drokin, Oleg
2016-02-26 6:25 ` Greg Kroah-Hartman
2016-02-26 6:25 ` Greg Kroah-Hartman
2016-02-26 15:46 ` Simmons, James A.
2016-02-26 15:46 ` Simmons, James A.
2016-02-26 16:18 ` 'Greg Kroah-Hartman' [this message]
2016-02-26 16:18 ` 'Greg Kroah-Hartman'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226161818.GA12212@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
--cc=simmonsja@ornl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.