* [patch 1/2] [media] tvp5150: off by one
@ 2016-02-27 10:51 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-02-27 10:51 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Javier Martinez Canillas
Cc: Laurent Pinchart, Hans Verkuil, Guennadi Liakhovetski,
linux-media, linux-kernel, kernel-janitors
The ->input_ent[] array has TVP5150_INPUT_NUM elements so the > here
should be >=.
Fixes: f7b4b54e6364 ('[media] tvp5150: add HW input connectors support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index ef393f5..ff18444 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -1386,7 +1386,7 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np)
goto err_connector;
}
- if (input_type > TVP5150_INPUT_NUM) {
+ if (input_type >= TVP5150_INPUT_NUM) {
ret = -EINVAL;
goto err_connector;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch 1/2] [media] tvp5150: off by one
@ 2016-02-27 10:51 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-02-27 10:51 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Javier Martinez Canillas
Cc: Laurent Pinchart, Hans Verkuil, Guennadi Liakhovetski,
linux-media, linux-kernel, kernel-janitors
The ->input_ent[] array has TVP5150_INPUT_NUM elements so the > here
should be >=.
Fixes: f7b4b54e6364 ('[media] tvp5150: add HW input connectors support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index ef393f5..ff18444 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -1386,7 +1386,7 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np)
goto err_connector;
}
- if (input_type > TVP5150_INPUT_NUM) {
+ if (input_type >= TVP5150_INPUT_NUM) {
ret = -EINVAL;
goto err_connector;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch 1/2] [media] tvp5150: off by one
2016-02-27 10:51 ` Dan Carpenter
@ 2016-02-27 10:55 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-02-27 10:55 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Javier Martinez Canillas
Cc: Laurent Pinchart, Hans Verkuil, Guennadi Liakhovetski,
linux-media, linux-kernel, kernel-janitors
Oh... There is no [patch 2/2]. I decided to report that one instead.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 1/2] [media] tvp5150: off by one
@ 2016-02-27 10:55 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-02-27 10:55 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Javier Martinez Canillas
Cc: Laurent Pinchart, Hans Verkuil, Guennadi Liakhovetski,
linux-media, linux-kernel, kernel-janitors
Oh... There is no [patch 2/2]. I decided to report that one instead.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 1/2] [media] tvp5150: off by one
2016-02-27 10:51 ` Dan Carpenter
@ 2016-02-28 14:43 ` Javier Martinez Canillas
-1 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-02-28 14:43 UTC (permalink / raw)
To: Dan Carpenter, Mauro Carvalho Chehab
Cc: Laurent Pinchart, Hans Verkuil, Guennadi Liakhovetski,
linux-media, linux-kernel, kernel-janitors
Hello Dan,
On 02/27/2016 07:51 AM, Dan Carpenter wrote:
> The ->input_ent[] array has TVP5150_INPUT_NUM elements so the > here
> should be >=.
>
> Fixes: f7b4b54e6364 ('[media] tvp5150: add HW input connectors support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Thanks for the patch but Mauro already posted the same change before:
http://www.spinics.net/lists/linux-media/msg97721.html
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 1/2] [media] tvp5150: off by one
@ 2016-02-28 14:43 ` Javier Martinez Canillas
0 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-02-28 14:43 UTC (permalink / raw)
To: Dan Carpenter, Mauro Carvalho Chehab
Cc: Laurent Pinchart, Hans Verkuil, Guennadi Liakhovetski,
linux-media, linux-kernel, kernel-janitors
Hello Dan,
On 02/27/2016 07:51 AM, Dan Carpenter wrote:
> The ->input_ent[] array has TVP5150_INPUT_NUM elements so the > here
> should be >=.
>
> Fixes: f7b4b54e6364 ('[media] tvp5150: add HW input connectors support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Thanks for the patch but Mauro already posted the same change before:
http://www.spinics.net/lists/linux-media/msg97721.html
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-28 14:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-27 10:51 [patch 1/2] [media] tvp5150: off by one Dan Carpenter
2016-02-27 10:51 ` Dan Carpenter
2016-02-27 10:55 ` Dan Carpenter
2016-02-27 10:55 ` Dan Carpenter
2016-02-28 14:43 ` Javier Martinez Canillas
2016-02-28 14:43 ` Javier Martinez Canillas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.