From: Borislav Petkov <bp@alien8.de>
To: Chris Bainbridge <chris.bainbridge@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode: Change checksum to u32
Date: Sat, 27 Feb 2016 23:29:28 +0100 [thread overview]
Message-ID: <20160227222928.GD5261@pd.tnic> (raw)
In-Reply-To: <20160227182329.GA4947@localhost>
On Sat, Feb 27, 2016 at 06:23:29PM +0000, Chris Bainbridge wrote:
> /* calculate the checksum */
> orig_sum = 0;
> i = (MC_HEADER_SIZE + data_size) / DWSIZE;
> while (i--)
> orig_sum += ((int *)mc)[i];
Ok, since SDM says that all fields should be treated as unsigneds when
doing the checksum verification, that cast above should be (u32 *) too.
Also, the extended table signature should be fixed to use u32s too:
ext_tablep = (int *)ext_header;
i = ext_table_size / sizeof(u32);
while (i--)
ext_table_sum += ext_tablep[i];
...
Care to complete your patch please?
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-02-27 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 11:01 [PATCH] x86/microcode: Change checksum to u32 Chris Bainbridge
2016-02-27 17:51 ` Borislav Petkov
2016-02-27 18:23 ` Chris Bainbridge
2016-02-27 19:44 ` Henrique de Moraes Holschuh
2016-02-27 22:29 ` Borislav Petkov [this message]
2016-02-27 20:12 ` Henrique de Moraes Holschuh
2016-03-16 10:52 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160227222928.GD5261@pd.tnic \
--to=bp@alien8.de \
--cc=chris.bainbridge@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.