All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] Staging: slicoss: Use ether_addr_equal_64bits() insted of ether_addr_equal().
@ 2016-02-28 11:49 Sandhya Bankar
  2016-02-28 19:52 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Sandhya Bankar @ 2016-02-28 11:49 UTC (permalink / raw)
  To: outreachy-kernel

Use ether_addr_equal_64bits() insted of ether_addr_equal().

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/slicoss/slicoss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index ed1c067..b2a162a 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -773,8 +773,8 @@ static bool slic_mac_filter(struct adapter *adapter,
 			struct mcast_address *mcaddr = adapter->mcastaddrs;
 
 			while (mcaddr) {
-				if (ether_addr_equal(mcaddr->address,
-						     ether_frame->ether_dhost)) {
+				if (ether_addr_equal_64bits(mcaddr->address,
+						ether_frame->ether_dhost)) {
 					adapter->rcv_multicasts++;
 					netdev->stats.multicast++;
 					return true;
-- 
1.8.3.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH 1/2] Staging: slicoss: Use ether_addr_equal_64bits() insted of ether_addr_equal().
  2016-02-28 11:49 [PATCH 1/2] Staging: slicoss: Use ether_addr_equal_64bits() insted of ether_addr_equal() Sandhya Bankar
@ 2016-02-28 19:52 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-02-28 19:52 UTC (permalink / raw)
  To: Sandhya Bankar; +Cc: outreachy-kernel

On Sun, 28 Feb 2016, Sandhya Bankar wrote:

> Use ether_addr_equal_64bits() insted of ether_addr_equal().

Explain why this is correct and a good idea.

julia

> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/slicoss/slicoss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index ed1c067..b2a162a 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -773,8 +773,8 @@ static bool slic_mac_filter(struct adapter *adapter,
>  			struct mcast_address *mcaddr = adapter->mcastaddrs;
>  
>  			while (mcaddr) {
> -				if (ether_addr_equal(mcaddr->address,
> -						     ether_frame->ether_dhost)) {
> +				if (ether_addr_equal_64bits(mcaddr->address,
> +						ether_frame->ether_dhost)) {
>  					adapter->rcv_multicasts++;
>  					netdev->stats.multicast++;
>  					return true;
> -- 
> 1.8.3.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160228114943.GA4709%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-28 19:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-28 11:49 [PATCH 1/2] Staging: slicoss: Use ether_addr_equal_64bits() insted of ether_addr_equal() Sandhya Bankar
2016-02-28 19:52 ` [Outreachy kernel] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.