[PATCH 2/2] Staging: rtl8192e: Use ether_addr_equal_64bits() instead of ether_addr_equal().

[PATCH 2/2] Staging: rtl8192e: Use ether_addr_equal_64bits() instead of ether_addr_equal().

[Sandhya Bankar]

Use ether_addr_equal_64bits() instead of ether_addr_equal().

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 25b5b5e..07514e8 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1837,8 +1837,9 @@ static short probe_rq_parse(struct rtllib_device *ieee, struct sk_buff *skb,
 		return -1; /* corrupted */
 
 	bssid_match =
-	  (!ether_addr_equal(header->addr3, ieee->current_network.bssid)) &&
-	  (!is_broadcast_ether_addr(header->addr3));
+	  (!ether_addr_equal_64bits(header->addr3,
+		ieee->current_network.bssid)) &&
+		(!is_broadcast_ether_addr(header->addr3));
 	if (bssid_match)
 		return -1;
 
-- 
1.8.3.4

Re: [Outreachy kernel] [PATCH 2/2] Staging: rtl8192e: Use ether_addr_equal_64bits() instead of ether_addr_equal().

[Julia Lawall]

On Sun, 28 Feb 2016, Sandhya Bankar wrote:

> Use ether_addr_equal_64bits() instead of ether_addr_equal().

Again, explain why it is correct and a good idea.

julia

> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_softmac.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 25b5b5e..07514e8 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1837,8 +1837,9 @@ static short probe_rq_parse(struct rtllib_device *ieee, struct sk_buff *skb,
>  		return -1; /* corrupted */
>  
>  	bssid_match =
> -	  (!ether_addr_equal(header->addr3, ieee->current_network.bssid)) &&
> -	  (!is_broadcast_ether_addr(header->addr3));
> +	  (!ether_addr_equal_64bits(header->addr3,
> +		ieee->current_network.bssid)) &&
> +		(!is_broadcast_ether_addr(header->addr3));
>  	if (bssid_match)
>  		return -1;
>  
> -- 
> 1.8.3.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160228115215.GA4726%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>