From: Tony Lindgren <tony@atomide.com>
To: Franklin S Cooper Jr <fcooper@ti.com>
Cc: paul@pwsan.com, t-kristo@ti.com, vigneshr@ti.com,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS
Date: Mon, 29 Feb 2016 15:23:48 -0800 [thread overview]
Message-ID: <20160229232348.GV13417@atomide.com> (raw)
In-Reply-To: <1456439796-28546-4-git-send-email-fcooper@ti.com>
* Franklin S Cooper Jr <fcooper@ti.com> [160225 14:37]:
> From: Vignesh R <vigneshr@ti.com>
>
> tbclk is used by ehrpwm to generate PWM waveform on DRA7 SoC. Add Linux
> clock to control ehrpwm tbclk.
> The TRM says, tbclk is derived from SYSCLKOUT. SYSCLKOUT is nothing but
> ehrpwm functional clock derived from the gateable interface and
> functional clock of PWMSS(l4_root_clk_div).
> Refer AM57x TRM SPRUHZ6[1], October 2014, Table 29-4 and Section 29.2.2.1,
> Table 29-19 and the NOTE at the end of the table.
>
> [1] www.ti.com/lit/ug/spruhz6/spruhz6.pdf
Applying this into omap-for-v4.6/dt thanks.
Note for Tero, let's plan on getting rid of the duplicate
reg entries by using the standard clock output offset within
the clock register. I think we should easily be able to add
a binding for this and then deprecate the overlapping reg
entries.
Regards,
Tony
> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> @@ -2146,4 +2146,28 @@
> ti,bit-shift = <0>;
> reg = <0x558>;
> };
> +
> + ehrpwm0_tbclk: ehrpwm0_tbclk {
> + #clock-cells = <0>;
> + compatible = "ti,gate-clock";
> + clocks = <&l4_root_clk_div>;
> + ti,bit-shift = <20>;
> + reg = <0x0558>;
> + };
> +
> + ehrpwm1_tbclk: ehrpwm1_tbclk {
> + #clock-cells = <0>;
> + compatible = "ti,gate-clock";
> + clocks = <&l4_root_clk_div>;
> + ti,bit-shift = <21>;
> + reg = <0x0558>;
> + };
> +
> + ehrpwm2_tbclk: ehrpwm2_tbclk {
> + #clock-cells = <0>;
> + compatible = "ti,gate-clock";
> + clocks = <&l4_root_clk_div>;
> + ti,bit-shift = <22>;
> + reg = <0x0558>;
> + };
> };
> --
> 2.7.0
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS
Date: Mon, 29 Feb 2016 15:23:48 -0800 [thread overview]
Message-ID: <20160229232348.GV13417@atomide.com> (raw)
In-Reply-To: <1456439796-28546-4-git-send-email-fcooper@ti.com>
* Franklin S Cooper Jr <fcooper@ti.com> [160225 14:37]:
> From: Vignesh R <vigneshr@ti.com>
>
> tbclk is used by ehrpwm to generate PWM waveform on DRA7 SoC. Add Linux
> clock to control ehrpwm tbclk.
> The TRM says, tbclk is derived from SYSCLKOUT. SYSCLKOUT is nothing but
> ehrpwm functional clock derived from the gateable interface and
> functional clock of PWMSS(l4_root_clk_div).
> Refer AM57x TRM SPRUHZ6[1], October 2014, Table 29-4 and Section 29.2.2.1,
> Table 29-19 and the NOTE at the end of the table.
>
> [1] www.ti.com/lit/ug/spruhz6/spruhz6.pdf
Applying this into omap-for-v4.6/dt thanks.
Note for Tero, let's plan on getting rid of the duplicate
reg entries by using the standard clock output offset within
the clock register. I think we should easily be able to add
a binding for this and then deprecate the overlapping reg
entries.
Regards,
Tony
> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> @@ -2146,4 +2146,28 @@
> ti,bit-shift = <0>;
> reg = <0x558>;
> };
> +
> + ehrpwm0_tbclk: ehrpwm0_tbclk {
> + #clock-cells = <0>;
> + compatible = "ti,gate-clock";
> + clocks = <&l4_root_clk_div>;
> + ti,bit-shift = <20>;
> + reg = <0x0558>;
> + };
> +
> + ehrpwm1_tbclk: ehrpwm1_tbclk {
> + #clock-cells = <0>;
> + compatible = "ti,gate-clock";
> + clocks = <&l4_root_clk_div>;
> + ti,bit-shift = <21>;
> + reg = <0x0558>;
> + };
> +
> + ehrpwm2_tbclk: ehrpwm2_tbclk {
> + #clock-cells = <0>;
> + compatible = "ti,gate-clock";
> + clocks = <&l4_root_clk_div>;
> + ti,bit-shift = <22>;
> + reg = <0x0558>;
> + };
> };
> --
> 2.7.0
>
next prev parent reply other threads:[~2016-02-29 23:23 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 22:36 [PATCH v3 0/5] Add support for PWMSS on DRA7 Franklin S Cooper Jr
2016-02-25 22:36 ` Franklin S Cooper Jr
2016-02-25 22:36 ` Franklin S Cooper Jr
2016-02-25 22:36 ` [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Franklin S Cooper Jr
2016-02-25 22:36 ` Franklin S Cooper Jr
2016-02-26 10:27 ` Sekhar Nori
2016-02-26 10:27 ` Sekhar Nori
2016-02-26 10:27 ` Sekhar Nori
2016-02-26 19:14 ` Tony Lindgren
2016-02-26 19:14 ` Tony Lindgren
2016-02-29 22:04 ` Tony Lindgren
2016-02-29 22:04 ` Tony Lindgren
2016-02-29 22:04 ` Tony Lindgren
2016-02-29 22:30 ` Franklin S Cooper Jr.
2016-02-29 22:30 ` Franklin S Cooper Jr.
2016-02-29 22:30 ` Franklin S Cooper Jr.
2016-02-29 22:55 ` Tony Lindgren
2016-02-29 22:55 ` Tony Lindgren
2016-02-29 23:11 ` Franklin S Cooper Jr.
2016-02-29 23:11 ` Franklin S Cooper Jr.
2016-02-29 23:11 ` Franklin S Cooper Jr.
2016-02-29 23:20 ` Tony Lindgren
2016-02-29 23:20 ` Tony Lindgren
2016-03-02 19:41 ` Franklin S Cooper Jr.
2016-03-02 19:41 ` Franklin S Cooper Jr.
2016-03-02 19:41 ` Franklin S Cooper Jr.
2016-03-02 22:54 ` Tony Lindgren
2016-03-02 22:54 ` Tony Lindgren
2016-02-25 22:36 ` [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Franklin S Cooper Jr
2016-02-25 22:36 ` Franklin S Cooper Jr
2016-03-01 18:07 ` Paul Walmsley
2016-03-01 18:07 ` Paul Walmsley
2016-03-01 18:07 ` Paul Walmsley
2016-03-01 18:11 ` Tony Lindgren
2016-03-01 18:11 ` Tony Lindgren
2016-03-01 18:59 ` Paul Walmsley
2016-03-01 18:59 ` Paul Walmsley
2016-03-01 18:59 ` Paul Walmsley
2016-03-01 20:50 ` Tony Lindgren
2016-03-01 20:50 ` Tony Lindgren
2016-03-02 16:22 ` Franklin S Cooper Jr.
2016-03-02 16:22 ` Franklin S Cooper Jr.
2016-03-02 16:22 ` Franklin S Cooper Jr.
2016-03-04 2:07 ` Franklin S Cooper Jr.
2016-03-04 2:07 ` Franklin S Cooper Jr.
2016-03-04 2:07 ` Franklin S Cooper Jr.
2016-03-04 6:25 ` Paul Walmsley
2016-03-04 6:25 ` Paul Walmsley
2016-03-04 12:23 ` Franklin S Cooper Jr.
2016-03-04 12:23 ` Franklin S Cooper Jr.
2016-03-04 12:23 ` Franklin S Cooper Jr.
2016-03-04 16:32 ` Paul Walmsley
2016-03-04 16:32 ` Paul Walmsley
2016-02-25 22:36 ` [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK " Franklin S Cooper Jr
2016-02-25 22:36 ` Franklin S Cooper Jr
2016-02-29 23:23 ` Tony Lindgren [this message]
2016-02-29 23:23 ` Tony Lindgren
2016-03-01 12:54 ` Tero Kristo
2016-03-01 12:54 ` Tero Kristo
2016-03-01 12:54 ` Tero Kristo
2016-03-01 18:05 ` Tony Lindgren
2016-03-01 18:05 ` Tony Lindgren
2016-02-25 22:36 ` [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Franklin S Cooper Jr
2016-02-25 22:36 ` Franklin S Cooper Jr
2016-02-26 19:16 ` Tony Lindgren
2016-02-26 19:16 ` Tony Lindgren
2016-02-26 19:17 ` Tony Lindgren
2016-02-26 19:17 ` Tony Lindgren
2016-02-25 22:36 ` [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr
2016-02-25 22:36 ` Franklin S Cooper Jr
2016-02-26 19:18 ` Tony Lindgren
2016-02-26 19:18 ` Tony Lindgren
2016-02-26 19:43 ` Franklin S Cooper Jr
2016-02-26 19:43 ` Franklin S Cooper Jr
2016-02-26 19:43 ` Franklin S Cooper Jr
2016-02-29 23:24 ` Tony Lindgren
2016-02-29 23:24 ` Tony Lindgren
2016-03-01 21:00 ` Tony Lindgren
2016-03-01 21:00 ` Tony Lindgren
2016-03-02 18:26 ` Rob Herring
2016-03-02 18:26 ` Rob Herring
2016-03-04 1:39 ` Franklin S Cooper Jr.
2016-03-04 1:39 ` Franklin S Cooper Jr.
2016-03-04 1:39 ` Franklin S Cooper Jr.
2016-03-04 14:52 ` Rob Herring
2016-03-04 14:52 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229232348.GV13417@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.