All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Henry Paulissen <henry@nitronetworks.nl>
Cc: linux-sunxi@googlegroups.com,
	Linus Walleij <linus.walleij@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	Hongzhou Yang <hongzhou.yang@mediatek.com>,
	Lee Jones <lee@kernel.org>, Fabian Frederick <fabf@skynet.be>,
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"moderated list:ARM/Allwinner sunXi SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: sunxi: Change mux setting on PI irq pins
Date: Mon, 29 Feb 2016 20:42:55 -0800	[thread overview]
Message-ID: <20160301044255.GD8418@lukather> (raw)
In-Reply-To: <bd99b2fb93c4c7da52ceb70a43dafded76fff974.1456698862.git.henry@nitronetworks.nl>

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

On Mon, Feb 29, 2016 at 12:13:27AM +0100, Henry Paulissen wrote:
> While I was testing irq's on the cubietruck I found a couple of
> not working irq pins. Further diving into the problem it opened
> up a mess called "manual".
> 
> This so called manual (A20 user manual v1.3 dated 2014-10-10) says:
> 
> Pin overview:
>     Page 237:       EINT26 is on mux 5.
>     Page 288:       EINT26 is on mux 6.
> 
> The manual is so contradicting that further tests had to be made
> to see which of the 2 statements where correct.
> 
> This patch is based on actual outcome of these tests and not what
> the manual says.
> 
> Test procedure used:
> 
> Connect a 1 pulse per second (GPS) line to the pin.
> 
> echo pin### > /sys/class/gpio/export
> echo in > /sys/class/gpio/gpio###/direction
> echo rising > /sys/class/gpio/gpio###/edge
> 
> Check /proc/interrupts if a irq was attached and if irq's where
> received.
> 
> Hardware used:
> Henry Paulissen: Cubietruck
> Andere Przywara: BananaPi M1
> 
> Tested-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Henry Paulissen <henry@nitronetworks.nl>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks !

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pinctrl: sunxi: Change mux setting on PI irq pins
Date: Mon, 29 Feb 2016 20:42:55 -0800	[thread overview]
Message-ID: <20160301044255.GD8418@lukather> (raw)
In-Reply-To: <bd99b2fb93c4c7da52ceb70a43dafded76fff974.1456698862.git.henry@nitronetworks.nl>

On Mon, Feb 29, 2016 at 12:13:27AM +0100, Henry Paulissen wrote:
> While I was testing irq's on the cubietruck I found a couple of
> not working irq pins. Further diving into the problem it opened
> up a mess called "manual".
> 
> This so called manual (A20 user manual v1.3 dated 2014-10-10) says:
> 
> Pin overview:
>     Page 237:       EINT26 is on mux 5.
>     Page 288:       EINT26 is on mux 6.
> 
> The manual is so contradicting that further tests had to be made
> to see which of the 2 statements where correct.
> 
> This patch is based on actual outcome of these tests and not what
> the manual says.
> 
> Test procedure used:
> 
> Connect a 1 pulse per second (GPS) line to the pin.
> 
> echo pin### > /sys/class/gpio/export
> echo in > /sys/class/gpio/gpio###/direction
> echo rising > /sys/class/gpio/gpio###/edge
> 
> Check /proc/interrupts if a irq was attached and if irq's where
> received.
> 
> Hardware used:
> Henry Paulissen: Cubietruck
> Andere Przywara: BananaPi M1
> 
> Tested-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Henry Paulissen <henry@nitronetworks.nl>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks !

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160229/80dc7d13/attachment.sig>

  reply	other threads:[~2016-03-01  4:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-28 23:13 [PATCH 0/2] pinctrl: sunxi: Fix A20 irq pins Henry Paulissen
     [not found] ` <cover.1456698862.git.henry-oxlTVf6CAJF4HdFT58BDcQ@public.gmane.org>
2016-02-28 23:13   ` [PATCH 1/2] pinctrl: sunxi: Remove non existing irq's Henry Paulissen
2016-02-28 23:13     ` Henry Paulissen
2016-02-28 23:13     ` Henry Paulissen
     [not found]     ` <bd43820c6708d57ff2997dccd588faa28da11990.1456698862.git.henry-oxlTVf6CAJF4HdFT58BDcQ@public.gmane.org>
2016-03-01  4:43       ` Maxime Ripard
2016-03-01  4:43         ` Maxime Ripard
2016-03-01  4:43         ` Maxime Ripard
2016-03-08  9:01       ` Linus Walleij
2016-03-08  9:01         ` Linus Walleij
2016-03-08  9:01         ` Linus Walleij
2016-02-28 23:13   ` [PATCH 2/2] pinctrl: sunxi: Change mux setting on PI irq pins Henry Paulissen
2016-02-28 23:13     ` Henry Paulissen
2016-02-28 23:13     ` Henry Paulissen
2016-03-01  4:42     ` Maxime Ripard [this message]
2016-03-01  4:42       ` Maxime Ripard
     [not found]     ` <bd99b2fb93c4c7da52ceb70a43dafded76fff974.1456698862.git.henry-oxlTVf6CAJF4HdFT58BDcQ@public.gmane.org>
2016-03-08  9:03       ` Linus Walleij
2016-03-08  9:03         ` Linus Walleij
2016-03-08  9:03         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160301044255.GD8418@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=fabf@skynet.be \
    --cc=henry@nitronetworks.nl \
    --cc=hongzhou.yang@mediatek.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.