All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jan Kara <jack@suse.cz>, Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] printk/nmi: restore printk_func in nmi_panic
Date: Tue, 1 Mar 2016 12:05:29 +0100	[thread overview]
Message-ID: <20160301110528.GO3305@pathway.suse.cz> (raw)
In-Reply-To: <20160301092426.GA2968@swordfish>

On Tue 2016-03-01 18:24:26, Sergey Senozhatsky wrote:
> Hello,
> 
> On (02/29/16 20:19), Sergey Senozhatsky wrote:
> [..]
> > > That is the problem. zap_locks() is not a solution.
> > > 
> > > First, it handles only lockbuf_lock and console_sem. There are other
> > > locks used by particular consoles that might cause a deadlock.
> > 
> > yes, well, that's true for panic() in general.
> 
> Petr, what do you think of this (added PRINTK_NMI_FLUSH_ON_PANIC)?
> 
> 1) zap_locks() in console_flush_on_panic()
> 2) add PRINTK_NMI_FLUSH_ON_PANIC symbols
> 3) add printk_nmi_flush_on_panic()

This is definitely better than nothing. Well, it seems that
the printk/NMI patches that motivated this patch will be
removed for a while, see
http://thread.gmane.org/gmane.linux.ports.arm.kernel/482845/focus=483002

I want to play with the panic handling a bit more and make it better
working out of box. It might be enough to put the messages into
the rind buffer when crashdump is going to be produced. Also
there is still the idea about using the lock-less early console.
I think that the solution from this patch might be the last
fallback.

Thanks a lot for proposals,
Petr

  reply	other threads:[~2016-03-01 11:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26  3:37 [PATCH] printk/nmi: restore printk_func in nmi_panic Sergey Senozhatsky
2016-02-26 14:57 ` Petr Mladek
2016-02-27  2:19   ` Sergey Senozhatsky
2016-02-27  3:09     ` Sergey Senozhatsky
2016-02-27  3:33       ` Sergey Senozhatsky
2016-02-28  3:52         ` Sergey Senozhatsky
2016-02-29 10:31     ` Petr Mladek
2016-02-29 11:19       ` Sergey Senozhatsky
2016-03-01  9:24         ` Sergey Senozhatsky
2016-03-01 11:05           ` Petr Mladek [this message]
2016-03-01 13:14             ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160301110528.GO3305@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.