All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: borrow indirect blocks from freed extent when available
Date: Tue, 1 Mar 2016 05:00:18 -0800	[thread overview]
Message-ID: <20160301130018.GA28675@infradead.org> (raw)
In-Reply-To: <1456756170-51248-4-git-send-email-bfoster@redhat.com>

I've been wrapping my head around this since yersterday..

It looks reasonable, but I'd be much more comfortable if you could
split this into two patches:

 - one to just factor out a helper to update the temp and temp2
   values (great variable names while we're at it..  not your fault,
   though)
 - one to actually change the algorithm used.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-03-01 13:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 14:29 [PATCH v2 0/3] fix up indlen reservations on extent split Brian Foster
2016-02-29 14:29 ` [PATCH RFC 1/3] xfs: debug mode forced buffered write failure Brian Foster
2016-03-01 12:55   ` Christoph Hellwig
2016-03-01 13:10     ` Brian Foster
2016-02-29 14:29 ` [PATCH 2/3] xfs: update icsb freeblocks counter after extent deletion Brian Foster
2016-03-01 12:48   ` Christoph Hellwig
2016-02-29 14:29 ` [PATCH 3/3] xfs: borrow indirect blocks from freed extent when available Brian Foster
2016-03-01 13:00   ` Christoph Hellwig [this message]
2016-03-01 13:11     ` Brian Foster
2016-02-29 14:36 ` [PATCH v2 0/3] fix up indlen reservations on extent split Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160301130018.GA28675@infradead.org \
    --to=hch@infradead.org \
    --cc=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.