* FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree @ 2016-03-01 18:45 gregkh 2016-03-01 19:27 ` Coelho, Luciano 0 siblings, 1 reply; 11+ messages in thread From: gregkh @ 2016-03-01 18:45 UTC (permalink / raw) To: luciano.coelho, emmanuel.grumbach, stable; +Cc: stable The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable@vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00 2001 From: Luca Coelho <luciano.coelho@intel.com> Date: Tue, 2 Feb 2016 15:11:15 +0200 Subject: [PATCH] iwlwifi: mvm: don't allow sched scans without matches to be started The firmware can perform a scheduled scan with not matchsets passed, but it can't send notification that results were found. Since the userspace then cannot know when we got new results and the firmware wouldn't trigger a wake in case we are sleeping, it's better not to allow scans without matchsets. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831 Cc: <stable@vger.kernel.org> [3.17+] Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c index 9a15642f80dd..ea1e177c2ea1 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c @@ -1298,6 +1298,10 @@ int iwl_mvm_sched_scan_start(struct iwl_mvm *mvm, return -EBUSY; } + /* we don't support "match all" in the firmware */ + if (!req->n_match_sets) + return -EOPNOTSUPP; + ret = iwl_mvm_check_running_scans(mvm, type); if (ret) return ret; ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 18:45 FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree gregkh @ 2016-03-01 19:27 ` Coelho, Luciano 2016-03-01 19:42 ` gregkh 0 siblings, 1 reply; 11+ messages in thread From: Coelho, Luciano @ 2016-03-01 19:27 UTC (permalink / raw) To: gregkh@linuxfoundation.org, stable@vger.kernel.org, Grumbach, Emmanuel Hi Greg, This is strange... I just tried to cherry-pick it on top of 4.4.3 and it applied cleanly. Do you want me to send it again anyway? -- Cheers, Luca. On Tue, 2016-03-01 at 10:45 -0800, gregkh@linuxfoundation.org wrote: > The patch below does not apply to the 4.4-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git > commit > id to <stable@vger.kernel.org>. > > thanks, > > greg k-h > > ------------------ original commit in Linus's tree ------------------ > > From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00 > 2001 > From: Luca Coelho <luciano.coelho@intel.com> > Date: Tue, 2 Feb 2016 15:11:15 +0200 > Subject: [PATCH] iwlwifi: mvm: don't allow sched scans without > matches to be > started > > The firmware can perform a scheduled scan with not matchsets passed, > but it can't send notification that results were found. Since the > userspace then cannot know when we got new results and the firmware > wouldn't trigger a wake in case we are sleeping, it's better not to > allow scans without matchsets. > > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831 > > Cc: <stable@vger.kernel.org> [3.17+] > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > index 9a15642f80dd..ea1e177c2ea1 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > @@ -1298,6 +1298,10 @@ int iwl_mvm_sched_scan_start(struct iwl_mvm > *mvm, > return -EBUSY; > } > > + /* we don't support "match all" in the firmware */ > + if (!req->n_match_sets) > + return -EOPNOTSUPP; > + > ret = iwl_mvm_check_running_scans(mvm, type); > if (ret) > return ret; > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 19:27 ` Coelho, Luciano @ 2016-03-01 19:42 ` gregkh 2016-03-01 19:45 ` Coelho, Luciano 0 siblings, 1 reply; 11+ messages in thread From: gregkh @ 2016-03-01 19:42 UTC (permalink / raw) To: Coelho, Luciano; +Cc: stable@vger.kernel.org, Grumbach, Emmanuel On Tue, Mar 01, 2016 at 07:27:41PM +0000, Coelho, Luciano wrote: > Hi Greg, > > This is strange... I just tried to cherry-pick it on top of 4.4.3 and > it applied cleanly. I think it breaks the build, can you try to test build it as well? thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 19:42 ` gregkh @ 2016-03-01 19:45 ` Coelho, Luciano 2016-03-01 19:52 ` Coelho, Luciano 0 siblings, 1 reply; 11+ messages in thread From: Coelho, Luciano @ 2016-03-01 19:45 UTC (permalink / raw) To: gregkh@linuxfoundation.org; +Cc: stable@vger.kernel.org, Grumbach, Emmanuel On Tue, 2016-03-01 at 19:42 +0000, gregkh@linuxfoundation.org wrote: > On Tue, Mar 01, 2016 at 07:27:41PM +0000, Coelho, Luciano wrote: > > Hi Greg, > > > > This is strange... I just tried to cherry-pick it on top of 4.4.3 > > and > > it applied cleanly. > > I think it breaks the build, can you try to test build it as well? Sure, I'm building it right now. -- Luca. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 19:45 ` Coelho, Luciano @ 2016-03-01 19:52 ` Coelho, Luciano 2016-03-01 20:02 ` gregkh 0 siblings, 1 reply; 11+ messages in thread From: Coelho, Luciano @ 2016-03-01 19:52 UTC (permalink / raw) To: gregkh@linuxfoundation.org; +Cc: stable@vger.kernel.org, Grumbach, Emmanuel On Tue, 2016-03-01 at 21:45 +0200, Coelho, Luciano wrote: > On Tue, 2016-03-01 at 19:42 +0000, gregkh@linuxfoundation.org wrote: > > On Tue, Mar 01, 2016 at 07:27:41PM +0000, Coelho, Luciano wrote: > > > Hi Greg, > > > > > > This is strange... I just tried to cherry-pick it on top of 4.4.3 > > > and > > > it applied cleanly. > > > > I think it breaks the build, can you try to test build it as well? > > Sure, I'm building it right now. Tried to do everything again, from scratch. The patch applied cleanly and the iwlwifi driver built without any problems. Pastebin of the output here: http://pastebin.coelho.fi/cc3fd7dd9016d944.txt -- Luca. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 19:52 ` Coelho, Luciano @ 2016-03-01 20:02 ` gregkh 2016-03-01 20:07 ` Coelho, Luciano 0 siblings, 1 reply; 11+ messages in thread From: gregkh @ 2016-03-01 20:02 UTC (permalink / raw) To: Coelho, Luciano; +Cc: stable@vger.kernel.org, Grumbach, Emmanuel On Tue, Mar 01, 2016 at 07:52:14PM +0000, Coelho, Luciano wrote: > On Tue, 2016-03-01 at 21:45 +0200, Coelho, Luciano wrote: > > On Tue, 2016-03-01 at 19:42 +0000, gregkh@linuxfoundation.org wrote: > > > On Tue, Mar 01, 2016 at 07:27:41PM +0000, Coelho, Luciano wrote: > > > > Hi Greg, > > > > > > > > This is strange... I just tried to cherry-pick it on top of 4.4.3 > > > > and > > > > it applied cleanly. > > > > > > I think it breaks the build, can you try to test build it as well? > > > > Sure, I'm building it right now. > > Tried to do everything again, from scratch. The patch applied cleanly > and the iwlwifi driver built without any problems. > > Pastebin of the output here: > > http://pastebin.coelho.fi/cc3fd7dd9016d944.txt Ah, I can't use cherry-pick: $ patch -p1 < ../iwlwifi-mvm-don-t-allow-sched-scans-without-matches-to-be-started.patch can't find file to patch at input line 26 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00 2001 |From: Luca Coelho <luciano.coelho@intel.com> |Date: Tue, 2 Feb 2016 15:11:15 +0200 |Subject: iwlwifi: mvm: don't allow sched scans without matches to be started | |From: Luca Coelho <luciano.coelho@intel.com> | |commit 5e56276e7555b34550d51459a801ff75eca8b907 upstream. | |The firmware can perform a scheduled scan with not matchsets passed, |but it can't send notification that results were found. Since the |userspace then cannot know when we got new results and the firmware |wouldn't trigger a wake in case we are sleeping, it's better not to |allow scans without matchsets. | |This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831 | |Signed-off-by: Luca Coelho <luciano.coelho@intel.com> |Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> |Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c |index 9a15642f80dd..ea1e177c2ea1 100644 |--- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c |+++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c -------------------------- File to patch: That's the issue, things got renamed :( ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 20:02 ` gregkh @ 2016-03-01 20:07 ` Coelho, Luciano 2016-03-01 20:11 ` gregkh 0 siblings, 1 reply; 11+ messages in thread From: Coelho, Luciano @ 2016-03-01 20:07 UTC (permalink / raw) To: gregkh@linuxfoundation.org; +Cc: stable@vger.kernel.org, Grumbach, Emmanuel On Tue, 2016-03-01 at 20:02 +0000, gregkh@linuxfoundation.org wrote: > On Tue, Mar 01, 2016 at 07:52:14PM +0000, Coelho, Luciano wrote: > > On Tue, 2016-03-01 at 21:45 +0200, Coelho, Luciano wrote: > > > On Tue, 2016-03-01 at 19:42 +0000, gregkh@linuxfoundation.org > > > wrote: > > > > On Tue, Mar 01, 2016 at 07:27:41PM +0000, Coelho, Luciano > > > > wrote: > > > > > Hi Greg, > > > > > > > > > > This is strange... I just tried to cherry-pick it on top of > > > > > 4.4.3 > > > > > and > > > > > it applied cleanly. > > > > > > > > I think it breaks the build, can you try to test build it as > > > > well? > > > > > > Sure, I'm building it right now. > > > > Tried to do everything again, from scratch. The patch applied > > cleanly > > and the iwlwifi driver built without any problems. > > > > Pastebin of the output here: > > > > http://pastebin.coelho.fi/cc3fd7dd9016d944.txt > > Ah, I can't use cherry-pick: > > $ patch -p1 < ../iwlwifi-mvm-don-t-allow-sched-scans-without-matches- > to-be-started.patch > can't find file to patch at input line 26 > Perhaps you used the wrong -p or --strip option? > The text leading up to this was: > -------------------------- > > From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00 > > 2001 > > From: Luca Coelho <luciano.coelho@intel.com> > > Date: Tue, 2 Feb 2016 15:11:15 +0200 > > Subject: iwlwifi: mvm: don't allow sched scans without matches to > > be started > > > > From: Luca Coelho <luciano.coelho@intel.com> > > > > commit 5e56276e7555b34550d51459a801ff75eca8b907 upstream. > > > > The firmware can perform a scheduled scan with not matchsets > > passed, > > but it can't send notification that results were found. Since the > > userspace then cannot know when we got new results and the firmware > > wouldn't trigger a wake in case we are sleeping, it's better not to > > allow scans without matchsets. > > > > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831 > > > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> > > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > index 9a15642f80dd..ea1e177c2ea1 100644 > > --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > -------------------------- > File to patch: > > > That's the issue, things got renamed :( Ah, okay, I should have realized that, sorry. I thought you were using at least 'git am -3' or something to let git do its tricks on these minor issues. I'll send the new patch for 4.4 right away (since I already have it after all). :) -- Cheers, Luca. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 20:07 ` Coelho, Luciano @ 2016-03-01 20:11 ` gregkh 2016-03-01 20:19 ` Grumbach, Emmanuel 0 siblings, 1 reply; 11+ messages in thread From: gregkh @ 2016-03-01 20:11 UTC (permalink / raw) To: Coelho, Luciano; +Cc: stable@vger.kernel.org, Grumbach, Emmanuel On Tue, Mar 01, 2016 at 08:07:02PM +0000, Coelho, Luciano wrote: > On Tue, 2016-03-01 at 20:02 +0000, gregkh@linuxfoundation.org wrote: > > On Tue, Mar 01, 2016 at 07:52:14PM +0000, Coelho, Luciano wrote: > > > On Tue, 2016-03-01 at 21:45 +0200, Coelho, Luciano wrote: > > > > On Tue, 2016-03-01 at 19:42 +0000, gregkh@linuxfoundation.org > > > > wrote: > > > > > On Tue, Mar 01, 2016 at 07:27:41PM +0000, Coelho, Luciano > > > > > wrote: > > > > > > Hi Greg, > > > > > > > > > > > > This is strange... I just tried to cherry-pick it on top of > > > > > > 4.4.3 > > > > > > and > > > > > > it applied cleanly. > > > > > > > > > > I think it breaks the build, can you try to test build it as > > > > > well? > > > > > > > > Sure, I'm building it right now. > > > > > > Tried to do everything again, from scratch. The patch applied > > > cleanly > > > and the iwlwifi driver built without any problems. > > > > > > Pastebin of the output here: > > > > > > http://pastebin.coelho.fi/cc3fd7dd9016d944.txt > > > > Ah, I can't use cherry-pick: > > > > $ patch -p1 < ../iwlwifi-mvm-don-t-allow-sched-scans-without-matches- > > to-be-started.patch > > can't find file to patch at input line 26 > > Perhaps you used the wrong -p or --strip option? > > The text leading up to this was: > > -------------------------- > > > From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00 > > > 2001 > > > From: Luca Coelho <luciano.coelho@intel.com> > > > Date: Tue, 2 Feb 2016 15:11:15 +0200 > > > Subject: iwlwifi: mvm: don't allow sched scans without matches to > > > be started > > > > > > From: Luca Coelho <luciano.coelho@intel.com> > > > > > > commit 5e56276e7555b34550d51459a801ff75eca8b907 upstream. > > > > > > The firmware can perform a scheduled scan with not matchsets > > > passed, > > > but it can't send notification that results were found. Since the > > > userspace then cannot know when we got new results and the firmware > > > wouldn't trigger a wake in case we are sleeping, it's better not to > > > allow scans without matchsets. > > > > > > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831 > > > > > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> > > > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > > b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > > index 9a15642f80dd..ea1e177c2ea1 100644 > > > --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > -------------------------- > > File to patch: > > > > > > That's the issue, things got renamed :( > > Ah, okay, I should have realized that, sorry. > > I thought you were using at least 'git am -3' or something to let git > do its tricks on these minor issues. I'll send the new patch for 4.4 > right away (since I already have it after all). :) I use quilt, not git until I apply the patches when the tree is released. thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 20:11 ` gregkh @ 2016-03-01 20:19 ` Grumbach, Emmanuel 2016-03-01 20:23 ` Coelho, Luciano 2016-03-01 20:24 ` gregkh 0 siblings, 2 replies; 11+ messages in thread From: Grumbach, Emmanuel @ 2016-03-01 20:19 UTC (permalink / raw) To: gregkh@linuxfoundation.org, Coelho, Luciano; +Cc: stable@vger.kernel.org On 03/01/2016 10:11 PM, gregkh@linuxfoundation.org wrote: > On Tue, Mar 01, 2016 at 08:07:02PM +0000, Coelho, Luciano wrote: >> On Tue, 2016-03-01 at 20:02 +0000, gregkh@linuxfoundation.org wrote: >>> On Tue, Mar 01, 2016 at 07:52:14PM +0000, Coelho, Luciano wrote: >>>> On Tue, 2016-03-01 at 21:45 +0200, Coelho, Luciano wrote: >>>>> On Tue, 2016-03-01 at 19:42 +0000, gregkh@linuxfoundation.org >>>>> wrote: >>>>>> On Tue, Mar 01, 2016 at 07:27:41PM +0000, Coelho, Luciano >>>>>> wrote: >>>>>>> Hi Greg, >>>>>>> >>>>>>> This is strange... I just tried to cherry-pick it on top of >>>>>>> 4.4.3 >>>>>>> and >>>>>>> it applied cleanly. >>>>>> >>>>>> I think it breaks the build, can you try to test build it as >>>>>> well? >>>>> >>>>> Sure, I'm building it right now. >>>> >>>> Tried to do everything again, from scratch. The patch applied >>>> cleanly >>>> and the iwlwifi driver built without any problems. >>>> >>>> Pastebin of the output here: >>>> >>>> http://pastebin.coelho.fi/cc3fd7dd9016d944.txt >>> >>> Ah, I can't use cherry-pick: >>> >>> $ patch -p1 < ../iwlwifi-mvm-don-t-allow-sched-scans-without-matches- >>> to-be-started.patch >>> can't find file to patch at input line 26 >>> Perhaps you used the wrong -p or --strip option? >>> The text leading up to this was: >>> -------------------------- >>>> From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00 >>>> 2001 >>>> From: Luca Coelho <luciano.coelho@intel.com> >>>> Date: Tue, 2 Feb 2016 15:11:15 +0200 >>>> Subject: iwlwifi: mvm: don't allow sched scans without matches to >>>> be started >>>> >>>> From: Luca Coelho <luciano.coelho@intel.com> >>>> >>>> commit 5e56276e7555b34550d51459a801ff75eca8b907 upstream. >>>> >>>> The firmware can perform a scheduled scan with not matchsets >>>> passed, >>>> but it can't send notification that results were found. Since the >>>> userspace then cannot know when we got new results and the firmware >>>> wouldn't trigger a wake in case we are sleeping, it's better not to >>>> allow scans without matchsets. >>>> >>>> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831 >>>> >>>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com> >>>> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> >>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>>> >>>> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c >>>> b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c >>>> index 9a15642f80dd..ea1e177c2ea1 100644 >>>> --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c >>>> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c >>> -------------------------- >>> File to patch: >>> >>> >>> That's the issue, things got renamed :( >> >> Ah, okay, I should have realized that, sorry. >> >> I thought you were using at least 'git am -3' or something to let git >> do its tricks on these minor issues. I'll send the new patch for 4.4 >> right away (since I already have it after all). :) > > I use quilt, not git until I apply the patches when the tree is > released. > Greg, do you want to resend all the patches that failed due to the directory restruturation? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 20:19 ` Grumbach, Emmanuel @ 2016-03-01 20:23 ` Coelho, Luciano 2016-03-01 20:24 ` gregkh 1 sibling, 0 replies; 11+ messages in thread From: Coelho, Luciano @ 2016-03-01 20:23 UTC (permalink / raw) To: gregkh@linuxfoundation.org, Grumbach, Emmanuel; +Cc: stable@vger.kernel.org On Tue, 2016-03-01 at 20:19 +0000, Grumbach, Emmanuel wrote: > > On 03/01/2016 10:11 PM, gregkh@linuxfoundation.org wrote: > > On Tue, Mar 01, 2016 at 08:07:02PM +0000, Coelho, Luciano wrote: > > > On Tue, 2016-03-01 at 20:02 +0000, gregkh@linuxfoundation.org > > > wrote: > > > > On Tue, Mar 01, 2016 at 07:52:14PM +0000, Coelho, Luciano > > > > wrote: > > > > > On Tue, 2016-03-01 at 21:45 +0200, Coelho, Luciano wrote: > > > > > > On Tue, 2016-03-01 at 19:42 +0000, gregkh@linuxfoundation.o > > > > > > rg > > > > > > wrote: > > > > > > > On Tue, Mar 01, 2016 at 07:27:41PM +0000, Coelho, Luciano > > > > > > > wrote: > > > > > > > > Hi Greg, > > > > > > > > > > > > > > > > This is strange... I just tried to cherry-pick it on > > > > > > > > top of > > > > > > > > 4.4.3 > > > > > > > > and > > > > > > > > it applied cleanly. > > > > > > > > > > > > > > I think it breaks the build, can you try to test build it > > > > > > > as > > > > > > > well? > > > > > > > > > > > > Sure, I'm building it right now. > > > > > > > > > > Tried to do everything again, from scratch. The patch > > > > > applied > > > > > cleanly > > > > > and the iwlwifi driver built without any problems. > > > > > > > > > > Pastebin of the output here: > > > > > > > > > > http://pastebin.coelho.fi/cc3fd7dd9016d944.txt > > > > > > > > Ah, I can't use cherry-pick: > > > > > > > > $ patch -p1 < ../iwlwifi-mvm-don-t-allow-sched-scans-without- > > > > matches- > > > > to-be-started.patch > > > > can't find file to patch at input line 26 > > > > Perhaps you used the wrong -p or --strip option? > > > > The text leading up to this was: > > > > -------------------------- > > > > > From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 > > > > > 00:00:00 > > > > > 2001 > > > > > From: Luca Coelho <luciano.coelho@intel.com> > > > > > Date: Tue, 2 Feb 2016 15:11:15 +0200 > > > > > Subject: iwlwifi: mvm: don't allow sched scans without > > > > > matches to > > > > > be started > > > > > > > > > > From: Luca Coelho <luciano.coelho@intel.com> > > > > > > > > > > commit 5e56276e7555b34550d51459a801ff75eca8b907 upstream. > > > > > > > > > > The firmware can perform a scheduled scan with not matchsets > > > > > passed, > > > > > but it can't send notification that results were > > > > > found. Since the > > > > > userspace then cannot know when we got new results and the > > > > > firmware > > > > > wouldn't trigger a wake in case we are sleeping, it's better > > > > > not to > > > > > allow scans without matchsets. > > > > > > > > > > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831 > > > > > > > > > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> > > > > > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com > > > > > > > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org > > > > > > > > > > > > > > > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > > > > b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > > > > index 9a15642f80dd..ea1e177c2ea1 100644 > > > > > --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > > > > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > > > > -------------------------- > > > > File to patch: > > > > > > > > > > > > That's the issue, things got renamed :( > > > > > > Ah, okay, I should have realized that, sorry. > > > > > > I thought you were using at least 'git am -3' or something to let > > > git > > > do its tricks on these minor issues. I'll send the new patch for > > > 4.4 > > > right away (since I already have it after all). :) > > > > I use quilt, not git until I apply the patches when the tree is > > released. > > > > Greg, do you want to resend all the patches that failed due to the > directory restruturation? This probably happens with *all* wireless patches... -- Luca. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree 2016-03-01 20:19 ` Grumbach, Emmanuel 2016-03-01 20:23 ` Coelho, Luciano @ 2016-03-01 20:24 ` gregkh 1 sibling, 0 replies; 11+ messages in thread From: gregkh @ 2016-03-01 20:24 UTC (permalink / raw) To: Grumbach, Emmanuel; +Cc: Coelho, Luciano, stable@vger.kernel.org On Tue, Mar 01, 2016 at 08:19:19PM +0000, Grumbach, Emmanuel wrote: > > > On 03/01/2016 10:11 PM, gregkh@linuxfoundation.org wrote: > > On Tue, Mar 01, 2016 at 08:07:02PM +0000, Coelho, Luciano wrote: > >> On Tue, 2016-03-01 at 20:02 +0000, gregkh@linuxfoundation.org wrote: > >>> On Tue, Mar 01, 2016 at 07:52:14PM +0000, Coelho, Luciano wrote: > >>>> On Tue, 2016-03-01 at 21:45 +0200, Coelho, Luciano wrote: > >>>>> On Tue, 2016-03-01 at 19:42 +0000, gregkh@linuxfoundation.org > >>>>> wrote: > >>>>>> On Tue, Mar 01, 2016 at 07:27:41PM +0000, Coelho, Luciano > >>>>>> wrote: > >>>>>>> Hi Greg, > >>>>>>> > >>>>>>> This is strange... I just tried to cherry-pick it on top of > >>>>>>> 4.4.3 > >>>>>>> and > >>>>>>> it applied cleanly. > >>>>>> > >>>>>> I think it breaks the build, can you try to test build it as > >>>>>> well? > >>>>> > >>>>> Sure, I'm building it right now. > >>>> > >>>> Tried to do everything again, from scratch. The patch applied > >>>> cleanly > >>>> and the iwlwifi driver built without any problems. > >>>> > >>>> Pastebin of the output here: > >>>> > >>>> http://pastebin.coelho.fi/cc3fd7dd9016d944.txt > >>> > >>> Ah, I can't use cherry-pick: > >>> > >>> $ patch -p1 < ../iwlwifi-mvm-don-t-allow-sched-scans-without-matches- > >>> to-be-started.patch > >>> can't find file to patch at input line 26 > >>> Perhaps you used the wrong -p or --strip option? > >>> The text leading up to this was: > >>> -------------------------- > >>>> From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00 > >>>> 2001 > >>>> From: Luca Coelho <luciano.coelho@intel.com> > >>>> Date: Tue, 2 Feb 2016 15:11:15 +0200 > >>>> Subject: iwlwifi: mvm: don't allow sched scans without matches to > >>>> be started > >>>> > >>>> From: Luca Coelho <luciano.coelho@intel.com> > >>>> > >>>> commit 5e56276e7555b34550d51459a801ff75eca8b907 upstream. > >>>> > >>>> The firmware can perform a scheduled scan with not matchsets > >>>> passed, > >>>> but it can't send notification that results were found. Since the > >>>> userspace then cannot know when we got new results and the firmware > >>>> wouldn't trigger a wake in case we are sleeping, it's better not to > >>>> allow scans without matchsets. > >>>> > >>>> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831 > >>>> > >>>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com> > >>>> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> > >>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > >>>> > >>>> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > >>>> b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > >>>> index 9a15642f80dd..ea1e177c2ea1 100644 > >>>> --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > >>>> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c > >>> -------------------------- > >>> File to patch: > >>> > >>> > >>> That's the issue, things got renamed :( > >> > >> Ah, okay, I should have realized that, sorry. > >> > >> I thought you were using at least 'git am -3' or something to let git > >> do its tricks on these minor issues. I'll send the new patch for 4.4 > >> right away (since I already have it after all). :) > > > > I use quilt, not git until I apply the patches when the tree is > > released. > > > > Greg, do you want to resend all the patches that failed due to the > directory restruturation? Yes, please do. ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-03-01 20:24 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-01 18:45 FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree gregkh 2016-03-01 19:27 ` Coelho, Luciano 2016-03-01 19:42 ` gregkh 2016-03-01 19:45 ` Coelho, Luciano 2016-03-01 19:52 ` Coelho, Luciano 2016-03-01 20:02 ` gregkh 2016-03-01 20:07 ` Coelho, Luciano 2016-03-01 20:11 ` gregkh 2016-03-01 20:19 ` Grumbach, Emmanuel 2016-03-01 20:23 ` Coelho, Luciano 2016-03-01 20:24 ` gregkh
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.