* [kvm-unit-tests PATCH] x86: setjmp: including stdio is a no-no
@ 2016-03-01 13:30 Andrew Jones
2016-03-01 19:54 ` Peter Feiner
2016-03-01 21:09 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Jones @ 2016-03-01 13:30 UTC (permalink / raw)
To: kvm; +Cc: pbonzini
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
x86/setjmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/setjmp.c b/x86/setjmp.c
index 46f0d9c5feb9b..fa331792d852d 100644
--- a/x86/setjmp.c
+++ b/x86/setjmp.c
@@ -1,4 +1,4 @@
-#include "stdio.h"
+#include "libcflat.h"
#include "setjmp.h"
int main()
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] x86: setjmp: including stdio is a no-no
2016-03-01 13:30 [kvm-unit-tests PATCH] x86: setjmp: including stdio is a no-no Andrew Jones
@ 2016-03-01 19:54 ` Peter Feiner
2016-03-01 21:09 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Peter Feiner @ 2016-03-01 19:54 UTC (permalink / raw)
To: Andrew Jones; +Cc: kvm, pbonzini
On Tue, Mar 01, 2016 at 02:30:49PM +0100, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> x86/setjmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/setjmp.c b/x86/setjmp.c
> index 46f0d9c5feb9b..fa331792d852d 100644
> --- a/x86/setjmp.c
> +++ b/x86/setjmp.c
> @@ -1,4 +1,4 @@
> -#include "stdio.h"
> +#include "libcflat.h"
> #include "setjmp.h"
>
> int main()
Thanks! I always apply this patch locally.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] x86: setjmp: including stdio is a no-no
2016-03-01 13:30 [kvm-unit-tests PATCH] x86: setjmp: including stdio is a no-no Andrew Jones
2016-03-01 19:54 ` Peter Feiner
@ 2016-03-01 21:09 ` Paolo Bonzini
2016-03-02 14:50 ` Andrew Jones
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2016-03-01 21:09 UTC (permalink / raw)
To: Andrew Jones, kvm
On 01/03/2016 14:30, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> x86/setjmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/setjmp.c b/x86/setjmp.c
> index 46f0d9c5feb9b..fa331792d852d 100644
> --- a/x86/setjmp.c
> +++ b/x86/setjmp.c
> @@ -1,4 +1,4 @@
> -#include "stdio.h"
> +#include "libcflat.h"
> #include "setjmp.h"
>
> int main()
>
We probably should instead provide our own stdio.h. In the meanwhile,
I've queued this and will push tomorrow.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] x86: setjmp: including stdio is a no-no
2016-03-01 21:09 ` Paolo Bonzini
@ 2016-03-02 14:50 ` Andrew Jones
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Jones @ 2016-03-02 14:50 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm
On Tue, Mar 01, 2016 at 10:09:35PM +0100, Paolo Bonzini wrote:
> On 01/03/2016 14:30, Andrew Jones wrote:
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
> > x86/setjmp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/x86/setjmp.c b/x86/setjmp.c
> > index 46f0d9c5feb9b..fa331792d852d 100644
> > --- a/x86/setjmp.c
> > +++ b/x86/setjmp.c
> > @@ -1,4 +1,4 @@
> > -#include "stdio.h"
> > +#include "libcflat.h"
> > #include "setjmp.h"
> >
> > int main()
> >
>
> We probably should instead provide our own stdio.h. In the meanwhile,
> I've queued this and will push tomorrow.
Good idea. Added to the TODO.
Thanks,
drew
>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-02 14:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-01 13:30 [kvm-unit-tests PATCH] x86: setjmp: including stdio is a no-no Andrew Jones
2016-03-01 19:54 ` Peter Feiner
2016-03-01 21:09 ` Paolo Bonzini
2016-03-02 14:50 ` Andrew Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.