All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Rudolf J Streif <rudolf.streif@gmail.com>
Cc: yocto@yoctoproject.org
Subject: Re: [wic] Creating sdimage-bootpart
Date: Wed, 2 Mar 2016 08:47:35 +0200	[thread overview]
Message-ID: <20160302064735.GA21419@linux.intel.com> (raw)
In-Reply-To: <5285202.8PW0mz0glJ@rjs-zotac.streifs.net>

Hi Rudolf,

Interesting. I thought that this commit shoud fix the issue:
http://cgit.openembedded.org/openembedded-core/commit/?id=264c03e854f77c3b62acb710384f66716ccbf469

Which branch do you use?

On Tue, Mar 01, 2016 at 08:42:02AM -0800, Rudolf J Streif wrote:
> I tried creating an image with wic using sdimage-bootpart which produces this 
> error message:
> 
> ---------
> wic create sdimage-bootpart -e core-image-base -D
> Checking basic build environment...
> Done.
> 
> Creating image(s)...
> 
> <removed for clarity>
>   File 
> "/run/media/rstreif/YoctoDevelop/yocto/poky/scripts/lib/wic/imager/direct.py", 
> line 67, in __init__
>     self.ptable_format = self.ks.bootloader.ptable
> AttributeError: 'NoneType' object has no attribute 'ptable'
> ---------
> 
> 
> The reason for this message is that sdimage-bootpart.wks does not have a 
> bootloader entry and consequently self.ks.bootloader = None.
> 
> As a workaround you can of course simply adding a bootloader entry to the wks 
> even if it's not needed/used when creating an image for Beaglebone etc.
> 
> The question is what the correct behavior should be:
> 
> 1. bootloader entry in wks is mandatory, then the wks parser should flag it as 
> an error if it's not present.
> 
> 2. bootloader entry in wks is optional, then the DirectImageCreator class 
> should be able to handle that correctly.
> 
> 
> I think the latter should be the correct behavior. However, the 
> DirectImageCreator class has some troublesome reliance on that entry, in 
> particular that the source plugin for the overall image creation seems to be, 
> for convenience reasons supposedly, associated with it.
> 
> Cheers,
> Rudi
> -- 
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

-- 
--
Regards,
Ed


  reply	other threads:[~2016-03-02  8:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 16:42 [wic] Creating sdimage-bootpart Rudolf J Streif
2016-03-02  6:47 ` Ed Bartosh [this message]
2016-03-02 19:27   ` Rudolf J Streif
2016-03-02 20:29   ` Maciej Borzecki
2016-03-03  6:41     ` Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302064735.GA21419@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=rudolf.streif@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.