[wic] Creating sdimage-bootpart

[wic] Creating sdimage-bootpart

[Rudolf J Streif]

I tried creating an image with wic using sdimage-bootpart which produces this 
error message:

---------
wic create sdimage-bootpart -e core-image-base -D
Checking basic build environment...
Done.

Creating image(s)...

<removed for clarity>
  File 
"/run/media/rstreif/YoctoDevelop/yocto/poky/scripts/lib/wic/imager/direct.py", 
line 67, in __init__
    self.ptable_format = self.ks.bootloader.ptable
AttributeError: 'NoneType' object has no attribute 'ptable'
---------


The reason for this message is that sdimage-bootpart.wks does not have a 
bootloader entry and consequently self.ks.bootloader = None.

As a workaround you can of course simply adding a bootloader entry to the wks 
even if it's not needed/used when creating an image for Beaglebone etc.

The question is what the correct behavior should be:

1. bootloader entry in wks is mandatory, then the wks parser should flag it as 
an error if it's not present.

2. bootloader entry in wks is optional, then the DirectImageCreator class 
should be able to handle that correctly.


I think the latter should be the correct behavior. However, the 
DirectImageCreator class has some troublesome reliance on that entry, in 
particular that the source plugin for the overall image creation seems to be, 
for convenience reasons supposedly, associated with it.

Cheers,
Rudi

Re: [wic] Creating sdimage-bootpart

[Ed Bartosh]

Hi Rudolf,

Interesting. I thought that this commit shoud fix the issue:
http://cgit.openembedded.org/openembedded-core/commit/?id=264c03e854f77c3b62acb710384f66716ccbf469

Which branch do you use?

On Tue, Mar 01, 2016 at 08:42:02AM -0800, Rudolf J Streif wrote:
> I tried creating an image with wic using sdimage-bootpart which produces this 
> error message:
> 
> ---------
> wic create sdimage-bootpart -e core-image-base -D
> Checking basic build environment...
> Done.
> 
> Creating image(s)...
> 
> <removed for clarity>
>   File 
> "/run/media/rstreif/YoctoDevelop/yocto/poky/scripts/lib/wic/imager/direct.py", 
> line 67, in __init__
>     self.ptable_format = self.ks.bootloader.ptable
> AttributeError: 'NoneType' object has no attribute 'ptable'
> ---------
> 
> 
> The reason for this message is that sdimage-bootpart.wks does not have a 
> bootloader entry and consequently self.ks.bootloader = None.
> 
> As a workaround you can of course simply adding a bootloader entry to the wks 
> even if it's not needed/used when creating an image for Beaglebone etc.
> 
> The question is what the correct behavior should be:
> 
> 1. bootloader entry in wks is mandatory, then the wks parser should flag it as 
> an error if it's not present.
> 
> 2. bootloader entry in wks is optional, then the DirectImageCreator class 
> should be able to handle that correctly.
> 
> 
> I think the latter should be the correct behavior. However, the 
> DirectImageCreator class has some troublesome reliance on that entry, in 
> particular that the source plugin for the overall image creation seems to be, 
> for convenience reasons supposedly, associated with it.
> 
> Cheers,
> Rudi
> -- 
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

-- 
--
Regards,
Ed

Re: [wic] Creating sdimage-bootpart

[Rudolf J Streif]

Hi Ed,

> 
> Interesting. I thought that this commit shoud fix the issue:
> http://cgit.openembedded.org/openembedded-core/commit/?id=264c03e854f77c3b62acb710384f66716ccbf469

Thanks. I was not aware of that patch.

> 
> Which branch do you use?
> 
Jethro. Master seems to be broken right now. It does not compile gdb-7.10.1 (at least not for ARM), which is what I need.

:rjs

Re: [wic] Creating sdimage-bootpart

[Maciej Borzecki]

> Dnia 2 marzec 2016 o 07:47 Ed Bartosh <ed.bartosh@linux.intel.com> napisał(a):
>
>
> Hi Rudolf,
>
> Interesting. I thought that this commit shoud fix the issue:
> http://cgit.openembedded.org/openembedded-core/commit/?id=264c03e854f77c3b62acb710384f66716ccbf469
>
> Which branch do you use?
>

Ed, would it make sense to backport this commit to jethro?

--
Maciej Borzęcki
Senior Software Engineer at Open-RnD Sp. z o.o.
www.open-rnd.pl

Re: [wic] Creating sdimage-bootpart

[Ed Bartosh]

On Wed, Mar 02, 2016 at 09:29:16PM +0100, Maciej Borzecki wrote:
> 
> > Dnia 2 marzec 2016 o 07:47 Ed Bartosh <ed.bartosh@linux.intel.com> napisał(a):
> >
> >
> > Hi Rudolf,
> >
> > Interesting. I thought that this commit shoud fix the issue:
> > http://cgit.openembedded.org/openembedded-core/commit/?id=264c03e854f77c3b62acb710384f66716ccbf469
> >
> > Which branch do you use?
> >


> Ed, would it make sense to backport this commit to jethro?
I don't think if makes sense for 2 reasons:
- this issue is rare and there is a work around it
- backporting it is not easy as it relates to wks parser, which has been
  rewritten from scratch after jethro.

--
Regards,
Ed