From: Pieter Smith <pieter@boesman.nl>
To: buildroot@busybox.net
Subject: [Buildroot] [v3, 1/4] barebox: prepare for secondary config build
Date: Wed, 2 Mar 2016 08:50:49 +0100 [thread overview]
Message-ID: <20160302075049.GA10481@smipidev> (raw)
In-Reply-To: <56D620F2.3090605@mind.be>
On Wed, Mar 02, 2016 at 12:08:34AM +0100, Arnout Vandecappelle wrote:
> On 02/29/16 08:47, Pieter Smith wrote:
[snip]
> >
> > Thanks for the suggestion. It is shaping up nicely. There is one aspect that I
> > would appreciate input on: To all but completely eliminate duplication in the
> > makefiles for the two packages, I am wrapping all the current functionality in
> > boot/barebox/barebox.mk in a parameterized barebox-package function. E.g.:
> >
> > define barebox-package
> > $(1)_VERSION = $$(call qstrip,$$(BR2_TARGET_BAREBOX_VERSION))
> > ...
> > $$(eval $$(kconfig-package))
> > endef
> > $(eval $(call barebox-package,BAREBOX))
> >
> > And the whole of boot/barebox/barebox-2/barebox-2.mk becomes:
> >
> > $(eval $(call barebox-package,BAREBOX_2))
>
> No, I don't think we want this, because it hides a lot of what barebox-2 is
> doing internally. It's OK and actually better (in my opinion) if barebox-2.mk is
> just a long list like:
Pity. This quite elegantly solved my concerns. barebox and barebox-2 differ
only in menuconfig and barebox environment configuration space. The rest should
always be identical.
> BAREBOX_2_VERSION = $(BAREBOX_VERSION)
> BAREBOX_2_SITE = $(BAREBOX_SITE)
This shouldn't change much in future, so I can still do the variable copying if
you prefer.
> BAREBOX_2_BUILD_CMDS = $(BAREBOX_BUILD_CMDS)
This will not work. Both the BAREBOX_BUILD_CMDS and BAREBOX_INSTALL_IMAGES_CMDS
need parameterization. I can solve this with with:
1. A scaled down version of the above barebox-package function to generate the
boilerplate, or
2. Parameterizable functions and duplicated boilerplate.
IMHO reducing duplication always improves clarity and maintenance, so I would
go for option 1.
What has your preference?
> ...
> $(eval $(kconfig-package))
>
>
> Regards,
> Arnout
[snip]
I would like to:
1. Ensure that all improvements to barebox propagate to barebox-2 in future.
2. Avoid having something error-prone to resolve the above. IMHO using a review
process to keep two pieces of code in sync is quite error-prone and an
unnecessary cognitive burden on developers.
- Pieter
next prev parent reply other threads:[~2016-03-02 7:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 22:43 [Buildroot] [v3, 0/4] Supporting building a second Barebox config Pieter Smith
2016-01-20 22:43 ` [Buildroot] [v3, 1/4] barebox: prepare for secondary config build Pieter Smith
2016-02-22 11:03 ` Yegor Yefremov
2016-02-26 23:17 ` Arnout Vandecappelle
2016-02-28 8:12 ` Pieter Smith
2016-02-29 7:47 ` Pieter Smith
2016-03-01 23:08 ` Arnout Vandecappelle
2016-03-02 7:50 ` Pieter Smith [this message]
2016-03-02 18:12 ` Arnout Vandecappelle
2016-03-02 21:32 ` Pieter Smith
2016-03-05 13:16 ` Pieter Smith
2016-03-06 21:16 ` Arnout Vandecappelle
2016-03-07 18:31 ` Pieter Smith
2016-02-29 7:57 ` Pieter Smith
2016-01-20 22:43 ` [Buildroot] [v3, 2/4] barebox: adds option to build secondary config Pieter Smith
2016-02-22 11:03 ` Yegor Yefremov
2016-02-26 23:26 ` Arnout Vandecappelle
2016-02-29 8:01 ` Pieter Smith
2016-01-20 22:43 ` [Buildroot] [v3, 3/4] barebox: user selection of build output images Pieter Smith
2016-02-22 11:03 ` Yegor Yefremov
2016-02-26 23:43 ` Arnout Vandecappelle
2016-02-29 8:38 ` Pieter Smith
2016-03-01 23:14 ` Arnout Vandecappelle
2016-03-02 7:54 ` Pieter Smith
2016-03-02 18:18 ` Arnout Vandecappelle
2016-03-02 21:40 ` Pieter Smith
2016-03-06 23:03 ` Arnout Vandecappelle
2016-01-20 22:43 ` [Buildroot] [v3, 4/4] beaglebone: adds barebox bootloader defconfig Pieter Smith
2016-02-22 11:04 ` Yegor Yefremov
2016-02-26 23:47 ` Arnout Vandecappelle
2016-02-26 23:48 ` Arnout Vandecappelle
2016-02-29 8:44 ` Pieter Smith
2016-03-01 23:15 ` Arnout Vandecappelle
2016-03-02 7:55 ` Pieter Smith
2016-02-16 11:55 ` [Buildroot] [v3, 0/4] Supporting building a second Barebox config Yegor Yefremov
2016-02-16 18:55 ` Pieter Smith
2016-02-16 21:27 ` Yegor Yefremov
2016-02-21 17:25 ` Pieter Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302075049.GA10481@smipidev \
--to=pieter@boesman.nl \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.