From: Lee Jones <lee.jones@linaro.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thierry Reding <treding@nvidia.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] device property: don't bother the drivers with struct property_set
Date: Wed, 2 Mar 2016 13:03:16 +0000 [thread overview]
Message-ID: <20160302130316.GA3444@x1> (raw)
In-Reply-To: <1456485600-129229-1-git-send-email-heikki.krogerus@linux.intel.com>
On Fri, 26 Feb 2016, Heikki Krogerus wrote:
> Since device_add_property_set() now always takes a copy of
> the property_set, and also since the fwnode type is always
> hard coded to be FWNODE_PDATA, there is no need for the
> drivers to deliver the entire struct property_set. The
> function can just create the instance of it on its own and
> bind the properties from the drivers to it on the spot.
>
> This renames device_add_property_set() to
> device_add_properties(). The function now takes struct
> property_entry as its parameter instead of struct
> property_set.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> arch/arm/mach-tegra/board-paz00.c | 6 +-----
> drivers/base/platform.c | 19 ++++++++++---------
> drivers/base/property.c | 35 ++++++++++++++++++++++-------------
> drivers/mfd/intel-lpss-acpi.c | 6 +-----
> drivers/mfd/intel-lpss-pci.c | 14 +++-----------
> drivers/mfd/intel-lpss.c | 2 +-
> drivers/mfd/intel-lpss.h | 2 +-
> drivers/mfd/mfd-core.c | 4 ++--
Acked-by: Lee Jones <lee.jones@linaro.org>
> include/linux/mfd/core.h | 2 +-
> include/linux/platform_device.h | 4 ++--
> include/linux/property.h | 15 +++------------
> 11 files changed, 47 insertions(+), 62 deletions(-)
>
> Hi Rafael,
>
> This depends on Johannes' wireless next tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thierry Reding <treding@nvidia.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] device property: don't bother the drivers with struct property_set
Date: Wed, 2 Mar 2016 13:03:16 +0000 [thread overview]
Message-ID: <20160302130316.GA3444@x1> (raw)
In-Reply-To: <1456485600-129229-1-git-send-email-heikki.krogerus@linux.intel.com>
On Fri, 26 Feb 2016, Heikki Krogerus wrote:
> Since device_add_property_set() now always takes a copy of
> the property_set, and also since the fwnode type is always
> hard coded to be FWNODE_PDATA, there is no need for the
> drivers to deliver the entire struct property_set. The
> function can just create the instance of it on its own and
> bind the properties from the drivers to it on the spot.
>
> This renames device_add_property_set() to
> device_add_properties(). The function now takes struct
> property_entry as its parameter instead of struct
> property_set.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> arch/arm/mach-tegra/board-paz00.c | 6 +-----
> drivers/base/platform.c | 19 ++++++++++---------
> drivers/base/property.c | 35 ++++++++++++++++++++++-------------
> drivers/mfd/intel-lpss-acpi.c | 6 +-----
> drivers/mfd/intel-lpss-pci.c | 14 +++-----------
> drivers/mfd/intel-lpss.c | 2 +-
> drivers/mfd/intel-lpss.h | 2 +-
> drivers/mfd/mfd-core.c | 4 ++--
Acked-by: Lee Jones <lee.jones@linaro.org>
> include/linux/mfd/core.h | 2 +-
> include/linux/platform_device.h | 4 ++--
> include/linux/property.h | 15 +++------------
> 11 files changed, 47 insertions(+), 62 deletions(-)
>
> Hi Rafael,
>
> This depends on Johannes' wireless next tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-03-02 13:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 11:20 [PATCH] device property: don't bother the drivers with struct property_set Heikki Krogerus
2016-02-26 14:35 ` Andy Shevchenko
2016-02-26 14:35 ` Andy Shevchenko
2016-02-26 15:35 ` Thierry Reding
2016-02-26 15:35 ` Thierry Reding
2016-02-29 12:59 ` Mika Westerberg
2016-03-02 13:03 ` Lee Jones [this message]
2016-03-02 13:03 ` Lee Jones
2016-03-15 9:04 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302130316.GA3444@x1 \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.