From: Antonio Quartulli <a@unstable.cc>
To: Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>
Cc: Marek Lindner <mareklindner@neomailbox.ch>,
netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: clarify CFG80211 dependency
Date: Wed, 2 Mar 2016 22:46:07 +0800 [thread overview]
Message-ID: <20160302144607.GH7704@prodigo.lan> (raw)
In-Reply-To: <1456926882-2941809-1-git-send-email-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Wed, Mar 02, 2016 at 02:54:35PM +0100, Arnd Bergmann wrote:
> The driver calls cfg80211_get_station, which may be part of a
> module, so we must not enable BATMAN_ADV_BATMAN_V if
> BATMAN_ADV=y and CFG80211=m:
>
> net/built-in.o: In function `batadv_v_elp_get_throughput':
> (text+0x5c62c): undefined reference to `cfg80211_get_station'
>
> This clarifies the dependency to cover all combinations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
Acked-by: Antonio Quartulli <a@unstable.cc>
Thanks a lot Arnd!
David, could you please merge this change in net-next directly ?
Regards,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: a@unstable.cc (Antonio Quartulli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] batman-adv: clarify CFG80211 dependency
Date: Wed, 2 Mar 2016 22:46:07 +0800 [thread overview]
Message-ID: <20160302144607.GH7704@prodigo.lan> (raw)
In-Reply-To: <1456926882-2941809-1-git-send-email-arnd@arndb.de>
On Wed, Mar 02, 2016 at 02:54:35PM +0100, Arnd Bergmann wrote:
> The driver calls cfg80211_get_station, which may be part of a
> module, so we must not enable BATMAN_ADV_BATMAN_V if
> BATMAN_ADV=y and CFG80211=m:
>
> net/built-in.o: In function `batadv_v_elp_get_throughput':
> (text+0x5c62c): undefined reference to `cfg80211_get_station'
>
> This clarifies the dependency to cover all combinations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
Acked-by: Antonio Quartulli <a@unstable.cc>
Thanks a lot Arnd!
David, could you please merge this change in net-next directly ?
Regards,
--
Antonio Quartulli
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160302/e9d4294e/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <a@unstable.cc>
To: Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>
Cc: linux-arm-kernel@lists.infradead.org,
Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>,
b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] batman-adv: clarify CFG80211 dependency
Date: Wed, 2 Mar 2016 22:46:07 +0800 [thread overview]
Message-ID: <20160302144607.GH7704@prodigo.lan> (raw)
In-Reply-To: <1456926882-2941809-1-git-send-email-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Wed, Mar 02, 2016 at 02:54:35PM +0100, Arnd Bergmann wrote:
> The driver calls cfg80211_get_station, which may be part of a
> module, so we must not enable BATMAN_ADV_BATMAN_V if
> BATMAN_ADV=y and CFG80211=m:
>
> net/built-in.o: In function `batadv_v_elp_get_throughput':
> (text+0x5c62c): undefined reference to `cfg80211_get_station'
>
> This clarifies the dependency to cover all combinations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
Acked-by: Antonio Quartulli <a@unstable.cc>
Thanks a lot Arnd!
David, could you please merge this change in net-next directly ?
Regards,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-02 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 13:54 [B.A.T.M.A.N.] [PATCH] batman-adv: clarify CFG80211 dependency Arnd Bergmann
2016-03-02 13:54 ` Arnd Bergmann
2016-03-02 13:54 ` Arnd Bergmann
2016-03-02 14:46 ` Antonio Quartulli [this message]
2016-03-02 14:46 ` Antonio Quartulli
2016-03-02 14:46 ` Antonio Quartulli
2016-03-02 18:46 ` [B.A.T.M.A.N.] " David Miller
2016-03-02 18:46 ` David Miller
2016-03-02 18:46 ` David Miller
2016-03-02 18:46 ` David Miller
2016-03-02 14:46 ` Antonio Quartulli
2016-03-02 14:46 ` Antonio Quartulli
2016-03-02 14:46 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302144607.GH7704@prodigo.lan \
--to=a@unstable.cc \
--cc=arnd@arndb.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.