All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Kacur <jkacur@redhat.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	<stable-rt@vger.kernel.org>
Subject: [PATCH RT 06/20] net: provide a way to delegate processing a softirq to ksoftirqd
Date: Wed, 02 Mar 2016 10:37:04 -0500	[thread overview]
Message-ID: <20160302153715.035216568@goodmis.org> (raw)
In-Reply-To: 20160302153658.995489487@goodmis.org

[-- Attachment #1: 0006-net-provide-a-way-to-delegate-processing-a-softirq-t.patch --]
[-- Type: text/plain, Size: 2676 bytes --]

3.18.27-rt27-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

If the NET_RX uses up all of his budget it moves the following NAPI
invocations into the `ksoftirqd`. On -RT it does not do so. Instead it
rises the NET_RX softirq in its current context again.

In order to get closer to mainline's behaviour this patch provides
__raise_softirq_irqoff_ksoft() which raises the softirq in the ksoftird.

Cc: stable-rt@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 include/linux/interrupt.h |  8 ++++++++
 kernel/softirq.c          | 21 +++++++++++++++++++++
 net/core/dev.c            |  2 +-
 3 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 86628c733be7..ce50b6ebd65d 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -444,6 +444,14 @@ extern void thread_do_softirq(void);
 extern void open_softirq(int nr, void (*action)(struct softirq_action *));
 extern void softirq_init(void);
 extern void __raise_softirq_irqoff(unsigned int nr);
+#ifdef CONFIG_PREEMPT_RT_FULL
+extern void __raise_softirq_irqoff_ksoft(unsigned int nr);
+#else
+static inline void __raise_softirq_irqoff_ksoft(unsigned int nr)
+{
+	__raise_softirq_irqoff(nr);
+}
+#endif
 
 extern void raise_softirq_irqoff(unsigned int nr);
 extern void raise_softirq(unsigned int nr);
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 40dbf5fcc869..a55e80dca611 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -704,6 +704,27 @@ void __raise_softirq_irqoff(unsigned int nr)
 }
 
 /*
+ * Same as __raise_softirq_irqoff() but will process them in ksoftirqd
+ */
+void __raise_softirq_irqoff_ksoft(unsigned int nr)
+{
+	unsigned int mask;
+
+	if (WARN_ON_ONCE(!__this_cpu_read(ksoftirqd) ||
+			 !__this_cpu_read(ktimer_softirqd)))
+		return;
+	mask = 1UL << nr;
+
+	trace_softirq_raise(nr);
+	or_softirq_pending(mask);
+	if (mask & TIMER_SOFTIRQS)
+		__this_cpu_read(ktimer_softirqd)->softirqs_raised |= mask;
+	else
+		__this_cpu_read(ksoftirqd)->softirqs_raised |= mask;
+	wakeup_proper_softirq(nr);
+}
+
+/*
  * This function must run with irqs disabled!
  */
 void raise_softirq_irqoff(unsigned int nr)
diff --git a/net/core/dev.c b/net/core/dev.c
index b89a1dd9f4d8..da674bb38606 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4679,7 +4679,7 @@ out:
 
 softnet_break:
 	sd->time_squeeze++;
-	__raise_softirq_irqoff(NET_RX_SOFTIRQ);
+	__raise_softirq_irqoff_ksoft(NET_RX_SOFTIRQ);
 	goto out;
 }
 
-- 
2.7.0

  parent reply	other threads:[~2016-03-02 15:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 15:36 [PATCH RT 00/20] Linux 3.18.27-rt27-rc1 Steven Rostedt
2016-03-02 15:36 ` [PATCH RT 01/20] sched: reset tasks lockless wake-queues on fork() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 02/20] ptrace: dont open IRQs in ptrace_freeze_traced() too early Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 03/20] net: move xmit_recursion to per-task variable on -RT Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 04/20] preempt-lazy: Add the lazy-preemption check to preempt_schedule() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 05/20] softirq: split timer softirqs out of ksoftirqd Steven Rostedt
2016-03-02 15:37 ` Steven Rostedt [this message]
2016-03-02 15:37 ` [PATCH RT 07/20] latencyhist: disable jump-labels Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 08/20] arm64: replace read_lock to rcu lock in call_step_hook Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 09/20] kernel: migrate_disable() do fastpath in atomic & irqs-off Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 10/20] kernel: softirq: unlock with irqs on Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 11/20] kernel/stop_machine: partly revert "stop_machine: Use raw spinlocks" Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 12/20] tick/broadcast: Make broadcast hrtimer irqsafe Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 13/20] sched,rt: __always_inline preemptible_lazy() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 14/20] drm,radeon,i915: Use preempt_disable/enable_rt() where recommended Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 15/20] drm,i915: Use local_lock/unlock_irq() in intel_pipe_update_start/end() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 16/20] trace: Use rcuidle version for preemptoff_hist trace point Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 17/20] f2fs: Mutex cant be used by down_write_nest_lock() Steven Rostedt
2016-03-02 15:37   ` Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 18/20] rcu/torture: Comment out rcu_bh ops on PREEMPT_RT_FULL Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 19/20] kernel: sched: Fix preempt_disable_ip recodring for preempt_disable() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 20/20] Linux 3.18.27-rt27-rc1 Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302153715.035216568@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=stable-rt@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.