From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Kacur <jkacur@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH RT 10/20] kernel: softirq: unlock with irqs on
Date: Wed, 02 Mar 2016 10:37:08 -0500 [thread overview]
Message-ID: <20160302153715.971402628@goodmis.org> (raw)
In-Reply-To: 20160302153658.995489487@goodmis.org
[-- Attachment #1: 0010-kernel-softirq-unlock-with-irqs-on.patch --]
[-- Type: text/plain, Size: 983 bytes --]
3.18.27-rt27-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
We unlock the lock while the interrupts are off. This isn't a problem
now but will get because the migrate_disable() + enable are not
symmetrical in regard to the status of interrupts.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/softirq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index a55e80dca611..0b1f914e4639 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -564,8 +564,10 @@ static void do_current_softirqs(int need_rcu_bh_qs)
do_single_softirq(i, need_rcu_bh_qs);
}
softirq_clr_runner(i);
- unlock_softirq(i);
WARN_ON(current->softirq_nestcnt != 1);
+ local_irq_enable();
+ unlock_softirq(i);
+ local_irq_disable();
}
}
--
2.7.0
next prev parent reply other threads:[~2016-03-02 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 15:36 [PATCH RT 00/20] Linux 3.18.27-rt27-rc1 Steven Rostedt
2016-03-02 15:36 ` [PATCH RT 01/20] sched: reset tasks lockless wake-queues on fork() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 02/20] ptrace: dont open IRQs in ptrace_freeze_traced() too early Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 03/20] net: move xmit_recursion to per-task variable on -RT Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 04/20] preempt-lazy: Add the lazy-preemption check to preempt_schedule() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 05/20] softirq: split timer softirqs out of ksoftirqd Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 06/20] net: provide a way to delegate processing a softirq to ksoftirqd Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 07/20] latencyhist: disable jump-labels Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 08/20] arm64: replace read_lock to rcu lock in call_step_hook Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 09/20] kernel: migrate_disable() do fastpath in atomic & irqs-off Steven Rostedt
2016-03-02 15:37 ` Steven Rostedt [this message]
2016-03-02 15:37 ` [PATCH RT 11/20] kernel/stop_machine: partly revert "stop_machine: Use raw spinlocks" Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 12/20] tick/broadcast: Make broadcast hrtimer irqsafe Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 13/20] sched,rt: __always_inline preemptible_lazy() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 14/20] drm,radeon,i915: Use preempt_disable/enable_rt() where recommended Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 15/20] drm,i915: Use local_lock/unlock_irq() in intel_pipe_update_start/end() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 16/20] trace: Use rcuidle version for preemptoff_hist trace point Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 17/20] f2fs: Mutex cant be used by down_write_nest_lock() Steven Rostedt
2016-03-02 15:37 ` Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 18/20] rcu/torture: Comment out rcu_bh ops on PREEMPT_RT_FULL Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 19/20] kernel: sched: Fix preempt_disable_ip recodring for preempt_disable() Steven Rostedt
2016-03-02 15:37 ` [PATCH RT 20/20] Linux 3.18.27-rt27-rc1 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302153715.971402628@goodmis.org \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.