* [PATCH v2] staging: lustre: ptlrpc: Use macro DIV_ROUND_UP
@ 2016-02-27 19:00 Bhaktipriya Shridhar
2016-03-02 16:25 ` [Outreachy kernel] " Greg KH
2016-03-02 18:49 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Bhaktipriya Shridhar @ 2016-02-27 19:00 UTC (permalink / raw)
To: outreachy-kernel
The macro DIV_ROUND_UP performs the computation
(((n) + (d) - 1) /(d)). It clarifies the divisor calculations.
This was done using the coccinelle script:
@@
expression e1;
expression e2;
@@
(
- ((e1) + e2 - 1) / (e2)
+ DIV_ROUND_UP(e1,e2)
|
- ((e1) + (e2 - 1)) / (e2)
+ DIV_ROUND_UP(e1,e2)
)
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
Changes in v2:
-Fixed typo "lusture" to "lustre" in the subject
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
index 72d5b9b..0d58d8e 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
@@ -274,7 +274,7 @@ static unsigned long enc_pools_shrink_scan(struct shrinker *s,
static inline
int npages_to_npools(unsigned long npages)
{
- return (int) ((npages + PAGES_PER_POOL - 1) / PAGES_PER_POOL);
+ return (int) (DIV_ROUND_UP(npages, PAGES_PER_POOL));
}
/*
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH v2] staging: lustre: ptlrpc: Use macro DIV_ROUND_UP
2016-02-27 19:00 [PATCH v2] staging: lustre: ptlrpc: Use macro DIV_ROUND_UP Bhaktipriya Shridhar
@ 2016-03-02 16:25 ` Greg KH
2016-03-02 18:49 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-03-02 16:25 UTC (permalink / raw)
To: Bhaktipriya Shridhar; +Cc: outreachy-kernel
On Sun, Feb 28, 2016 at 12:30:36AM +0530, Bhaktipriya Shridhar wrote:
> The macro DIV_ROUND_UP performs the computation
> (((n) + (d) - 1) /(d)). It clarifies the divisor calculations.
> This was done using the coccinelle script:
> @@
> expression e1;
> expression e2;
> @@
> (
> - ((e1) + e2 - 1) / (e2)
> + DIV_ROUND_UP(e1,e2)
> |
> - ((e1) + (e2 - 1)) / (e2)
> + DIV_ROUND_UP(e1,e2)
> )
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> Changes in v2:
> -Fixed typo "lusture" to "lustre" in the subject
Please pick better subjects, you use pretty much the same thing twice
here :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: lustre: ptlrpc: Use macro DIV_ROUND_UP
2016-02-27 19:00 [PATCH v2] staging: lustre: ptlrpc: Use macro DIV_ROUND_UP Bhaktipriya Shridhar
2016-03-02 16:25 ` [Outreachy kernel] " Greg KH
@ 2016-03-02 18:49 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-03-02 18:49 UTC (permalink / raw)
To: Bhaktipriya Shridhar; +Cc: outreachy-kernel
On Sun, Feb 28, 2016 at 12:30:36AM +0530, Bhaktipriya Shridhar wrote:
> The macro DIV_ROUND_UP performs the computation
> (((n) + (d) - 1) /(d)). It clarifies the divisor calculations.
> This was done using the coccinelle script:
> @@
> expression e1;
> expression e2;
> @@
> (
> - ((e1) + e2 - 1) / (e2)
> + DIV_ROUND_UP(e1,e2)
> |
> - ((e1) + (e2 - 1)) / (e2)
> + DIV_ROUND_UP(e1,e2)
> )
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> Changes in v2:
> -Fixed typo "lusture" to "lustre" in the subject
Please pick better subjects, you use pretty much the same thing twice
here :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-02 18:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-27 19:00 [PATCH v2] staging: lustre: ptlrpc: Use macro DIV_ROUND_UP Bhaktipriya Shridhar
2016-03-02 16:25 ` [Outreachy kernel] " Greg KH
2016-03-02 18:49 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.