* [PATCH 2/2] Staging: lustre: lnet: Remove int typecast of offsetof().
@ 2016-02-28 9:20 Sandhya Bankar
2016-03-02 16:25 ` [Outreachy kernel] " Greg KH
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sandhya Bankar @ 2016-02-28 9:20 UTC (permalink / raw)
To: outreachy-kernel
Remove int typecast of offsetof().
As per below coccinelle rule:
@@
type T;
expression E;
@@
- (int)(offsetof(T,E))
+ offsetof(T,E)
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 54 +++++++++++++++----------------
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 3ecc96a..c3fe782 100644
--- a/drivers/staging/lustre/lnet/lnet/api-ni.c
+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
@@ -197,75 +197,75 @@ static void lnet_assert_wire_constants(void)
CLASSERT((int)sizeof(lnet_handle_wire_t) == 16);
CLASSERT((int)offsetof(lnet_handle_wire_t, wh_interface_cookie) == 0);
CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_interface_cookie) == 8);
- CLASSERT((int)offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
+ CLASSERT(offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_object_cookie) == 8);
/* Checks for struct lnet_magicversion_t */
CLASSERT((int)sizeof(lnet_magicversion_t) == 8);
CLASSERT((int)offsetof(lnet_magicversion_t, magic) == 0);
CLASSERT((int)sizeof(((lnet_magicversion_t *)0)->magic) == 4);
- CLASSERT((int)offsetof(lnet_magicversion_t, version_major) == 4);
+ CLASSERT(offsetof(lnet_magicversion_t, version_major) == 4);
CLASSERT((int)sizeof(((lnet_magicversion_t *)0)->version_major) == 2);
- CLASSERT((int)offsetof(lnet_magicversion_t, version_minor) == 6);
+ CLASSERT(offsetof(lnet_magicversion_t, version_minor) == 6);
CLASSERT((int)sizeof(((lnet_magicversion_t *)0)->version_minor) == 2);
/* Checks for struct lnet_hdr_t */
CLASSERT((int)sizeof(lnet_hdr_t) == 72);
CLASSERT((int)offsetof(lnet_hdr_t, dest_nid) == 0);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->dest_nid) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, src_nid) == 8);
+ CLASSERT(offsetof(lnet_hdr_t, src_nid) == 8);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->src_nid) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, dest_pid) == 16);
+ CLASSERT(offsetof(lnet_hdr_t, dest_pid) == 16);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->dest_pid) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, src_pid) == 20);
+ CLASSERT(offsetof(lnet_hdr_t, src_pid) == 20);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->src_pid) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, type) == 24);
+ CLASSERT(offsetof(lnet_hdr_t, type) == 24);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->type) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, payload_length) == 28);
+ CLASSERT(offsetof(lnet_hdr_t, payload_length) == 28);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->payload_length) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, msg) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg) == 40);
/* Ack */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.ack.dst_wmd) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.ack.dst_wmd) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.ack.dst_wmd) == 16);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.ack.match_bits) == 48);
+ CLASSERT(offsetof(lnet_hdr_t, msg.ack.match_bits) == 48);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.ack.match_bits) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.ack.mlength) == 56);
+ CLASSERT(offsetof(lnet_hdr_t, msg.ack.mlength) == 56);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.ack.mlength) == 4);
/* Put */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.ack_wmd) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.ack_wmd) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.ack_wmd) == 16);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.match_bits) == 48);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.match_bits) == 48);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.match_bits) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.hdr_data) == 56);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.hdr_data) == 56);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.hdr_data) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.ptl_index) == 64);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.ptl_index) == 64);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.ptl_index) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.put.offset) == 68);
+ CLASSERT(offsetof(lnet_hdr_t, msg.put.offset) == 68);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.offset) == 4);
/* Get */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.return_wmd) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.return_wmd) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.return_wmd) == 16);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.match_bits) == 48);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.match_bits) == 48);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.match_bits) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.ptl_index) == 56);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.ptl_index) == 56);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.ptl_index) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.src_offset) == 60);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.src_offset) == 60);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.src_offset) == 4);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.get.sink_length) == 64);
+ CLASSERT(offsetof(lnet_hdr_t, msg.get.sink_length) == 64);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.sink_length) == 4);
/* Reply */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.reply.dst_wmd) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.reply.dst_wmd) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.reply.dst_wmd) == 16);
/* Hello */
- CLASSERT((int)offsetof(lnet_hdr_t, msg.hello.incarnation) == 32);
+ CLASSERT(offsetof(lnet_hdr_t, msg.hello.incarnation) == 32);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.hello.incarnation) == 8);
- CLASSERT((int)offsetof(lnet_hdr_t, msg.hello.type) == 40);
+ CLASSERT(offsetof(lnet_hdr_t, msg.hello.type) == 40);
CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.hello.type) == 4);
}
@@ -2266,7 +2266,7 @@ static int lnet_ping(lnet_process_id_t id, int timeout_ms,
if (nob < offsetof(lnet_ping_info_t, pi_ni[0])) {
CERROR("%s: Short reply %d(%d min)\n", libcfs_id2str(id),
- nob, (int)offsetof(lnet_ping_info_t, pi_ni[0]));
+ nob, offsetof(lnet_ping_info_t, pi_ni[0]));
goto out_1;
}
@@ -2275,7 +2275,7 @@ static int lnet_ping(lnet_process_id_t id, int timeout_ms,
if (nob < offsetof(lnet_ping_info_t, pi_ni[n_ids])) {
CERROR("%s: Short reply %d(%d expected)\n", libcfs_id2str(id),
- nob, (int)offsetof(lnet_ping_info_t, pi_ni[n_ids]));
+ nob, offsetof(lnet_ping_info_t, pi_ni[n_ids]));
goto out_1;
}
--
1.8.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH 2/2] Staging: lustre: lnet: Remove int typecast of offsetof().
2016-02-28 9:20 [PATCH 2/2] Staging: lustre: lnet: Remove int typecast of offsetof() Sandhya Bankar
@ 2016-03-02 16:25 ` Greg KH
2016-03-02 18:46 ` sandhya bankar
2016-03-02 18:48 ` [Outreachy kernel] " Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-03-02 16:25 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
On Sun, Feb 28, 2016 at 02:50:07PM +0530, Sandhya Bankar wrote:
> Remove int typecast of offsetof().
> As per below coccinelle rule:
>
> @@
> type T;
> expression E;
> @@
>
> - (int)(offsetof(T,E))
> + offsetof(T,E)
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/lustre/lnet/lnet/api-ni.c | 54 +++++++++++++++----------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
> index 3ecc96a..c3fe782 100644
> --- a/drivers/staging/lustre/lnet/lnet/api-ni.c
> +++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
> @@ -197,75 +197,75 @@ static void lnet_assert_wire_constants(void)
> CLASSERT((int)sizeof(lnet_handle_wire_t) == 16);
> CLASSERT((int)offsetof(lnet_handle_wire_t, wh_interface_cookie) == 0);
> CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_interface_cookie) == 8);
> - CLASSERT((int)offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
> + CLASSERT(offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
> CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_object_cookie) == 8);
Why did you only change 1 of them here and not all instances?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Staging: lustre: lnet: Remove int typecast of offsetof().
2016-02-28 9:20 [PATCH 2/2] Staging: lustre: lnet: Remove int typecast of offsetof() Sandhya Bankar
2016-03-02 16:25 ` [Outreachy kernel] " Greg KH
@ 2016-03-02 18:46 ` sandhya bankar
2016-03-02 18:48 ` [Outreachy kernel] " Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: sandhya bankar @ 2016-03-02 18:46 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 8035 bytes --]
Thanks.!! I will send fresh patch for the same.
On Sunday, February 28, 2016 at 10:50:02 PM UTC+5:30, sandhya bankar wrote:
>
> Remove int typecast of offsetof().
> As per below coccinelle rule:
>
> @@
> type T;
> expression E;
> @@
>
> - (int)(offsetof(T,E))
> + offsetof(T,E)
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/lustre/lnet/lnet/api-ni.c | 54
> +++++++++++++++----------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c
> b/drivers/staging/lustre/lnet/lnet/api-ni.c
> index 3ecc96a..c3fe782 100644
> --- a/drivers/staging/lustre/lnet/lnet/api-ni.c
> +++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
> @@ -197,75 +197,75 @@ static void lnet_assert_wire_constants(void)
> CLASSERT((int)sizeof(lnet_handle_wire_t) == 16);
> CLASSERT((int)offsetof(lnet_handle_wire_t, wh_interface_cookie)
> == 0);
> CLASSERT((int)sizeof(((lnet_handle_wire_t
> *)0)->wh_interface_cookie) == 8);
> - CLASSERT((int)offsetof(lnet_handle_wire_t, wh_object_cookie) ==
> 8);
> + CLASSERT(offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
> CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_object_cookie)
> == 8);
>
> /* Checks for struct lnet_magicversion_t */
> CLASSERT((int)sizeof(lnet_magicversion_t) == 8);
> CLASSERT((int)offsetof(lnet_magicversion_t, magic) == 0);
> CLASSERT((int)sizeof(((lnet_magicversion_t *)0)->magic) == 4);
> - CLASSERT((int)offsetof(lnet_magicversion_t, version_major) == 4);
> + CLASSERT(offsetof(lnet_magicversion_t, version_major) == 4);
> CLASSERT((int)sizeof(((lnet_magicversion_t *)0)->version_major)
> == 2);
> - CLASSERT((int)offsetof(lnet_magicversion_t, version_minor) == 6);
> + CLASSERT(offsetof(lnet_magicversion_t, version_minor) == 6);
> CLASSERT((int)sizeof(((lnet_magicversion_t *)0)->version_minor)
> == 2);
>
> /* Checks for struct lnet_hdr_t */
> CLASSERT((int)sizeof(lnet_hdr_t) == 72);
> CLASSERT((int)offsetof(lnet_hdr_t, dest_nid) == 0);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->dest_nid) == 8);
> - CLASSERT((int)offsetof(lnet_hdr_t, src_nid) == 8);
> + CLASSERT(offsetof(lnet_hdr_t, src_nid) == 8);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->src_nid) == 8);
> - CLASSERT((int)offsetof(lnet_hdr_t, dest_pid) == 16);
> + CLASSERT(offsetof(lnet_hdr_t, dest_pid) == 16);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->dest_pid) == 4);
> - CLASSERT((int)offsetof(lnet_hdr_t, src_pid) == 20);
> + CLASSERT(offsetof(lnet_hdr_t, src_pid) == 20);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->src_pid) == 4);
> - CLASSERT((int)offsetof(lnet_hdr_t, type) == 24);
> + CLASSERT(offsetof(lnet_hdr_t, type) == 24);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->type) == 4);
> - CLASSERT((int)offsetof(lnet_hdr_t, payload_length) == 28);
> + CLASSERT(offsetof(lnet_hdr_t, payload_length) == 28);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->payload_length) == 4);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg) == 32);
> + CLASSERT(offsetof(lnet_hdr_t, msg) == 32);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg) == 40);
>
> /* Ack */
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.ack.dst_wmd) == 32);
> + CLASSERT(offsetof(lnet_hdr_t, msg.ack.dst_wmd) == 32);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.ack.dst_wmd) == 16);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.ack.match_bits) == 48);
> + CLASSERT(offsetof(lnet_hdr_t, msg.ack.match_bits) == 48);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.ack.match_bits) ==
> 8);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.ack.mlength) == 56);
> + CLASSERT(offsetof(lnet_hdr_t, msg.ack.mlength) == 56);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.ack.mlength) == 4);
>
> /* Put */
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.put.ack_wmd) == 32);
> + CLASSERT(offsetof(lnet_hdr_t, msg.put.ack_wmd) == 32);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.ack_wmd) == 16);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.put.match_bits) == 48);
> + CLASSERT(offsetof(lnet_hdr_t, msg.put.match_bits) == 48);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.match_bits) ==
> 8);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.put.hdr_data) == 56);
> + CLASSERT(offsetof(lnet_hdr_t, msg.put.hdr_data) == 56);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.hdr_data) == 8);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.put.ptl_index) == 64);
> + CLASSERT(offsetof(lnet_hdr_t, msg.put.ptl_index) == 64);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.ptl_index) == 4);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.put.offset) == 68);
> + CLASSERT(offsetof(lnet_hdr_t, msg.put.offset) == 68);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.put.offset) == 4);
>
> /* Get */
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.get.return_wmd) == 32);
> + CLASSERT(offsetof(lnet_hdr_t, msg.get.return_wmd) == 32);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.return_wmd) ==
> 16);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.get.match_bits) == 48);
> + CLASSERT(offsetof(lnet_hdr_t, msg.get.match_bits) == 48);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.match_bits) ==
> 8);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.get.ptl_index) == 56);
> + CLASSERT(offsetof(lnet_hdr_t, msg.get.ptl_index) == 56);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.ptl_index) == 4);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.get.src_offset) == 60);
> + CLASSERT(offsetof(lnet_hdr_t, msg.get.src_offset) == 60);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.src_offset) ==
> 4);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.get.sink_length) == 64);
> + CLASSERT(offsetof(lnet_hdr_t, msg.get.sink_length) == 64);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.get.sink_length) ==
> 4);
>
> /* Reply */
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.reply.dst_wmd) == 32);
> + CLASSERT(offsetof(lnet_hdr_t, msg.reply.dst_wmd) == 32);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.reply.dst_wmd) ==
> 16);
>
> /* Hello */
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.hello.incarnation) == 32);
> + CLASSERT(offsetof(lnet_hdr_t, msg.hello.incarnation) == 32);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.hello.incarnation) ==
> 8);
> - CLASSERT((int)offsetof(lnet_hdr_t, msg.hello.type) == 40);
> + CLASSERT(offsetof(lnet_hdr_t, msg.hello.type) == 40);
> CLASSERT((int)sizeof(((lnet_hdr_t *)0)->msg.hello.type) == 4);
> }
>
> @@ -2266,7 +2266,7 @@ static int lnet_ping(lnet_process_id_t id, int
> timeout_ms,
>
> if (nob < offsetof(lnet_ping_info_t, pi_ni[0])) {
> CERROR("%s: Short reply %d(%d min)\n", libcfs_id2str(id),
> - nob, (int)offsetof(lnet_ping_info_t, pi_ni[0]));
> + nob, offsetof(lnet_ping_info_t, pi_ni[0]));
> goto out_1;
> }
>
> @@ -2275,7 +2275,7 @@ static int lnet_ping(lnet_process_id_t id, int
> timeout_ms,
>
> if (nob < offsetof(lnet_ping_info_t, pi_ni[n_ids])) {
> CERROR("%s: Short reply %d(%d expected)\n",
> libcfs_id2str(id),
> - nob, (int)offsetof(lnet_ping_info_t,
> pi_ni[n_ids]));
> + nob, offsetof(lnet_ping_info_t, pi_ni[n_ids]));
> goto out_1;
> }
>
> --
> 1.8.3.4
>
>
[-- Attachment #1.2: Type: text/html, Size: 10215 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH 2/2] Staging: lustre: lnet: Remove int typecast of offsetof().
2016-02-28 9:20 [PATCH 2/2] Staging: lustre: lnet: Remove int typecast of offsetof() Sandhya Bankar
2016-03-02 16:25 ` [Outreachy kernel] " Greg KH
2016-03-02 18:46 ` sandhya bankar
@ 2016-03-02 18:48 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-03-02 18:48 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
On Sun, Feb 28, 2016 at 02:50:07PM +0530, Sandhya Bankar wrote:
> Remove int typecast of offsetof().
> As per below coccinelle rule:
>
> @@
> type T;
> expression E;
> @@
>
> - (int)(offsetof(T,E))
> + offsetof(T,E)
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/lustre/lnet/lnet/api-ni.c | 54 +++++++++++++++----------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
> index 3ecc96a..c3fe782 100644
> --- a/drivers/staging/lustre/lnet/lnet/api-ni.c
> +++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
> @@ -197,75 +197,75 @@ static void lnet_assert_wire_constants(void)
> CLASSERT((int)sizeof(lnet_handle_wire_t) == 16);
> CLASSERT((int)offsetof(lnet_handle_wire_t, wh_interface_cookie) == 0);
> CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_interface_cookie) == 8);
> - CLASSERT((int)offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
> + CLASSERT(offsetof(lnet_handle_wire_t, wh_object_cookie) == 8);
> CLASSERT((int)sizeof(((lnet_handle_wire_t *)0)->wh_object_cookie) == 8);
Why did you only change 1 of them here and not all instances?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-02 18:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-28 9:20 [PATCH 2/2] Staging: lustre: lnet: Remove int typecast of offsetof() Sandhya Bankar
2016-03-02 16:25 ` [Outreachy kernel] " Greg KH
2016-03-02 18:46 ` sandhya bankar
2016-03-02 18:48 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.