[PATCH stable-4.4] block: Initialize max_dev_sectors to 0

[PATCH stable-4.4] block: Initialize max_dev_sectors to 0

[Keith Busch]

commit 5f009d3f8e6685fe8c6215082c1696a08b411220 upstream

The new queue limit is not used by the majority of block drivers, and
should be initialized to 0 for the driver's requested settings to be used.

Signed-off-by: Keith Busch <keith.busch@intel.com>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
---
 block/blk-settings.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index dd49735..c7bb666 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -91,8 +91,8 @@ void blk_set_default_limits(struct queue_limits *lim)
 	lim->seg_boundary_mask = BLK_SEG_BOUNDARY_MASK;
 	lim->virt_boundary_mask = 0;
 	lim->max_segment_size = BLK_MAX_SEGMENT_SIZE;
-	lim->max_sectors = lim->max_dev_sectors = lim->max_hw_sectors =
-		BLK_SAFE_MAX_SECTORS;
+	lim->max_sectors = lim->max_hw_sectors = BLK_SAFE_MAX_SECTORS;
+	lim->max_dev_sectors = 0;
 	lim->chunk_sectors = 0;
 	lim->max_write_same_sectors = 0;
 	lim->max_discard_sectors = 0;
-- 
2.6.2.307.g37023ba

Re: [PATCH stable-4.4] block: Initialize max_dev_sectors to 0

[Greg KH]

On Wed, Mar 02, 2016 at 03:38:31PM -0700, Keith Busch wrote:
> commit 5f009d3f8e6685fe8c6215082c1696a08b411220 upstream
> 
> The new queue limit is not used by the majority of block drivers, and
> should be initialized to 0 for the driver's requested settings to be used.
> 
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
> Reviewed-by: Christoph Hellwig <hch@infradead.org>
> Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
> Signed-off-by: Jens Axboe <axboe@fb.com>
> ---
>  block/blk-settings.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

What stable version(s) do you want this to go to?

greg k-h

Re: [PATCH stable-4.4] block: Initialize max_dev_sectors to 0

[Keith Busch]

On Wed, Mar 02, 2016 at 03:06:53PM -0800, Greg KH wrote:
> On Wed, Mar 02, 2016 at 03:38:31PM -0700, Keith Busch wrote:
> > commit 5f009d3f8e6685fe8c6215082c1696a08b411220 upstream
> > 
> > The new queue limit is not used by the majority of block drivers, and
> > should be initialized to 0 for the driver's requested settings to be used.
> > 
> > Signed-off-by: Keith Busch <keith.busch@intel.com>
> > Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
> > Reviewed-by: Christoph Hellwig <hch@infradead.org>
> > Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
> > Signed-off-by: Jens Axboe <axboe@fb.com>
> > ---
> >  block/blk-settings.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> What stable version(s) do you want this to go to?
> 
> greg k-h

Just to 4.4. The issue this fixes was introduced with that release.