From: Vinod Koul <vinod.koul@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sudeep Dutt <sudeep.dutt@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo
Date: Thu, 03 Mar 2016 15:55:46 +0000 [thread overview]
Message-ID: <20160303154346.GP11154@localhost> (raw)
In-Reply-To: <20160229095107.GA32061@mwanda>
On Mon, Feb 29, 2016 at 12:51:07PM +0300, Dan Carpenter wrote:
> This is harmless because the caller only cares about zero vs non-zero
> but we should be returning PTR_ERR() here.
Applied thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sudeep Dutt <sudeep.dutt@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo
Date: Thu, 3 Mar 2016 21:13:46 +0530 [thread overview]
Message-ID: <20160303154346.GP11154@localhost> (raw)
In-Reply-To: <20160229095107.GA32061@mwanda>
On Mon, Feb 29, 2016 at 12:51:07PM +0300, Dan Carpenter wrote:
> This is harmless because the caller only cares about zero vs non-zero
> but we should be returning PTR_ERR() here.
Applied thanks
--
~Vinod
next prev parent reply other threads:[~2016-03-03 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 9:51 [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo Dan Carpenter
2016-02-29 9:51 ` Dan Carpenter
2016-03-03 15:43 ` Vinod Koul [this message]
2016-03-03 15:55 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303154346.GP11154@localhost \
--to=vinod.koul@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.