From: Wolfram Sang <wsa@the-dreams.de>
To: Liguo Zhang <liguo.zhang@mediatek.com>
Cc: srv_heupstream@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Xudong Chen <xudong.chen@mediatek.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] i2c: mediatek: i2c multi transfer optimization
Date: Thu, 3 Mar 2016 22:18:35 +0100 [thread overview]
Message-ID: <20160303211835.GC1501@katana> (raw)
In-Reply-To: <1456421739-5450-1-git-send-email-liguo.zhang@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
On Fri, Feb 26, 2016 at 01:35:39AM +0800, Liguo Zhang wrote:
> Send the next transfer in the i2c irq handler, and only signal
> complete() when the entire transaction has been completed.
This describes what you do. But not why. Is this an improvment of
throughput? Is there a downside of interrupt latency?
Thanks.
>
> Signed-off-by: Liguo Zhang <liguo.zhang@mediatek.com>
> ---
> change in v2:
> Remove the unused variable left_num in mtk_i2c_transfer().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] i2c: mediatek: i2c multi transfer optimization
Date: Thu, 3 Mar 2016 22:18:35 +0100 [thread overview]
Message-ID: <20160303211835.GC1501@katana> (raw)
In-Reply-To: <1456421739-5450-1-git-send-email-liguo.zhang@mediatek.com>
On Fri, Feb 26, 2016 at 01:35:39AM +0800, Liguo Zhang wrote:
> Send the next transfer in the i2c irq handler, and only signal
> complete() when the entire transaction has been completed.
This describes what you do. But not why. Is this an improvment of
throughput? Is there a downside of interrupt latency?
Thanks.
>
> Signed-off-by: Liguo Zhang <liguo.zhang@mediatek.com>
> ---
> change in v2:
> Remove the unused variable left_num in mtk_i2c_transfer().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160303/273deaa9/attachment.sig>
next prev parent reply other threads:[~2016-03-03 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 17:35 [PATCH v2] i2c: mediatek: i2c multi transfer optimization Liguo Zhang
2016-02-25 17:35 ` Liguo Zhang
2016-02-25 17:35 ` Liguo Zhang
2016-03-03 21:18 ` Wolfram Sang [this message]
2016-03-03 21:18 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303211835.GC1501@katana \
--to=wsa@the-dreams.de \
--cc=eddie.huang@mediatek.com \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=xudong.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.