From: Peter Xu <peterx@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com,
armbru@redhat.com, abologna@redhat.com, qemu-devel@nongnu.org,
qemu-arm@nongnu.org
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v2 2/3] arm: qmp: add query-gic-capability interface
Date: Fri, 4 Mar 2016 10:22:08 +0800 [thread overview]
Message-ID: <20160304022208.GE30973@pxdev.xzpeter.org> (raw)
In-Reply-To: <20160303115551.oaswd6litrm2tz3v@hawk.localdomain>
On Thu, Mar 03, 2016 at 12:55:51PM +0100, Andrew Jones wrote:
> On Thu, Mar 03, 2016 at 04:21:11PM +0800, Peter Xu wrote:
> > +
> > +GICCapabilityList *qmp_query_gic_capability(Error **errp);
>
> I don't know anything about QMP, so just offering a superficial
> review comment. Is the prototype necessary here? It seems redundant,
> considering the function is defined right below.
>
> drew
I added this to avoid a "missing prototype" warning. However found
the correct way to do it is possibly to include "qmp-commands.h" in
target-arm/machine.c. Thanks to point out! Will fix.
Peter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: wei@redhat.com, peter.maydell@linaro.org,
mdroth@linux.vnet.ibm.com, armbru@redhat.com,
abologna@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/3] arm: qmp: add query-gic-capability interface
Date: Fri, 4 Mar 2016 10:22:08 +0800 [thread overview]
Message-ID: <20160304022208.GE30973@pxdev.xzpeter.org> (raw)
In-Reply-To: <20160303115551.oaswd6litrm2tz3v@hawk.localdomain>
On Thu, Mar 03, 2016 at 12:55:51PM +0100, Andrew Jones wrote:
> On Thu, Mar 03, 2016 at 04:21:11PM +0800, Peter Xu wrote:
> > +
> > +GICCapabilityList *qmp_query_gic_capability(Error **errp);
>
> I don't know anything about QMP, so just offering a superficial
> review comment. Is the prototype necessary here? It seems redundant,
> considering the function is defined right below.
>
> drew
I added this to avoid a "missing prototype" warning. However found
the correct way to do it is possibly to include "qmp-commands.h" in
target-arm/machine.c. Thanks to point out! Will fix.
Peter
next prev parent reply other threads:[~2016-03-04 2:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 8:21 [Qemu-devel] [PATCH v2 0/3] ARM: add query-gic-capability SMP command Peter Xu
2016-03-03 8:21 ` [Qemu-devel] [PATCH v2 1/3] arm: qmp: add GICCapability struct Peter Xu
2016-03-03 8:21 ` [Qemu-devel] [PATCH v2 2/3] arm: qmp: add query-gic-capability interface Peter Xu
2016-03-03 11:55 ` [Qemu-arm] " Andrew Jones
2016-03-03 11:55 ` Andrew Jones
2016-03-04 2:22 ` Peter Xu [this message]
2016-03-04 2:22 ` Peter Xu
2016-03-03 8:21 ` [Qemu-devel] [PATCH v2 3/3] arm: implement query-gic-capability Peter Xu
2016-03-03 12:19 ` Andrea Bolognani
2016-03-04 2:52 ` [Qemu-arm] " Peter Xu
2016-03-04 2:52 ` [Qemu-devel] " Peter Xu
2016-03-04 8:43 ` Andrea Bolognani
2016-03-07 4:27 ` [Qemu-arm] " Peter Xu
2016-03-07 4:27 ` [Qemu-devel] " Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304022208.GE30973@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=abologna@redhat.com \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.