[PATCH] Staging: comedi: Use predefined macro offset_in_page() instead of (addr & ~PAGE_MASK).

[PATCH] Staging: comedi: Use predefined macro offset_in_page() instead of (addr & ~PAGE_MASK).

[Sandhya Bankar]

Use predefined macro offset_in_page() instead of (addr & ~PAGE_MASK).

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/comedi/comedi_fops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index d1cf6a1..7c7b477 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -2224,7 +2224,7 @@ static int comedi_mmap(struct file *file, struct vm_area_struct *vma)
 		retval = -EFAULT;
 		goto done;
 	}
-	if (size & (~PAGE_MASK)) {
+	if (offset_in_page(size)) {
 		retval = -EFAULT;
 		goto done;
 	}
-- 
1.8.3.4

Re: [Outreachy kernel] [PATCH] Staging: comedi: Use predefined macro offset_in_page() instead of (addr & ~PAGE_MASK).

[Julia Lawall]

On Sat, 5 Mar 2016, Sandhya Bankar wrote:

> Use predefined macro offset_in_page() instead of (addr & ~PAGE_MASK).
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/comedi/comedi_fops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index d1cf6a1..7c7b477 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -2224,7 +2224,7 @@ static int comedi_mmap(struct file *file, struct vm_area_struct *vma)
>  		retval = -EFAULT;
>  		goto done;
>  	}
> -	if (size & (~PAGE_MASK)) {
> +	if (offset_in_page(size)) {

Much nicer :)

julia

>  		retval = -EFAULT;
>  		goto done;
>  	}
> --
> 1.8.3.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160305000721.GA3072%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>